You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Elbehery (via GitHub)" <gi...@apache.org> on 2025/07/26 15:36:12 UTC
[PR] feat(test): add regression testing [iceberg-go]
Elbehery opened a new pull request, #504:
URL: https://github.com/apache/iceberg-go/pull/504
This PR adds regression testing.
cc @laskoviymishka @zeroshade
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] test: add regression testing [iceberg-go]
Posted by "Elbehery (via GitHub)" <gi...@apache.org>.
Elbehery commented on PR #504:
URL: https://github.com/apache/iceberg-go/pull/504#issuecomment-3123633791
ok, i will deduplicate everything :)
thx :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] test: add regression testing [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade closed pull request #504: test: add regression testing
URL: https://github.com/apache/iceberg-go/pull/504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] test: add regression testing [iceberg-go]
Posted by "Elbehery (via GitHub)" <gi...@apache.org>.
Elbehery commented on PR #504:
URL: https://github.com/apache/iceberg-go/pull/504#issuecomment-3123591151
> > could we keep it open for now, till we sure we dont need anything from it ?
>
> Does this mean you aren't going to shrink this PR down to only tests which aren't covered elsewhere?
indeed i need your direction to which test are needed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] test: add regression testing [iceberg-go]
Posted by "Elbehery (via GitHub)" <gi...@apache.org>.
Elbehery commented on PR #504:
URL: https://github.com/apache/iceberg-go/pull/504#issuecomment-3123534595
> What is being tested by this that isn't already covered with the existing tests? I don't really see the need for these tests
thanks for your review
I propose to start merging what you find useful and skip the rest :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] test: add regression testing [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #504:
URL: https://github.com/apache/iceberg-go/pull/504#issuecomment-3123531722
What is being tested by this that isn't already covered with the existing tests? I don't really see the need for these tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] test: add regression testing [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #504:
URL: https://github.com/apache/iceberg-go/pull/504#issuecomment-3123586156
> could we keep it open for now, till we sure we dont need anything from it ?
Does this mean you aren't going to shrink this PR down to only tests which aren't covered elsewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] test: add regression testing [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #504:
URL: https://github.com/apache/iceberg-go/pull/504#issuecomment-3123549774
> I propose to start merging what you find useful and skip the rest :)
I don't have the time available to do that. Can you please reduce this down to only tests that aren't already covered by existing test cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] test: add regression testing [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #504:
URL: https://github.com/apache/iceberg-go/pull/504#issuecomment-3124467284
ASF [guidelines](https://www.apache.org/legal/generative-tooling.html) prohibit entirely AI generated PRs. You can use an LLM to assist you, but cannot submit a PR that is entirely AI generated. As such I'm going to close this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] test: add regression testing [iceberg-go]
Posted by "Elbehery (via GitHub)" <gi...@apache.org>.
Elbehery commented on PR #504:
URL: https://github.com/apache/iceberg-go/pull/504#issuecomment-3123574182
> > I propose to start merging what you find useful and skip the rest :)
>
> I don't have the time available to do that. Can you please reduce this down to only tests that aren't already covered by existing test cases?
understood 👍🏽
could we keep it open for now, till we sure we dont need anything from it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] test: add regression testing [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #504:
URL: https://github.com/apache/iceberg-go/pull/504#issuecomment-3123604143
> indeed i need your direction to which test are needed :)
I don't have the bandwidth or resources to do that, sorry. If you are willing to do so yourself and update this PR then I'll review it. Otherwise we should close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org