You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2017/05/29 15:27:33 UTC
Re: Review Request 58720: Extended the unit test infrastructure in
the new Mesos CLI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58720/
-----------------------------------------------------------
(Updated May 29, 2017, 3:27 p.m.)
Review request for mesos and Kevin Klues.
Changes
-------
Code rebased.
Summary (updated)
-----------------
Extended the unit test infrastructure in the new Mesos CLI.
Bugs: MESOS-7283
https://issues.apache.org/jira/browse/MESOS-7283
Repository: mesos
Description
-------
This infrastructure includes the ability to bring up a test cluster to
run the CLI against. Future unit tests will use this infrastructure to
test their commands against a running mesos cluster. The tests require
some binaries created when building Mesos.
Diffs (updated)
-----
src/cli_new/lib/cli/__init__.py 4ddbb0eb5ea2c79db852e7b27ef702869316c3f3
src/cli_new/lib/cli/tests/__init__.py PRE-CREATION
src/cli_new/lib/cli/tests/base.py PRE-CREATION
src/cli_new/lib/cli/tests/constants.py PRE-CREATION
src/cli_new/lib/cli/tests/tests.py PRE-CREATION
src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83
src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6
Diff: https://reviews.apache.org/r/58720/diff/13/
Changes: https://reviews.apache.org/r/58720/diff/12-13/
Testing
-------
PEP8 and Pylint used to make sure that the code style is correct. Manuel test:
$ cd src/cli_new
$ ./bootstrap
$ source activate
(mesos-cli) $ mesos-cli-tests
Thanks,
Armand Grillet
Re: Review Request 58720: Extended the unit test infrastructure in
the new Mesos CLI.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58720/#review176382
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58720]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On May 30, 2017, 5:25 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58720/
> -----------------------------------------------------------
>
> (Updated May 30, 2017, 5:25 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7283
> https://issues.apache.org/jira/browse/MESOS-7283
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This infrastructure includes the ability to bring up a test cluster to
> run the CLI against. Future unit tests will use this infrastructure to
> test their commands against a running mesos cluster. The tests require
> some binaries created when building Mesos.
>
>
> Diffs
> -----
>
> src/cli_new/lib/cli/tests/__init__.py PRE-CREATION
> src/cli_new/lib/cli/tests/base.py PRE-CREATION
> src/cli_new/lib/cli/tests/constants.py PRE-CREATION
> src/cli_new/lib/cli/tests/tests.py PRE-CREATION
> src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83
> src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6
>
>
> Diff: https://reviews.apache.org/r/58720/diff/15/
>
>
> Testing
> -------
>
> PEP8 and Pylint used to make sure that the code style is correct. Manuel test:
>
> $ cd src/cli_new
> $ ./bootstrap
> $ source activate
>
> (mesos-cli) $ mesos-cli-tests
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 58720: Extended the unit test infrastructure in
the new Mesos CLI.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58720/#review176357
-----------------------------------------------------------
Fix it, then Ship it!
I am just waiting on two things before committing this:
1) A ShipIt for https://reviews.apache.org/r/59634 so I can land that before this one.
2) Andrei, to either drop his issue or comment on why he thinks we should follow his suggestion.
src/cli_new/lib/cli/tests/base.py
Lines 216 (patched)
<https://reviews.apache.org/r/58720/#comment249747>
My `sys.platform` was `linux2`, so I changed this to:
```
# Disabling systemd support on Linux to run without sudo.
if "linux" in sys.platform and "systemd_enable_support" not in flags:
flags["systemd_enable_support"] = "false"
```
I will commit this without needing another round of reviews.
- Kevin Klues
On May 30, 2017, 5:25 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58720/
> -----------------------------------------------------------
>
> (Updated May 30, 2017, 5:25 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7283
> https://issues.apache.org/jira/browse/MESOS-7283
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This infrastructure includes the ability to bring up a test cluster to
> run the CLI against. Future unit tests will use this infrastructure to
> test their commands against a running mesos cluster. The tests require
> some binaries created when building Mesos.
>
>
> Diffs
> -----
>
> src/cli_new/lib/cli/tests/__init__.py PRE-CREATION
> src/cli_new/lib/cli/tests/base.py PRE-CREATION
> src/cli_new/lib/cli/tests/constants.py PRE-CREATION
> src/cli_new/lib/cli/tests/tests.py PRE-CREATION
> src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83
> src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6
>
>
> Diff: https://reviews.apache.org/r/58720/diff/15/
>
>
> Testing
> -------
>
> PEP8 and Pylint used to make sure that the code style is correct. Manuel test:
>
> $ cd src/cli_new
> $ ./bootstrap
> $ source activate
>
> (mesos-cli) $ mesos-cli-tests
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 58720: Extended the unit test infrastructure in
the new Mesos CLI.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58720/#review177631
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On June 12, 2017, 3:49 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58720/
> -----------------------------------------------------------
>
> (Updated June 12, 2017, 3:49 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7283
> https://issues.apache.org/jira/browse/MESOS-7283
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This infrastructure includes the ability to bring up a test cluster to
> run the CLI against. Future unit tests will use this infrastructure to
> test their commands against a running mesos cluster. The tests require
> some binaries created when building Mesos.
>
>
> Diffs
> -----
>
> src/cli_new/lib/cli/tests/__init__.py PRE-CREATION
> src/cli_new/lib/cli/tests/base.py PRE-CREATION
> src/cli_new/lib/cli/tests/constants.py PRE-CREATION
> src/cli_new/lib/cli/tests/tests.py PRE-CREATION
> src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83
> src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6
>
>
> Diff: https://reviews.apache.org/r/58720/diff/16/
>
>
> Testing
> -------
>
> PEP8 and Pylint used to make sure that the code style is correct. Manuel test:
>
> $ cd src/cli_new
> $ ./bootstrap
> $ source activate
>
> (mesos-cli) $ mesos-cli-tests
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 58720: Extended the unit test infrastructure in
the new Mesos CLI.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58720/#review177630
-----------------------------------------------------------
src/cli_new/lib/cli/tests/base.py
Lines 216 (patched)
<https://reviews.apache.org/r/58720/#comment251324>
I had to change this line as:
```
diff --git a/src/cli_new/lib/cli/tests/base.py b/src/cli_new/lib/cli/tests/base.py
index 94cbb0879..62a4ee8ac 100644
--- a/src/cli_new/lib/cli/tests/base.py
+++ b/src/cli_new/lib/cli/tests/base.py
@@ -213,7 +213,7 @@ class Agent(Executable):
if "runtime_dir" not in flags:
flags["runtime_dir"] = tempfile.mkdtemp()
# Disabling systemd support on Linux to run without sudo.
- if sys.platform == "linux" and "systemd_enable_support" not in flags:
+ if "linux" in sys.platform and "systemd_enable_support" not in flags:
flags["systemd_enable_support"] = "false"
self.flags = flags
```
I will simply commit this witht his change in leiu of doing another round of reviews.
Thanks for beig so patient!
- Kevin Klues
On June 12, 2017, 3:49 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58720/
> -----------------------------------------------------------
>
> (Updated June 12, 2017, 3:49 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7283
> https://issues.apache.org/jira/browse/MESOS-7283
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This infrastructure includes the ability to bring up a test cluster to
> run the CLI against. Future unit tests will use this infrastructure to
> test their commands against a running mesos cluster. The tests require
> some binaries created when building Mesos.
>
>
> Diffs
> -----
>
> src/cli_new/lib/cli/tests/__init__.py PRE-CREATION
> src/cli_new/lib/cli/tests/base.py PRE-CREATION
> src/cli_new/lib/cli/tests/constants.py PRE-CREATION
> src/cli_new/lib/cli/tests/tests.py PRE-CREATION
> src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83
> src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6
>
>
> Diff: https://reviews.apache.org/r/58720/diff/16/
>
>
> Testing
> -------
>
> PEP8 and Pylint used to make sure that the code style is correct. Manuel test:
>
> $ cd src/cli_new
> $ ./bootstrap
> $ source activate
>
> (mesos-cli) $ mesos-cli-tests
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 58720: Extended the unit test infrastructure in
the new Mesos CLI.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58720/#review177634
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59634, 58720]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On June 12, 2017, 8:49 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58720/
> -----------------------------------------------------------
>
> (Updated June 12, 2017, 8:49 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7283
> https://issues.apache.org/jira/browse/MESOS-7283
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This infrastructure includes the ability to bring up a test cluster to
> run the CLI against. Future unit tests will use this infrastructure to
> test their commands against a running mesos cluster. The tests require
> some binaries created when building Mesos.
>
>
> Diffs
> -----
>
> src/cli_new/lib/cli/tests/__init__.py PRE-CREATION
> src/cli_new/lib/cli/tests/base.py PRE-CREATION
> src/cli_new/lib/cli/tests/constants.py PRE-CREATION
> src/cli_new/lib/cli/tests/tests.py PRE-CREATION
> src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83
> src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6
>
>
> Diff: https://reviews.apache.org/r/58720/diff/16/
>
>
> Testing
> -------
>
> PEP8 and Pylint used to make sure that the code style is correct. Manuel test:
>
> $ cd src/cli_new
> $ ./bootstrap
> $ source activate
>
> (mesos-cli) $ mesos-cli-tests
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 58720: Extended the unit test infrastructure in
the new Mesos CLI.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58720/
-----------------------------------------------------------
(Updated June 12, 2017, 3:49 p.m.)
Review request for mesos and Kevin Klues.
Changes
-------
Updated the 'depends on field' so the chain gets pulled in correctly.
Bugs: MESOS-7283
https://issues.apache.org/jira/browse/MESOS-7283
Repository: mesos
Description
-------
This infrastructure includes the ability to bring up a test cluster to
run the CLI against. Future unit tests will use this infrastructure to
test their commands against a running mesos cluster. The tests require
some binaries created when building Mesos.
Diffs
-----
src/cli_new/lib/cli/tests/__init__.py PRE-CREATION
src/cli_new/lib/cli/tests/base.py PRE-CREATION
src/cli_new/lib/cli/tests/constants.py PRE-CREATION
src/cli_new/lib/cli/tests/tests.py PRE-CREATION
src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83
src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6
Diff: https://reviews.apache.org/r/58720/diff/16/
Testing
-------
PEP8 and Pylint used to make sure that the code style is correct. Manuel test:
$ cd src/cli_new
$ ./bootstrap
$ source activate
(mesos-cli) $ mesos-cli-tests
Thanks,
Armand Grillet
Re: Review Request 58720: Extended the unit test infrastructure in
the new Mesos CLI.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58720/#review176439
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58720]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On May 31, 2017, 2:10 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58720/
> -----------------------------------------------------------
>
> (Updated May 31, 2017, 2:10 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7283
> https://issues.apache.org/jira/browse/MESOS-7283
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This infrastructure includes the ability to bring up a test cluster to
> run the CLI against. Future unit tests will use this infrastructure to
> test their commands against a running mesos cluster. The tests require
> some binaries created when building Mesos.
>
>
> Diffs
> -----
>
> src/cli_new/lib/cli/tests/__init__.py PRE-CREATION
> src/cli_new/lib/cli/tests/base.py PRE-CREATION
> src/cli_new/lib/cli/tests/constants.py PRE-CREATION
> src/cli_new/lib/cli/tests/tests.py PRE-CREATION
> src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83
> src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6
>
>
> Diff: https://reviews.apache.org/r/58720/diff/16/
>
>
> Testing
> -------
>
> PEP8 and Pylint used to make sure that the code style is correct. Manuel test:
>
> $ cd src/cli_new
> $ ./bootstrap
> $ source activate
>
> (mesos-cli) $ mesos-cli-tests
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 58720: Extended the unit test infrastructure in
the new Mesos CLI.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58720/
-----------------------------------------------------------
(Updated May 31, 2017, 12:10 p.m.)
Review request for mesos and Kevin Klues.
Changes
-------
Last issue fixed and code rebased.
Bugs: MESOS-7283
https://issues.apache.org/jira/browse/MESOS-7283
Repository: mesos
Description
-------
This infrastructure includes the ability to bring up a test cluster to
run the CLI against. Future unit tests will use this infrastructure to
test their commands against a running mesos cluster. The tests require
some binaries created when building Mesos.
Diffs (updated)
-----
src/cli_new/lib/cli/tests/__init__.py PRE-CREATION
src/cli_new/lib/cli/tests/base.py PRE-CREATION
src/cli_new/lib/cli/tests/constants.py PRE-CREATION
src/cli_new/lib/cli/tests/tests.py PRE-CREATION
src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83
src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6
Diff: https://reviews.apache.org/r/58720/diff/16/
Changes: https://reviews.apache.org/r/58720/diff/15-16/
Testing
-------
PEP8 and Pylint used to make sure that the code style is correct. Manuel test:
$ cd src/cli_new
$ ./bootstrap
$ source activate
(mesos-cli) $ mesos-cli-tests
Thanks,
Armand Grillet
Re: Review Request 58720: Extended the unit test infrastructure in
the new Mesos CLI.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58720/
-----------------------------------------------------------
(Updated May 30, 2017, 5:25 p.m.)
Review request for mesos and Kevin Klues.
Changes
-------
Management of `MESOS_BUILD_DIR` improved.
Bugs: MESOS-7283
https://issues.apache.org/jira/browse/MESOS-7283
Repository: mesos
Description
-------
This infrastructure includes the ability to bring up a test cluster to
run the CLI against. Future unit tests will use this infrastructure to
test their commands against a running mesos cluster. The tests require
some binaries created when building Mesos.
Diffs (updated)
-----
src/cli_new/lib/cli/tests/__init__.py PRE-CREATION
src/cli_new/lib/cli/tests/base.py PRE-CREATION
src/cli_new/lib/cli/tests/constants.py PRE-CREATION
src/cli_new/lib/cli/tests/tests.py PRE-CREATION
src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83
src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6
Diff: https://reviews.apache.org/r/58720/diff/15/
Changes: https://reviews.apache.org/r/58720/diff/14-15/
Testing
-------
PEP8 and Pylint used to make sure that the code style is correct. Manuel test:
$ cd src/cli_new
$ ./bootstrap
$ source activate
(mesos-cli) $ mesos-cli-tests
Thanks,
Armand Grillet
Re: Review Request 58720: Extended the unit test infrastructure in
the new Mesos CLI.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58720/
-----------------------------------------------------------
(Updated May 30, 2017, 10 a.m.)
Review request for mesos and Kevin Klues.
Changes
-------
Code rebased and issues regarding imports and `systemd_enable_support` fixed.
Bugs: MESOS-7283
https://issues.apache.org/jira/browse/MESOS-7283
Repository: mesos
Description
-------
This infrastructure includes the ability to bring up a test cluster to
run the CLI against. Future unit tests will use this infrastructure to
test their commands against a running mesos cluster. The tests require
some binaries created when building Mesos.
Diffs (updated)
-----
src/cli_new/lib/cli/tests/__init__.py PRE-CREATION
src/cli_new/lib/cli/tests/base.py PRE-CREATION
src/cli_new/lib/cli/tests/constants.py PRE-CREATION
src/cli_new/lib/cli/tests/tests.py PRE-CREATION
src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83
src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6
Diff: https://reviews.apache.org/r/58720/diff/14/
Changes: https://reviews.apache.org/r/58720/diff/13-14/
Testing
-------
PEP8 and Pylint used to make sure that the code style is correct. Manuel test:
$ cd src/cli_new
$ ./bootstrap
$ source activate
(mesos-cli) $ mesos-cli-tests
Thanks,
Armand Grillet
Re: Review Request 58720: Extended the unit test infrastructure in
the new Mesos CLI.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58720/#review176282
-----------------------------------------------------------
src/cli_new/lib/cli/tests/base.py
Lines 177-188 (patched)
<https://reviews.apache.org/r/58720/#comment249648>
I had to add the following to get this to run on my system without sudo:
```
if "systemd_enable_support" not in flags:
flags["systemd_enable_support"] = "false"
```
This seems like a reasonable default to set...
- Kevin Klues
On May 29, 2017, 3:27 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58720/
> -----------------------------------------------------------
>
> (Updated May 29, 2017, 3:27 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7283
> https://issues.apache.org/jira/browse/MESOS-7283
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This infrastructure includes the ability to bring up a test cluster to
> run the CLI against. Future unit tests will use this infrastructure to
> test their commands against a running mesos cluster. The tests require
> some binaries created when building Mesos.
>
>
> Diffs
> -----
>
> src/cli_new/lib/cli/__init__.py 4ddbb0eb5ea2c79db852e7b27ef702869316c3f3
> src/cli_new/lib/cli/tests/__init__.py PRE-CREATION
> src/cli_new/lib/cli/tests/base.py PRE-CREATION
> src/cli_new/lib/cli/tests/constants.py PRE-CREATION
> src/cli_new/lib/cli/tests/tests.py PRE-CREATION
> src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83
> src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6
>
>
> Diff: https://reviews.apache.org/r/58720/diff/13/
>
>
> Testing
> -------
>
> PEP8 and Pylint used to make sure that the code style is correct. Manuel test:
>
> $ cd src/cli_new
> $ ./bootstrap
> $ source activate
>
> (mesos-cli) $ mesos-cli-tests
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 58720: Extended the unit test infrastructure in
the new Mesos CLI.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58720/#review176295
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59628, 58720]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 29, 2017, 5:27 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58720/
> -----------------------------------------------------------
>
> (Updated May 29, 2017, 5:27 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7283
> https://issues.apache.org/jira/browse/MESOS-7283
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This infrastructure includes the ability to bring up a test cluster to
> run the CLI against. Future unit tests will use this infrastructure to
> test their commands against a running mesos cluster. The tests require
> some binaries created when building Mesos.
>
>
> Diffs
> -----
>
> src/cli_new/lib/cli/__init__.py 4ddbb0eb5ea2c79db852e7b27ef702869316c3f3
> src/cli_new/lib/cli/tests/__init__.py PRE-CREATION
> src/cli_new/lib/cli/tests/base.py PRE-CREATION
> src/cli_new/lib/cli/tests/constants.py PRE-CREATION
> src/cli_new/lib/cli/tests/tests.py PRE-CREATION
> src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83
> src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6
>
>
> Diff: https://reviews.apache.org/r/58720/diff/13/
>
>
> Testing
> -------
>
> PEP8 and Pylint used to make sure that the code style is correct. Manuel test:
>
> $ cd src/cli_new
> $ ./bootstrap
> $ source activate
>
> (mesos-cli) $ mesos-cli-tests
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 58720: Extended the unit test infrastructure in
the new Mesos CLI.
Posted by Kevin Klues <kl...@gmail.com>.
> On May 29, 2017, 10:24 p.m., Kevin Klues wrote:
> > This is still failing for me after the rebase:
> > ```
> > (mesos-cli) $ mesos
> > Traceback (most recent call last):
> > File "/scratch/klueska/projects/mesos/src/cli_new/bin/main.py", line 25, in <module>
> > import cli
> > File "/scratch/klueska/projects/mesos/src/cli_new/lib/cli/__init__.py", line 22, in <module>
> > from . import constants
> > ImportError: cannot import name constants
> > ```
> >
> > Then after fixing this error by removing `from . import constants` from `__init__.py`:
> >
> > ```
> > (mesos-cli) $ mesos-cli-tests
> > Traceback (most recent call last):
> > File "/scratch/klueska/projects/mesos/src/cli_new/bin/../tests/main.py", line 27, in <module>
> > from cli.tests import TestInfrastructure
> > File "/scratch/klueska/projects/mesos/src/cli_new/lib/cli/__init__.py", line 21, in <module>
> > from . import config
> > File "/scratch/klueska/projects/mesos/src/cli_new/lib/cli/config.py", line 24, in <module>
> > import settings
> > ImportError: No module named settings
> > ```
I see what happened, I didn't apply https://reviews.apache.org/r/59628/ before running this. Please see comments there.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58720/#review176276
-----------------------------------------------------------
On May 29, 2017, 3:27 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58720/
> -----------------------------------------------------------
>
> (Updated May 29, 2017, 3:27 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7283
> https://issues.apache.org/jira/browse/MESOS-7283
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This infrastructure includes the ability to bring up a test cluster to
> run the CLI against. Future unit tests will use this infrastructure to
> test their commands against a running mesos cluster. The tests require
> some binaries created when building Mesos.
>
>
> Diffs
> -----
>
> src/cli_new/lib/cli/__init__.py 4ddbb0eb5ea2c79db852e7b27ef702869316c3f3
> src/cli_new/lib/cli/tests/__init__.py PRE-CREATION
> src/cli_new/lib/cli/tests/base.py PRE-CREATION
> src/cli_new/lib/cli/tests/constants.py PRE-CREATION
> src/cli_new/lib/cli/tests/tests.py PRE-CREATION
> src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83
> src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6
>
>
> Diff: https://reviews.apache.org/r/58720/diff/13/
>
>
> Testing
> -------
>
> PEP8 and Pylint used to make sure that the code style is correct. Manuel test:
>
> $ cd src/cli_new
> $ ./bootstrap
> $ source activate
>
> (mesos-cli) $ mesos-cli-tests
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 58720: Extended the unit test infrastructure in
the new Mesos CLI.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58720/#review176276
-----------------------------------------------------------
This is still failing for me after the rebase:
```
(mesos-cli) $ mesos
Traceback (most recent call last):
File "/scratch/klueska/projects/mesos/src/cli_new/bin/main.py", line 25, in <module>
import cli
File "/scratch/klueska/projects/mesos/src/cli_new/lib/cli/__init__.py", line 22, in <module>
from . import constants
ImportError: cannot import name constants
```
Then after fixing this error by removing `from . import constants` from `__init__.py`:
```
(mesos-cli) $ mesos-cli-tests
Traceback (most recent call last):
File "/scratch/klueska/projects/mesos/src/cli_new/bin/../tests/main.py", line 27, in <module>
from cli.tests import TestInfrastructure
File "/scratch/klueska/projects/mesos/src/cli_new/lib/cli/__init__.py", line 21, in <module>
from . import config
File "/scratch/klueska/projects/mesos/src/cli_new/lib/cli/config.py", line 24, in <module>
import settings
ImportError: No module named settings
```
src/cli_new/lib/cli/__init__.py
Lines 22 (patched)
<https://reviews.apache.org/r/58720/#comment249644>
This file doesn't exist, so we can't import it.
- Kevin Klues
On May 29, 2017, 3:27 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58720/
> -----------------------------------------------------------
>
> (Updated May 29, 2017, 3:27 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7283
> https://issues.apache.org/jira/browse/MESOS-7283
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This infrastructure includes the ability to bring up a test cluster to
> run the CLI against. Future unit tests will use this infrastructure to
> test their commands against a running mesos cluster. The tests require
> some binaries created when building Mesos.
>
>
> Diffs
> -----
>
> src/cli_new/lib/cli/__init__.py 4ddbb0eb5ea2c79db852e7b27ef702869316c3f3
> src/cli_new/lib/cli/tests/__init__.py PRE-CREATION
> src/cli_new/lib/cli/tests/base.py PRE-CREATION
> src/cli_new/lib/cli/tests/constants.py PRE-CREATION
> src/cli_new/lib/cli/tests/tests.py PRE-CREATION
> src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83
> src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6
>
>
> Diff: https://reviews.apache.org/r/58720/diff/13/
>
>
> Testing
> -------
>
> PEP8 and Pylint used to make sure that the code style is correct. Manuel test:
>
> $ cd src/cli_new
> $ ./bootstrap
> $ source activate
>
> (mesos-cli) $ mesos-cli-tests
>
>
> Thanks,
>
> Armand Grillet
>
>