You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by pdxrunner <gi...@git.apache.org> on 2016/10/19 15:30:12 UTC

[GitHub] incubator-geode pull request #264: Feature/geode 538

GitHub user pdxrunner opened a pull request:

    https://github.com/apache/incubator-geode/pull/264

    Feature/geode 538

    Changes have been reviewed at https://reviews.apache.org/r/52891/

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pdxrunner/incubator-geode feature/GEODE-538

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-geode/pull/264.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #264
    
----
commit 6ed78b4f5e44c1f3b4847dfdaa5c10a8df886ae9
Author: Ken Howe <kh...@pivotal.io>
Date:   2016-10-06T22:02:24Z

    GEODE-538: Add check for persistent data recovery
    
    PartitionedRegion.getNodeForBucketReadOrLoad can return an invalid node
    if persistent data recovery is in process and a get() targets a bucket
    that
    hasn't been recoverd yet. This can result in returning an incorrect
    value (null) or throwing ConflictingPersistentDataException from a get()
    or put() on the region.
    
    This change adds a check for persistent recovery to be completed
    before creating the new bucket. If recovery isn't complete then the
    operation on the region will fail with a PartitionOfflineException.
    
    Queries on a region while persistent recovery is in progress can also
    result in incorrect results so a similar check is added to
    DefaultQuery.checkQueryOnPR.

commit 2f8cfbaf10fcefb8f14eab6bbedef090d88a96dd
Author: Ken Howe <kh...@pivotal.io>
Date:   2016-10-17T23:03:50Z

    GEODE-538: Refactored check for persistent recovery
    
    Moved the recovery check to a new method in PartitionedRegion instead of
    having duplicated code in PRHARedundancyProvider and DefaultQuery.
    
    Added throws declaration to javadoc in the Query Interface

commit 77768628ba59f8a4b7d3bdb6738a9c1dcd91a4ac
Author: Ken Howe <kh...@pivotal.io>
Date:   2016-10-18T17:11:24Z

    GEODE-538: Added PartitionOfflineException to javadocs
    
    Added the exception declaration to the javadocs for other execute
    methods.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #264: Feature/geode 538

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-geode/pull/264


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---