[jira] Commented: (THRIFT-339) the compiler should abort (or warn) if an argument doesn't have a field key

["Jonathan Ellis (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672783#action_12672783 ] 

Jonathan Ellis commented on THRIFT-339:
---------------------------------------

i thought the field keys are supposed to be optional, which is good, because they fuglify things up quite well. :)

> the compiler should abort (or warn) if an argument doesn't have a field key
> ---------------------------------------------------------------------------
>
>                 Key: THRIFT-339
>                 URL: https://issues.apache.org/jira/browse/THRIFT-339
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (Python)
>            Reporter: Jonathan Ellis
>
> Esteve's last change to how default values are stored broke stuff.  Here is a quick example:
> {{
> service Test
> {
>   bool  get_slice(i32 start = -1),
> }
> }}
> generates
> {{
> class get_slice_args:
>   thrift_spec = None
>   def __init__(self, start=thrift_spec[-1][4],):
>     self.start = start
> }}
> which is obviously invalid.
> I'm not sure how thrift_spec is supposed to be populated here so I'm unsure how to fix this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.