You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2025/12/03 05:30:43 UTC

[PR] [SPARK-54578][SQL] Perform Code Cleanup on `AssignmentUtils` [spark]

LuciferYang opened a new pull request, #53302:
URL: https://github.com/apache/spark/pull/53302

   ### What changes were proposed in this pull request?
   This PR performs a code cleanup on `AssignmentUtils`:  
   
   1. Deleted the redundant private methods `getMissingSourcePaths` and `createNullCheckForFieldPath`, which were introduced in [PR #53149](https://github.com/apache/spark/pull/53149) but became obsolete after [PR #53229](https://github.com/apache/spark/pull/53229).  
   
   2. Removed the redundant documentation for the invalid input parameter `missingSourcePaths` in the `alignUpdateAssignments` method.  
   
   3. Removed the unused input parameter `updateStar` from the private method `applyAssignments`.  
   
   4. Corrected a spelling error in the input parameter `coerceNestedTypes` of the private method `applyFieldAssignments`.  
   
   
   ### Why are the changes needed?
   Code Cleanup.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   - Pass Github Actions
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-54578][SQL] Perform Code Cleanup on `AssignmentUtils` [spark]

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #53302:
URL: https://github.com/apache/spark/pull/53302#issuecomment-3615056153

   Thank you @dongjoon-hyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-54578][SQL] Perform Code Cleanup on `AssignmentUtils` [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #53302: [SPARK-54578][SQL] Perform Code Cleanup on `AssignmentUtils`
URL: https://github.com/apache/spark/pull/53302


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org