You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/01/23 19:16:27 UTC

[GitHub] [helix] alirezazamani commented on a change in pull request #698: Implement Azure cloud instance information processor

alirezazamani commented on a change in pull request #698: Implement Azure cloud instance information processor
URL: https://github.com/apache/helix/pull/698#discussion_r370305161
 
 

 ##########
 File path: helix-core/src/test/resources/AzureResponse.json
 ##########
 @@ -0,0 +1,104 @@
+{
+  "compute": {
+    "azEnvironment": "AzurePublicCloud",
+    "customData": "",
+    "location": "southcentralus",
+    "name": "ei-lid-vmss-kafka_1",
 
 Review comment:
   I would prefer to use other names such as "Test-Helix" in our tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org