[GitHub] [spark] HyukjinKwon commented on a change in pull request #31721: [SPARK-34603][SQL] Support ADD ARCHIVE and LIST ARCHIVES command

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #31721:
URL: https://github.com/apache/spark/pull/31721#discussion_r586386027



##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
##########
@@ -857,6 +857,30 @@ class HiveQuerySuite extends HiveComparisonTest with SQLTestUtils with BeforeAnd
     assert(sql(s"list file $testFile").count() == 1)
   }
 
+  test("ADD ARCHIVE command") {
+    val testFile =
+      TestHive.getHiveFile("data/files/archives1/archive1.tar.gz").toURI.toString + "#link1"
+    sql(s"ADD ARCHIVE $testFile")

Review comment:
       I think it would be easier to read if we generate a zip file here. `TestUtils.createJar` creates a jar (zip) file. So It think this utility can be used instead. I added a similar test in `SparkContextSuite.SPARK-33530: basic case for addArchive and listArchives`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org