You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/27 11:36:12 UTC
[GitHub] [spark] HeartSaVioR opened a new pull request, #39247: [SPARK-41733][SQL][SS] Apply tree-pattern based pruning for the rule ResolveWindowTime
HeartSaVioR opened a new pull request, #39247:
URL: https://github.com/apache/spark/pull/39247
### What changes were proposed in this pull request?
This PR proposes to apply tree-pattern based pruning for the rule ResolveWindowTime, to minimize the evaluation of rule with WindowTime node.
### Why are the changes needed?
The rule ResolveWindowTime is unnecessarily evaluated multiple times without proper pruning.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing tests. New test case is added to cover SQL usage for `window_time`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #39247: [SPARK-41733][SQL][SS] Apply tree-pattern based pruning for the rule ResolveWindowTime
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on PR #39247:
URL: https://github.com/apache/spark/pull/39247#issuecomment-1365841711
cc. @cloud-fan @rxin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #39247: [SPARK-41733][SQL][SS] Apply tree-pattern based pruning for the rule ResolveWindowTime
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on PR #39247:
URL: https://github.com/apache/spark/pull/39247#issuecomment-1366416569
Thanks! Merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #39247: [SPARK-41733][SQL][SS] Apply tree-pattern based pruning for the rule ResolveWindowTime
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on PR #39247:
URL: https://github.com/apache/spark/pull/39247#issuecomment-1366416497
https://github.com/HeartSaVioR/spark/runs/10328690654
Looks like GA fails to pull the test result. Build succeeded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #39247: [SPARK-41733][SQL][SS] Apply tree-pattern based pruning for the rule ResolveWindowTime
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on PR #39247:
URL: https://github.com/apache/spark/pull/39247#issuecomment-1366297569
cc. @viirya as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #39247: [SPARK-41733][SQL][SS] Apply tree-pattern based pruning for the rule ResolveWindowTime
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on PR #39247:
URL: https://github.com/apache/spark/pull/39247#issuecomment-1366352458
The change is only to rebase the fix due to the conflict from #39245. I'm going to merge once the CI passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR closed pull request #39247: [SPARK-41733][SQL][SS] Apply tree-pattern based pruning for the rule ResolveWindowTime
Posted by GitBox <gi...@apache.org>.
HeartSaVioR closed pull request #39247: [SPARK-41733][SQL][SS] Apply tree-pattern based pruning for the rule ResolveWindowTime
URL: https://github.com/apache/spark/pull/39247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org