You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/21 18:06:41 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #2765: Use hashbrown::RawTable API
tustvold opened a new pull request, #2765:
URL: https://github.com/apache/arrow-rs/pull/2765
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
The use of HashMap without a hasher nor keys, is a little perverse. It turns out hashbrown has a RawTable API that we can use directly instead. As an added bonus this provides a very minor performance improvement
```
string_dictionary_builder/(dict_size:20, len:1000, key_len: 5)
time: [18.563 µs 18.605 µs 18.647 µs]
change: [-4.5058% -3.6392% -2.7326%] (p = 0.00 < 0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
3 (3.00%) low mild
2 (2.00%) high mild
3 (3.00%) high severe
string_dictionary_builder/(dict_size:100, len:1000, key_len: 5)
time: [21.649 µs 21.693 µs 21.738 µs]
change: [-2.2389% -1.8649% -1.5032%] (p = 0.00 < 0.05)
Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severe
string_dictionary_builder/(dict_size:100, len:1000, key_len: 10)
time: [21.696 µs 21.715 µs 21.734 µs]
change: [-2.0519% -1.8956% -1.6960%] (p = 0.00 < 0.05)
Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severe
string_dictionary_builder/(dict_size:100, len:10000, key_len: 10)
time: [176.06 µs 176.14 µs 176.22 µs]
change: [-0.9251% -0.6795% -0.4273%] (p = 0.00 < 0.05)
Change within noise threshold.
Found 5 outliers among 100 measurements (5.00%)
1 (1.00%) low mild
2 (2.00%) high mild
2 (2.00%) high severe
string_dictionary_builder/(dict_size:100, len:10000, key_len: 100)
time: [463.94 µs 464.12 µs 464.30 µs]
change: [-0.1715% -0.0733% +0.0237%] (p = 0.15 > 0.05)
No change in performance detected.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe
```
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Switches to using hashbrown::RawTable in place of HashMap and the raw entry API
# Are there any user-facing changes?
No
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Dandandan commented on pull request #2765: Use hashbrown::RawTable API
Posted by GitBox <gi...@apache.org>.
Dandandan commented on PR #2765:
URL: https://github.com/apache/arrow-rs/pull/2765#issuecomment-1254093207
I think you need to explicitly enable this feature?
I also used it in the hash join implementation (and I think in hash aggregate as well):
https://github.com/apache/arrow-datafusion/blob/master/datafusion/core/Cargo.toml#L72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #2765: Use hashbrown::RawTable API
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #2765:
URL: https://github.com/apache/arrow-rs/pull/2765#issuecomment-1254068168
Just realised this API is marked experimental
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #2765: Use hashbrown::RawTable API
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #2765:
URL: https://github.com/apache/arrow-rs/pull/2765#issuecomment-1255986612
Yeah, I'm just a little bit unsure what the implications of this being an experimental API are... I'll revisit this after #2769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold closed pull request #2765: Use hashbrown::RawTable API
Posted by GitBox <gi...@apache.org>.
tustvold closed pull request #2765: Use hashbrown::RawTable API
URL: https://github.com/apache/arrow-rs/pull/2765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org