[GitHub] vvysotskyi edited a comment on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values

[GitBox <gi...@apache.org>]

vvysotskyi edited a comment on issue #1481: DRILL-6763: Codegen optimization of SQL functions with constant values
URL: https://github.com/apache/drill/pull/1481#issuecomment-429280849
 
 
   @lushuifeng, I meant to replace 
   `Map<JMethod, Function<DrillBuf, ? extends ValueHolder>> setters`
   with something like this: 
   `Map<JMethod, Pair<String, Function<DrillBuf, ? extends ValueHolder>>> setters`,
   where the `String` is the name of nested class field, or the name, which corresponds to the full path to this class, for example like this: `nestedClassField.nestedNestedClassField.nestedNestedNestedClassField`. So in the `CodeGenMemberInjector.injectMembers()`, required nested class instance may be received using its name and setter method may be called on it. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services