You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/19 15:35:44 UTC
[GitHub] [spark] Yikun opened a new pull request, #37585: [SPARK-39310][PS] Change `requires_same_anchor` to `check_same_anchor`
Yikun opened a new pull request, #37585:
URL: https://github.com/apache/spark/pull/37585
### What changes were proposed in this pull request?
Change `requires_same_anchor` to `check_same_anchor` for `_update_internal_frame` func
### Why are the changes needed?
There were some discussion in https://github.com/apache/spark/pull/36353#discussion_r882216133 , this parameter is a flag for whether checking the same anchor.
Consider it's a parameter of internal use function, it can be renamed safely.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #37585: [SPARK-39310][PS] Change `requires_same_anchor` to `check_same_anchor`
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #37585:
URL: https://github.com/apache/spark/pull/37585#issuecomment-1220814630
cc @itholic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37585: [SPARK-39310][PS] Change `requires_same_anchor` to `check_same_anchor`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37585:
URL: https://github.com/apache/spark/pull/37585#issuecomment-1221191787
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #37585: [SPARK-39310][PS] Change `requires_same_anchor` to `check_same_anchor`
Posted by GitBox <gi...@apache.org>.
itholic commented on PR #37585:
URL: https://github.com/apache/spark/pull/37585#issuecomment-1229687388
Sorry, I couldn't been focusing on review for some personal health issue.
Thanks for addressing this, @Yikun ! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #37585: [SPARK-39310][PS] Change `requires_same_anchor` to `check_same_anchor`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #37585: [SPARK-39310][PS] Change `requires_same_anchor` to `check_same_anchor`
URL: https://github.com/apache/spark/pull/37585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org