You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/03/25 06:22:28 UTC
[GitHub] [pinot] qqu0127 commented on a change in pull request #8325: [WIP] Upgrade Helix to 1.0.2 in Pinot (not ready yet)
qqu0127 commented on a change in pull request #8325:
URL: https://github.com/apache/pinot/pull/8325#discussion_r834983581
##########
File path: pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java
##########
@@ -331,9 +328,11 @@ protected void addFakeServerInstanceToAutoJoinHelixCluster(String instanceId, bo
} else {
helixAdmin.addInstanceTag(getHelixClusterName(), instanceId, UNTAGGED_SERVER_INSTANCE);
}
- HelixConfigScope configScope = new HelixConfigScopeBuilder(HelixConfigScope.ConfigScopeProperty.PARTICIPANT,
- getHelixClusterName()).forParticipant(instanceId).build();
- helixAdmin.setConfig(configScope, Collections.singletonMap(ADMIN_PORT_KEY, Integer.toString(adminPort)));
+ HelixConfigScope configScope =
+ new HelixConfigScopeBuilder(HelixConfigScope.ConfigScopeProperty.PARTICIPANT, getHelixClusterName())
+ .forParticipant(instanceId).build();
+ helixAdmin.setConfig(configScope,
+ Collections.singletonMap(CommonConstants.Helix.Instance.ADMIN_PORT_KEY, Integer.toString(adminPort)));
_fakeInstanceHelixManagers.add(helixManager);
}
Review comment:
Remove static instance usage around line 350
##########
File path: pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java
##########
@@ -249,8 +248,6 @@ protected void addFakeBrokerInstanceToAutoJoinHelixCluster(String instanceId, bo
public static class FakeBrokerResourceOnlineOfflineStateModelFactory extends StateModelFactory<StateModel> {
private static final String STATE_MODEL_DEF = "BrokerResourceOnlineOfflineStateModel";
- private static final FakeBrokerResourceOnlineOfflineStateModelFactory FACTORY_INSTANCE =
- new FakeBrokerResourceOnlineOfflineStateModelFactory();
private static final FakeBrokerResourceOnlineOfflineStateModel STATE_MODEL_INSTANCE =
new FakeBrokerResourceOnlineOfflineStateModel();
Review comment:
Remove static instance usage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org