You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "liugang (JIRA)" <ji...@apache.org> on 2012/10/29 05:55:11 UTC

[jira] [Created] (CAMEL-5754) useOriginalMessage parameter of DefaultErrorHandler never be used

liugang created CAMEL-5754:
------------------------------

             Summary: useOriginalMessage parameter of DefaultErrorHandler never be used
                 Key: CAMEL-5754
                 URL: https://issues.apache.org/jira/browse/CAMEL-5754
             Project: Camel
          Issue Type: Bug
          Components: camel-core
    Affects Versions: 2.10.2
         Environment: Camel 2.10.2 and old versions
            Reporter: liugang
            Priority: Minor


When declare a default error handle, the *useOriginalMessage* is configurable:
{code}
errorHandler(defaultErrorHandler().useOriginalMessage())
{code}
but is never be used, when creating *DefaultErrorHandler*, the passed parameter always false:
{code}
    public DefaultErrorHandler(CamelContext camelContext, Processor output, CamelLogger logger, Processor redeliveryProcessor,
            RedeliveryPolicy redeliveryPolicy, ExceptionPolicyStrategy exceptionPolicyStrategy, Predicate retryWhile, ScheduledExecutorService executorService) {

        super(camelContext, output, logger, redeliveryProcessor, redeliveryPolicy, null, null, *false*, retryWhile, executorService);
        setExceptionPolicy(exceptionPolicyStrategy);
    }
{code}

but it works when using Dead letter queue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (CAMEL-5754) useOriginalMessage parameter of DefaultErrorHandler never be used

Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-5754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Willem Jiang resolved CAMEL-5754.
---------------------------------

    Resolution: Not A Problem
    
> useOriginalMessage parameter of DefaultErrorHandler never be used
> -----------------------------------------------------------------
>
>                 Key: CAMEL-5754
>                 URL: https://issues.apache.org/jira/browse/CAMEL-5754
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.10.2
>         Environment: Camel 2.10.2 and old versions
>            Reporter: liugang
>            Assignee: Willem Jiang
>            Priority: Minor
>
> When declare a default error handle, the *useOriginalMessage* is configurable:
> {code}
> errorHandler(defaultErrorHandler().useOriginalMessage())
> {code}
> but is never be used, when creating *DefaultErrorHandler*, the passed parameter always false:
> {code}
>     public DefaultErrorHandler(CamelContext camelContext, Processor output, CamelLogger logger, Processor redeliveryProcessor,
>             RedeliveryPolicy redeliveryPolicy, ExceptionPolicyStrategy exceptionPolicyStrategy, Predicate retryWhile, ScheduledExecutorService executorService) {
>         super(camelContext, output, logger, redeliveryProcessor, redeliveryPolicy, null, null, false, retryWhile, executorService);
>         setExceptionPolicy(exceptionPolicyStrategy);
>     }
> {code}
> but it works when using Dead letter queue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (CAMEL-5754) useOriginalMessage parameter of DefaultErrorHandler never be used

Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-5754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Willem Jiang reassigned CAMEL-5754:
-----------------------------------

    Assignee: Willem Jiang
    
> useOriginalMessage parameter of DefaultErrorHandler never be used
> -----------------------------------------------------------------
>
>                 Key: CAMEL-5754
>                 URL: https://issues.apache.org/jira/browse/CAMEL-5754
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.10.2
>         Environment: Camel 2.10.2 and old versions
>            Reporter: liugang
>            Assignee: Willem Jiang
>            Priority: Minor
>
> When declare a default error handle, the *useOriginalMessage* is configurable:
> {code}
> errorHandler(defaultErrorHandler().useOriginalMessage())
> {code}
> but is never be used, when creating *DefaultErrorHandler*, the passed parameter always false:
> {code}
>     public DefaultErrorHandler(CamelContext camelContext, Processor output, CamelLogger logger, Processor redeliveryProcessor,
>             RedeliveryPolicy redeliveryPolicy, ExceptionPolicyStrategy exceptionPolicyStrategy, Predicate retryWhile, ScheduledExecutorService executorService) {
>         super(camelContext, output, logger, redeliveryProcessor, redeliveryPolicy, null, null, false, retryWhile, executorService);
>         setExceptionPolicy(exceptionPolicyStrategy);
>     }
> {code}
> but it works when using Dead letter queue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CAMEL-5754) useOriginalMessage parameter of DefaultErrorHandler never be used

Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-5754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485836#comment-13485836 ] 

Willem Jiang commented on CAMEL-5754:
-------------------------------------

It's not a bug, as the defaultErrorHandler will not use the original message by default, and it provides a way to let you set the option by using the DSL.
For the DeadLetterChannel, it needs to use the original message for store or processing.

Please drop an email to the user at camel.apache.org if you are not sure about the usage of API, so we can make things clear before filling a JIRA.
                
> useOriginalMessage parameter of DefaultErrorHandler never be used
> -----------------------------------------------------------------
>
>                 Key: CAMEL-5754
>                 URL: https://issues.apache.org/jira/browse/CAMEL-5754
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.10.2
>         Environment: Camel 2.10.2 and old versions
>            Reporter: liugang
>            Assignee: Willem Jiang
>            Priority: Minor
>
> When declare a default error handle, the *useOriginalMessage* is configurable:
> {code}
> errorHandler(defaultErrorHandler().useOriginalMessage())
> {code}
> but is never be used, when creating *DefaultErrorHandler*, the passed parameter always false:
> {code}
>     public DefaultErrorHandler(CamelContext camelContext, Processor output, CamelLogger logger, Processor redeliveryProcessor,
>             RedeliveryPolicy redeliveryPolicy, ExceptionPolicyStrategy exceptionPolicyStrategy, Predicate retryWhile, ScheduledExecutorService executorService) {
>         super(camelContext, output, logger, redeliveryProcessor, redeliveryPolicy, null, null, false, retryWhile, executorService);
>         setExceptionPolicy(exceptionPolicyStrategy);
>     }
> {code}
> but it works when using Dead letter queue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CAMEL-5754) useOriginalMessage parameter of DefaultErrorHandler never be used

Posted by "liugang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-5754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485840#comment-13485840 ] 

liugang commented on CAMEL-5754:
--------------------------------

Thanks. Yes, I understand it's may not a problem (even user can get the original message, I don't know how to use it in default error handler case). my problem is the API may make the user misleading.
                
> useOriginalMessage parameter of DefaultErrorHandler never be used
> -----------------------------------------------------------------
>
>                 Key: CAMEL-5754
>                 URL: https://issues.apache.org/jira/browse/CAMEL-5754
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.10.2
>         Environment: Camel 2.10.2 and old versions
>            Reporter: liugang
>            Assignee: Willem Jiang
>            Priority: Minor
>
> When declare a default error handle, the *useOriginalMessage* is configurable:
> {code}
> errorHandler(defaultErrorHandler().useOriginalMessage())
> {code}
> but is never be used, when creating *DefaultErrorHandler*, the passed parameter always false:
> {code}
>     public DefaultErrorHandler(CamelContext camelContext, Processor output, CamelLogger logger, Processor redeliveryProcessor,
>             RedeliveryPolicy redeliveryPolicy, ExceptionPolicyStrategy exceptionPolicyStrategy, Predicate retryWhile, ScheduledExecutorService executorService) {
>         super(camelContext, output, logger, redeliveryProcessor, redeliveryPolicy, null, null, false, retryWhile, executorService);
>         setExceptionPolicy(exceptionPolicyStrategy);
>     }
> {code}
> but it works when using Dead letter queue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CAMEL-5754) useOriginalMessage parameter of DefaultErrorHandler never be used

Posted by "liugang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-5754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

liugang updated CAMEL-5754:
---------------------------

    Description: 
When declare a default error handle, the *useOriginalMessage* is configurable:
{code}
errorHandler(defaultErrorHandler().useOriginalMessage())
{code}
but is never be used, when creating *DefaultErrorHandler*, the passed parameter always false:
{code}
    public DefaultErrorHandler(CamelContext camelContext, Processor output, CamelLogger logger, Processor redeliveryProcessor,
            RedeliveryPolicy redeliveryPolicy, ExceptionPolicyStrategy exceptionPolicyStrategy, Predicate retryWhile, ScheduledExecutorService executorService) {

        super(camelContext, output, logger, redeliveryProcessor, redeliveryPolicy, null, null, false, retryWhile, executorService);
        setExceptionPolicy(exceptionPolicyStrategy);
    }
{code}

but it works when using Dead letter queue.

  was:
When declare a default error handle, the *useOriginalMessage* is configurable:
{code}
errorHandler(defaultErrorHandler().useOriginalMessage())
{code}
but is never be used, when creating *DefaultErrorHandler*, the passed parameter always false:
{code}
    public DefaultErrorHandler(CamelContext camelContext, Processor output, CamelLogger logger, Processor redeliveryProcessor,
            RedeliveryPolicy redeliveryPolicy, ExceptionPolicyStrategy exceptionPolicyStrategy, Predicate retryWhile, ScheduledExecutorService executorService) {

        super(camelContext, output, logger, redeliveryProcessor, redeliveryPolicy, null, null, *false*, retryWhile, executorService);
        setExceptionPolicy(exceptionPolicyStrategy);
    }
{code}

but it works when using Dead letter queue.

    
> useOriginalMessage parameter of DefaultErrorHandler never be used
> -----------------------------------------------------------------
>
>                 Key: CAMEL-5754
>                 URL: https://issues.apache.org/jira/browse/CAMEL-5754
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.10.2
>         Environment: Camel 2.10.2 and old versions
>            Reporter: liugang
>            Priority: Minor
>
> When declare a default error handle, the *useOriginalMessage* is configurable:
> {code}
> errorHandler(defaultErrorHandler().useOriginalMessage())
> {code}
> but is never be used, when creating *DefaultErrorHandler*, the passed parameter always false:
> {code}
>     public DefaultErrorHandler(CamelContext camelContext, Processor output, CamelLogger logger, Processor redeliveryProcessor,
>             RedeliveryPolicy redeliveryPolicy, ExceptionPolicyStrategy exceptionPolicyStrategy, Predicate retryWhile, ScheduledExecutorService executorService) {
>         super(camelContext, output, logger, redeliveryProcessor, redeliveryPolicy, null, null, false, retryWhile, executorService);
>         setExceptionPolicy(exceptionPolicyStrategy);
>     }
> {code}
> but it works when using Dead letter queue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira