You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "lahodaj (via GitHub)" <gi...@apache.org> on 2025/11/03 18:38:18 UTC
Re: [PR] Propagate refactoring problems to LSP client [netbeans]
lahodaj commented on PR #8968:
URL: https://github.com/apache/netbeans/pull/8968#issuecomment-3481972691
Overall +1 on reporting the warnings to the user.
But, please:
- there's a lot of code duplication in each refactoring class that handles the warnings, etc. Is there a chance that would be factored out into `CodeRefactoring`? Maybe it would also allow to reduce churn in that class?
- in `java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/refactoring/MoveRefactoring.java`, it seems there's a huge amount of changes, which are probably mostly formatting(?) - I would suggest to undo that, it makes it very hard to review that part of the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists