[GitHub] [druid] cryptoe commented on a change in pull request #12248: Fix zulu8 install in Load From Apache Hadoop tutorial

[GitBox <gi...@apache.org>]

cryptoe commented on a change in pull request #12248:
URL: https://github.com/apache/druid/pull/12248#discussion_r840187701



##########
File path: examples/quickstart/tutorial/hadoop3/docker/Dockerfile
##########
@@ -36,12 +36,22 @@ RUN ssh-keygen -q -N "" -t rsa -f /etc/ssh/ssh_host_rsa_key
 RUN ssh-keygen -q -N "" -t rsa -f /root/.ssh/id_rsa
 RUN cp /root/.ssh/id_rsa.pub /root/.ssh/authorized_keys
 
-# zulu java 8
-COPY setup-zulu-repo.sh /root/setup-zulu-repo.sh
-RUN /root/setup-zulu-repo.sh
-RUN yum install -y zulu-8
+#
+# Pull Zulu OpenJDK binaries from official repository:
+#
+
+ARG ZULU_REPO_VER=1.0.0-1

Review comment:
       I think u missed https://github.com/apache/druid/blob/master/examples/quickstart/tutorial/hadoop3/docker/setup-zulu-repo.sh file. 
   This can be deleted as well :) . 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org