You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "C. Michael Pilato" <cm...@collab.net> on 2004/04/28 14:49:24 UTC
Re: [PATCH] Get-Locations TNG Rev. 26 - Using the New Specification
Shlomi Fish <sh...@iglu.org.il> writes:
> <<<
> Adds an libsvn_fs layer function to efficiently trace the file
> historical (and to a limited extent) location based on its peg
> revision+path.
How many times do I have to say this? PUT THIS FUNCTIONALITY INTO THE
SVN_REPOS LIBRARY, NOT THE SVN_FS LIBRARY. Your first clue should be
the fact that your tree.c additions do nothing but consume public
libsvn_fs APIs. I'm a fully -1 on your touching libsvn_fs at all for
this change.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Get-Locations TNG Rev. 26 - Using the New Specification
Posted by Shlomi Fish <sh...@iglu.org.il>.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Get-Locations TNG Rev. 26 - Using the New Specification
Posted by Ben Collins-Sussman <su...@collab.net>.
On Wed, 2004-04-28 at 09:49, C. Michael Pilato wrote:
> Shlomi Fish <sh...@iglu.org.il> writes:
>
> > <<<
> > Adds an libsvn_fs layer function to efficiently trace the file
> > historical (and to a limited extent) location based on its peg
> > revision+path.
>
> How many times do I have to say this? PUT THIS FUNCTIONALITY INTO THE
> SVN_REPOS LIBRARY, NOT THE SVN_FS LIBRARY. Your first clue should be
> the fact that your tree.c additions do nothing but consume public
> libsvn_fs APIs. I'm a fully -1 on your touching libsvn_fs at all for
> this change.
Whoops, I completely agree with Mike, but also completely forgot about
this. Sorry for not reiterating in IRC, Shlomi.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org