You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/24 12:20:18 UTC

[GitHub] [pulsar] BewareMyPower opened a new pull request #10349: [C++] Add isConnected() method

BewareMyPower opened a new pull request #10349:
URL: https://github.com/apache/pulsar/pull/10349


   ### Motivation
   
   Add `isConnected()` method to `Producer`, `Consumer` and `Reader` in C++ client.
   
   ### Modifications
   
   - Implement `isConnected()` method that checks the network connection and state and add related tests.
   - Unify the signature of overrided methods to avoid compile warnings like `overrides a member function but is not marked 'override' [-Winconsistent-missing-override]**`.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change added tests and can be verified as follows:
   - `ProducerTest.testIsConnected`
   - `ConsumerTest.testIsConnected`
   - `ReaderTest.testIsConnected`
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (**yes**)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (**yes**)
     - If yes, how is the feature documented? (**docs**)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #10349: [C++] Add isConnected() method

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #10349:
URL: https://github.com/apache/pulsar/pull/10349#issuecomment-826169376


   @BewareMyPower docs should be updated as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #10349: [C++] Add isConnected() method

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #10349:
URL: https://github.com/apache/pulsar/pull/10349


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #10349: [C++] Add isConnected() method

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #10349:
URL: https://github.com/apache/pulsar/pull/10349#issuecomment-826193711


   > @BewareMyPower docs should be updated as well?
   
   I've already added it in C++ headers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] BewareMyPower commented on pull request #10349: [C++] Add isConnected() method

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #10349:
URL: https://github.com/apache/pulsar/pull/10349#issuecomment-826193711


   > @BewareMyPower docs should be updated as well?
   
   I've already added it in C++ headers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #10349: [C++] Add isConnected() method

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #10349:
URL: https://github.com/apache/pulsar/pull/10349#issuecomment-826169376


   @BewareMyPower docs should be updated as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #10349: [C++] Add isConnected() method

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #10349:
URL: https://github.com/apache/pulsar/pull/10349


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org