Re: [PR] feat: add support for bookworm arm-64 [arrow-adbc]

["kou (via GitHub)" <gi...@apache.org>]

kou commented on code in PR #3004:
URL: https://github.com/apache/arrow-adbc/pull/3004#discussion_r2157869607


##########
ci/linux-packages/apt/debian-bookworm-arm64/Dockerfile:
##########


Review Comment:
   We can use `from` file not `Dockerfile` like https://github.com/apache/arrow/blob/main/dev/tasks/linux-packages/apache-arrow/apt/debian-bookworm-arm64/from .



##########
ci/linux-packages/Rakefile:
##########
@@ -130,7 +130,7 @@ class ADBCPackageTask < PackageTask
   def apt_targets_default
     [
       "debian-bookworm",
-      # "debian-bookworm-arm64",
+      "debian-bookworm-arm64",

Review Comment:
   We don't need this. Because the CI job specify the APT target explicitly instead of using the default targets.



##########
.github/workflows/packaging.yml:
##########
@@ -303,6 +303,7 @@ jobs:
           - almalinux-8
           - almalinux-9
           - debian-bookworm
+          - debian-bookworm-arm64

Review Comment:
   We want to use `ubuntu-24.04-arm` for arm64 build for performance. QEMU is slow.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org