[GitHub] [geode] kirklund commented on a diff in pull request #7573: GEODE-8228: Fixes flaky WAN tests

[GitBox <gi...@apache.org>]

kirklund commented on code in PR #7573:
URL: https://github.com/apache/geode/pull/7573#discussion_r848884767


##########
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/Simple2CacheServerDistributedTest.java:
##########
@@ -63,11 +63,11 @@ public void doMultipleCacheServer(boolean durable) throws Exception {
     int serverPort2 = vm2.invoke(WANTestBase::createCacheServer);
 
     if (durable) {
-      vm2.invoke(Simple2CacheServerDUnitTest::setCacheClientProxyTestHook);
+      vm2.invoke(Simple2CacheServerDistributedTest::setCacheClientProxyTestHook);
     } else {
-      vm3.invoke(Simple2CacheServerDUnitTest::setClientServerObserver);
+      vm3.invoke(Simple2CacheServerDistributedTest::setClientServerObserver);
     }
-    vm3.invoke(() -> CacheClientNotifierDUnitTest.createClientWithLocator(lnPort, "localhost",
+    vm3.invoke(() -> CacheClientNotifierDistributedTest.createClientWithLocator(lnPort, "localhost",

Review Comment:
   Might want to extract `createClientWithLocator` to a new helper class to untangle these two distributed tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org