You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/01/19 01:05:33 UTC
[GitHub] mistercrunch commented on issue #6696: Making thrift,
pyhive and tableschema as extra_requires
mistercrunch commented on issue #6696: Making thrift, pyhive and tableschema as extra_requires
URL: https://github.com/apache/incubator-superset/pull/6696#issuecomment-455734184
Good call. I just didn't think about running `pip-compile`. I ran it just now and it removes the deps from `requirements.txt` which I think is what we want.
Now given that the `extra_requires` is optional, we could just be more prescriptive and pin things in that section of `setup.py` if needed/appropriate. Being prescriptive inside something optional is very different than being prescriptive in something that is forced/required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org