You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by QiangCai <gi...@git.apache.org> on 2019/01/08 07:56:51 UTC

[GitHub] carbondata pull request #3001: [CARBONDATA-3220] Support presto to read stre...

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3001#discussion_r245903277
  
    --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/CarbonVectorBatch.java ---
    @@ -95,6 +95,9 @@ private CarbonColumnVectorImpl createDirectStreamReader(int batchSize, DataType
         } else if (dataType == DataTypes.STRING) {
           return new SliceStreamReader(batchSize, field.getDataType(), dictionaryBlock);
         } else if (DataTypes.isDecimal(dataType)) {
    +      if (dictionary != null && dataType instanceof DecimalType) {
    --- End diff --
    
    when the decimal column uses dictionary encoding,  it can't work fine.
    the method field.getDataType() will return IntegerType, It is not Decimal type.


---