You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by alopresto <gi...@git.apache.org> on 2017/05/26 17:53:05 UTC
[GitHub] nifi pull request #1865: NIFI-3836 Added check for root user in test that de...
GitHub user alopresto opened a pull request:
https://github.com/apache/nifi/pull/1865
NIFI-3836 Added check for root user in test that depends on unreadabl…
…e file.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alopresto/nifi NIFI-3836
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1865.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1865
----
commit 8d5effabcf34fe79c894c8426528c3a2e298b556
Author: Andy LoPresto <al...@apache.org>
Date: 2017-05-26T17:27:18Z
NIFI-3836 Added check for root user in test that depends on unreadable file.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1865: NIFI-3836 Added check for root user in test that de...
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1865#discussion_r118784606
--- Diff: nifi-commons/nifi-data-provenance-utils/src/test/groovy/org/apache/nifi/provenance/CryptoUtilsTest.groovy ---
@@ -88,6 +88,11 @@ class CryptoUtilsTest {
Cipher.getMaxAllowedKeyLength("AES") > 128
}
+ private static boolean isRootUser() {
+ Process p = Runtime.getRuntime().exec("id -u")
+ p.exitValue() == 0
--- End diff --
Yep, excellent catch. I'll fix it to evaluate the response, not the exit code. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1865: NIFI-3836 Added check for root user in test that de...
Posted by jfrazee <gi...@git.apache.org>.
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1865#discussion_r118769414
--- Diff: nifi-commons/nifi-data-provenance-utils/src/test/groovy/org/apache/nifi/provenance/CryptoUtilsTest.groovy ---
@@ -88,6 +88,11 @@ class CryptoUtilsTest {
Cipher.getMaxAllowedKeyLength("AES") > 128
}
+ private static boolean isRootUser() {
+ Process p = Runtime.getRuntime().exec("id -u")
+ p.exitValue() == 0
--- End diff --
Isn't this just going to be true whenever `id -u` succeeds?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1865: NIFI-3836 Added check for root user in test that depends o...
Posted by jfrazee <gi...@git.apache.org>.
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1865
@alopresto I was expecting to see System.getProperty("user.name") used instead of the exec. But I'm a little naive about what the drawback could be; maybe because you could override it and then user.name isn't actually the user.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1865: NIFI-3836 Added check for root user in test that depends o...
Posted by jfrazee <gi...@git.apache.org>.
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1865
@alopresto Welp, TestGetFile has similar problems. This one LGTM so question is whether we want to merge this one or expand the scope; thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1865: NIFI-3836 Added check for root user in test that depends o...
Posted by jfrazee <gi...@git.apache.org>.
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1865
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1865: NIFI-3836 Added check for root user in test that de...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1865
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1865: NIFI-3836 Added check for root user in test that depends o...
Posted by jfrazee <gi...@git.apache.org>.
Github user jfrazee commented on the issue:
https://github.com/apache/nifi/pull/1865
@alopresto +1 will open another JIRA for covering the rest of the problems.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1865: NIFI-3836 Added check for root user in test that depends o...
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/1865
This can be verified by running the Maven test suite in `nifi-commons/nifi-data-provenance-utils` as the `root` user. The process `id -u` should return `0` for the `root` user and a non-`0` value for other users.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---