You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/11/23 15:15:00 UTC

[GitHub] [ignite-3] rpuch opened a new pull request, #1371: IGNITE-18240 Store logical topology as a single KV entry instead of a number of entries

rpuch opened a new pull request, #1371:
URL: https://github.com/apache/ignite-3/pull/1371

   https://issues.apache.org/jira/browse/IGNITE-18240


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-3] rpuch commented on a diff in pull request #1371: IGNITE-18240 Store logical topology as a single KV entry instead of a number of entries

Posted by GitBox <gi...@apache.org>.
rpuch commented on code in PR #1371:
URL: https://github.com/apache/ignite-3/pull/1371#discussion_r1031203798


##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/raft/RaftStorageManager.java:
##########
@@ -42,16 +47,20 @@ class RaftStorageManager {
     /** Storage key for the CMG state. */
     private static final byte[] CMG_STATE_KEY = "cmg_state".getBytes(UTF_8);
 
-    /** Prefix for the keys for logical topology nodes. */
-    private static final byte[] LOGICAL_TOPOLOGY_PREFIX = "logical_".getBytes(UTF_8);
+    /** Storage key for the logical topology. */
+    private static final byte[] LOGICAL_TOPOLOGY_KEY = "logical".getBytes(UTF_8);
 
     /** Prefix for validation tokens. */
     private static final byte[] VALIDATED_NODE_PREFIX = "validation_".getBytes(UTF_8);
 
     private final ClusterStateStorage storage;
 
+    private volatile LogicalTopology currentLogicalTopology;

Review Comment:
   We initialize it in the constructor, so this seems excessive



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-3] SammyVimes merged pull request #1371: IGNITE-18240 Store logical topology as a single KV entry instead of a number of entries

Posted by GitBox <gi...@apache.org>.
SammyVimes merged PR #1371:
URL: https://github.com/apache/ignite-3/pull/1371


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #1371: IGNITE-18240 Store logical topology as a single KV entry instead of a number of entries

Posted by GitBox <gi...@apache.org>.
SammyVimes commented on code in PR #1371:
URL: https://github.com/apache/ignite-3/pull/1371#discussion_r1031177126


##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/raft/RaftStorageManager.java:
##########
@@ -42,16 +47,20 @@ class RaftStorageManager {
     /** Storage key for the CMG state. */
     private static final byte[] CMG_STATE_KEY = "cmg_state".getBytes(UTF_8);
 
-    /** Prefix for the keys for logical topology nodes. */
-    private static final byte[] LOGICAL_TOPOLOGY_PREFIX = "logical_".getBytes(UTF_8);
+    /** Storage key for the logical topology. */
+    private static final byte[] LOGICAL_TOPOLOGY_KEY = "logical".getBytes(UTF_8);
 
     /** Prefix for validation tokens. */
     private static final byte[] VALIDATED_NODE_PREFIX = "validation_".getBytes(UTF_8);
 
     private final ClusterStateStorage storage;
 
+    private volatile LogicalTopology currentLogicalTopology;

Review Comment:
   maybe pre-set it with INITIAL?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org