You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2015/11/07 02:29:56 UTC
Review Request 40044: Remove unused parameter in moveLayers()
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40044/
-----------------------------------------------------------
Review request for mesos and Timothy Chen.
Repository: mesos
Description
-------
Remove unused parameter in moveLayers()
Diffs
-----
src/slave/containerizer/mesos/provisioner/docker/store.cpp bb02d650e16d45fcf337a7954f7a26143fb2c69f
Diff: https://reviews.apache.org/r/40044/diff/
Testing
-------
make check (Ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
Re: Review Request 40044: Remove unused parameter in moveLayers()
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40044/#review105771
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Nov. 7, 2015, 1:29 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40044/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2015, 1:29 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Remove unused parameter in moveLayers()
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/store.cpp bb02d650e16d45fcf337a7954f7a26143fb2c69f
>
> Diff: https://reviews.apache.org/r/40044/diff/
>
>
> Testing
> -------
>
> make check (Ubuntu14.04 + clang-3.6)
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 40044: Remove unused parameter in moveLayers()
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40044/
-----------------------------------------------------------
(Updated Nov. 9, 2015, 4:01 p.m.)
Review request for mesos and Timothy Chen.
Repository: mesos
Description
-------
Remove unused parameter in moveLayers()
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/docker/store.cpp bb02d650e16d45fcf337a7954f7a26143fb2c69f
Diff: https://reviews.apache.org/r/40044/diff/
Testing
-------
make check (Ubuntu14.04 + clang-3.6)
Thanks,
Gilbert Song
Re: Review Request 40044: Remove unused parameter in moveLayers()
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40044/#review105573
-----------------------------------------------------------
Bad patch!
Reviews applied: [40044]
Failed command: ./support/apply-review.sh -n -r 40044
Error:
2015-11-07 04:37:24 URL:https://reviews.apache.org/r/40044/diff/raw/ [1211/1211] -> "40044.patch" [1]
error: src/slave/containerizer/mesos/provisioner/docker/store.cpp: does not exist in index
Failed to apply patch
- Mesos ReviewBot
On Nov. 7, 2015, 1:29 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40044/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2015, 1:29 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Remove unused parameter in moveLayers()
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/store.cpp bb02d650e16d45fcf337a7954f7a26143fb2c69f
>
> Diff: https://reviews.apache.org/r/40044/diff/
>
>
> Testing
> -------
>
> make check (Ubuntu14.04 + clang-3.6)
>
>
> Thanks,
>
> Gilbert Song
>
>