You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Murtadha Hubail (Code Review)" <do...@asterixdb.incubator.apache.org> on 2019/01/31 22:53:38 UTC

Change in asterixdb-bad[master]: [ASTERIXDB-2513][BAD] Adapt to DateTime API Change

Murtadha Hubail has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/3138

Change subject: [ASTERIXDB-2513][BAD] Adapt to DateTime API Change
......................................................................

[ASTERIXDB-2513][BAD] Adapt to DateTime API Change

Change-Id: I79b554eb760100c52a411b65774008fb98d6d1bf
---
M asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java
1 file changed, 1 insertion(+), 5 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad refs/changes/38/3138/1

diff --git a/asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java b/asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java
index 9da9e03..a353edc 100644
--- a/asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java
+++ b/asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java
@@ -178,11 +178,7 @@
                 int resultSetOffset = inputArg2.getStartOffset();
                 bbis.setByteBuffer(tRef.getFrameTupleAccessor().getBuffer(), resultSetOffset + 1);
                 ADateTime executionTime = ADateTimeSerializerDeserializer.INSTANCE.deserialize(di);
-                try {
-                    executionTimeString = executionTime.toSimpleString();
-                } catch (IOException e) {
-                    throw HyracksDataException.create(e);
-                }
+                executionTimeString = executionTime.toSimpleString();
             }
 
             int serBrokerOffset = inputArg0.getStartOffset();

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3138
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I79b554eb760100c52a411b65774008fb98d6d1bf
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>

Change in asterixdb-bad[master]: [ASTERIXDB-2513][BAD] Adapt to DateTime API Change

Posted by "Murtadha Hubail (Code Review)" <do...@asterixdb.incubator.apache.org>.
Murtadha Hubail has submitted this change and it was merged.

Change subject: [ASTERIXDB-2513][BAD] Adapt to DateTime API Change
......................................................................


[ASTERIXDB-2513][BAD] Adapt to DateTime API Change

Change-Id: I79b554eb760100c52a411b65774008fb98d6d1bf
---
M asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java
1 file changed, 1 insertion(+), 5 deletions(-)

Approvals:
  Jenkins: Verified
  Michael Blow: Looks good to me, approved



diff --git a/asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java b/asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java
index 9da9e03..a353edc 100644
--- a/asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java
+++ b/asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java
@@ -178,11 +178,7 @@
                 int resultSetOffset = inputArg2.getStartOffset();
                 bbis.setByteBuffer(tRef.getFrameTupleAccessor().getBuffer(), resultSetOffset + 1);
                 ADateTime executionTime = ADateTimeSerializerDeserializer.INSTANCE.deserialize(di);
-                try {
-                    executionTimeString = executionTime.toSimpleString();
-                } catch (IOException e) {
-                    throw HyracksDataException.create(e);
-                }
+                executionTimeString = executionTime.toSimpleString();
             }
 
             int serBrokerOffset = inputArg0.getStartOffset();

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3138
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I79b554eb760100c52a411b65774008fb98d6d1bf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>

Change in asterixdb-bad[master]: [ASTERIXDB-2513][BAD] Adapt to DateTime API Change

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2513][BAD] Adapt to DateTime API Change
......................................................................


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/367/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3138
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79b554eb760100c52a411b65774008fb98d6d1bf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No

Change in asterixdb-bad[master]: [ASTERIXDB-2513][BAD] Adapt to DateTime API Change

Posted by "Michael Blow (Code Review)" <do...@asterixdb.incubator.apache.org>.
Michael Blow has posted comments on this change.

Change subject: [ASTERIXDB-2513][BAD] Adapt to DateTime API Change
......................................................................


Patch Set 2: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3138
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79b554eb760100c52a411b65774008fb98d6d1bf
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: No

Change in asterixdb-bad[master]: [ASTERIXDB-2513][BAD] Adapt to DateTime API Change

Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2513][BAD] Adapt to DateTime API Change
......................................................................


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/366/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3138
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79b554eb760100c52a411b65774008fb98d6d1bf
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No