You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/10/17 00:38:17 UTC

[GitHub] [hudi] RocMarshal opened a new pull request #3813: [HUDI-2563][hudi-client] Refactor XScheduleCompactionActionExecutor and CompactionTriggerStrategy.

RocMarshal opened a new pull request #3813:
URL: https://github.com/apache/hudi/pull/3813


   
   
   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   **Refactor XScheduleCompactionActionExecutor and CompactionTriggerStrategy.**
   
   ## Brief change log
   
   - **Pull up some common methods from XXXScheduleCompactionActionExecutor to BaseScheduleCompactionActionExecutor.**
   
   - **Replace conditional in XXXScheduleCompactionActionExecutor with polymorphsim of CompactionTriggerStrategy class.**
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-972475571


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453",
       "triggerID" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437) 
   * 08173246c29fda1c9880f5ad897cf61423523e1a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-969797527


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2afbd368d00403fda5056e0e8795f18ee4582768 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400) 
   * d28da05aad1955161c37ee0800b8e89ed08ff1b5 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-976164451


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453",
       "triggerID" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617",
       "triggerID" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622",
       "triggerID" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 32af53f7ed580024923128fa63a9dcd2adbf2b56 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617) 
   * fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-976192862


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453",
       "triggerID" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617",
       "triggerID" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622",
       "triggerID" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3628",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3628) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] RocMarshal closed pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
RocMarshal closed pull request #3813:
URL: https://github.com/apache/hudi/pull/3813


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-992956175


   Ccn @yihua who worked on lot of client refactoring code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] RocMarshal edited a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
RocMarshal edited a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-968271847


   @xushiyan @yanghua @leesf .
   Excuse me.I looked into this CI failure case in the backgroud of this pr. There are some interesting appearance in test cases , such as `TestHoodieSparkMergeOnReadTableInsertUpdateDelete` referenced in the CI result. 
   
   `      
         
        String newCommitTime = "001"; // ---------------(1)
   
         client.startCommitWithTime(newCommitTime);
   
         List<HoodieRecord> records = dataGen.generateInserts(newCommitTime, 200);
   
         insertRecords(metaClient, records, client, cfg, newCommitTime);
   `
   
   The new `CompactionTriggerStrategy` will use commit instant time parameters and use delta commit info parameters to judge the state. 
   When the variable "001" tagged with `(1)` was transported into `HoodieInstantTimeGenerator#parseInstantTime(String timestamp)` , the `newCommitTime` value was not compatible with the parse pattern `yyyyMMddHHmmss` declared in `HoodieInstantTimeGenerator#INSTANT_TIME_FORMATTER`. At the same time, the compact configuration item was set as 'NUM_COMMITS' . As a result of the setting, the old `CompactionTriggerStrategy` would judge the state without instantTime parameters. The new `CompactionTriggerStrategy` will use both instantTime and commitNumber parameters to judge the state  on the contrary, which is the reason why the old  `CompactionTriggerStrategy` could be successful but new `CompactionTriggerStrategy` would be unsuccessful. With my limited read, we could enhance the validation of commitTime `(1)` in the target format `yyyyMMddHHmmss` or stop the refactor in the pr. 
   
   Please let me know what's your opinion.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] RocMarshal commented on a change in pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on a change in pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#discussion_r772792629



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/CompactionTriggerStrategy.java
##########
@@ -18,13 +18,116 @@
 
 package org.apache.hudi.table.action.compact;
 
+import java.text.ParseException;
+import org.apache.hudi.common.table.timeline.HoodieActiveTimeline;
+import org.apache.hudi.common.util.collection.Pair;
+import org.apache.hudi.exception.HoodieCompactionException;
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+
+@SuppressWarnings("checkstyle:LineLength")
 public enum CompactionTriggerStrategy {
-    // trigger compaction when reach N delta commits
-    NUM_COMMITS,
-    // trigger compaction when time elapsed > N seconds since last compaction
-    TIME_ELAPSED,
-    // trigger compaction when both NUM_COMMITS and TIME_ELAPSED are satisfied
-    NUM_AND_TIME,
-    // trigger compaction when NUM_COMMITS or TIME_ELAPSED is satisfied
-    NUM_OR_TIME
+
+  // trigger compaction when reach N delta commits
+  NUM_COMMITS {
+    @Override
+    public boolean compactable(
+        long compactInlineMaxDeltaCommits,

Review comment:
       @vinothchandar  What about replacing `inlineCompactDeltaCommitMax, inlineCompactDeltaSecondsMax` with `HoodieWriteConfig config` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] RocMarshal commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-998502857


   @vinothchandar I made some change based on your comments. PTAL. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-983000650


   @RocMarshal the last CI build passed. I'll take a pass later. We're close to land this. Thanks for the patience


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-944948402


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-944948402


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 822dbe03dc77531858ffd83ebeb91f210f4e7851 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yanghua commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-953426529


   @RocMarshal Please check the Azure CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 commented on a change in pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#discussion_r738002451



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/CompactionTriggerStrategy.java
##########
@@ -18,13 +18,87 @@
 
 package org.apache.hudi.table.action.compact;
 
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+
+@SuppressWarnings("checkstyle:LineLength")
 public enum CompactionTriggerStrategy {
-    // trigger compaction when reach N delta commits
-    NUM_COMMITS,
-    // trigger compaction when time elapsed > N seconds since last compaction
-    TIME_ELAPSED,
-    // trigger compaction when both NUM_COMMITS and TIME_ELAPSED are satisfied
-    NUM_AND_TIME,
-    // trigger compaction when NUM_COMMITS or TIME_ELAPSED is satisfied
-    NUM_OR_TIME
+
+  // trigger compaction when reach N delta commits
+  NUM_COMMITS {
+    @Override
+    public boolean compactable(long compactInlineMaxDeltaCommits,
+                               long deltaCommitsSinceLastCompaction,
+                               long compactInlineMaxDeltaSeconds,
+                               long deltaSecondsSinceLastCompaction) {
+      boolean compactable = compactInlineMaxDeltaCommits <= deltaCommitsSinceLastCompaction;
+      if (compactable) {
+        LOG.info(String.format("The delta commits >= %s, trigger compaction scheduler.", compactInlineMaxDeltaCommits));
+      }
+      return compactable;
+    }
+  },
+  // trigger compaction when time elapsed > N seconds since last compaction
+  TIME_ELAPSED {
+    @Override
+    public boolean compactable(long compactInlineMaxDeltaCommits,
+                               long deltaCommitsSinceLastCompaction,
+                               long compactInlineMaxDeltaSeconds,
+                               long deltaSecondsSinceLastCompaction) {
+      boolean compactable = compactInlineMaxDeltaSeconds <= deltaSecondsSinceLastCompaction;
+      if (compactable) {
+        LOG.info(String.format("The elapsed time >=%ss, trigger compaction scheduler.", compactInlineMaxDeltaSeconds));
+      }
+      return compactable;
+    }
+  },
+  // trigger compaction when both NUM_COMMITS and TIME_ELAPSED are satisfied
+  NUM_AND_TIME {
+    @Override
+    public boolean compactable(long compactInlineMaxDeltaCommits,
+                               long deltaCommitsSinceLastCompaction,
+                               long compactInlineMaxDeltaSeconds,
+                               long deltaSecondsSinceLastCompaction) {
+      boolean compactable = compactInlineMaxDeltaCommits <= deltaCommitsSinceLastCompaction
+          && compactInlineMaxDeltaSeconds <= deltaSecondsSinceLastCompaction;
+      if (compactable) {
+        LOG.info(String.format("The delta commits >= %s or elapsed_time >=%ss, trigger compaction scheduler.",
+            compactInlineMaxDeltaCommits, compactInlineMaxDeltaSeconds));
+      }
+      return compactable;
+    }
+  },
+  // trigger compaction when NUM_COMMITS or TIME_ELAPSED is satisfied
+  NUM_OR_TIME {
+    @Override
+    public boolean compactable(long compactInlineMaxDeltaCommits,
+                               long deltaCommitsSinceLastCompaction,
+                               long compactInlineMaxDeltaSeconds,
+                               long deltaSecondsSinceLastCompaction) {
+      boolean compactable = compactInlineMaxDeltaCommits <= deltaCommitsSinceLastCompaction
+          || compactInlineMaxDeltaSeconds <= deltaSecondsSinceLastCompaction;
+      if (compactable) {
+        LOG.info(String.format("The delta commits >= %s and elapsed_time >=%ss, trigger compaction scheduler.",
+            compactInlineMaxDeltaCommits, compactInlineMaxDeltaSeconds));
+      }
+      return compactable;
+    }
+  };
+
+  /**
+   * Judge if the strategy  could fire based on the condition.
+   *
+   * @param compactInlineMaxDeltaCommits    {@link org.apache.hudi.config.HoodieCompactionConfig#INLINE_COMPACT_NUM_DELTA_COMMITS}
+   * @param deltaCommitsSinceLastCompaction value in the condition.
+   * @param compactInlineMaxDeltaSeconds    {@link org.apache.hudi.config.HoodieCompactionConfig#INLINE_COMPACT_TIME_DELTA_SECONDS}
+   * @param deltaSecondsSinceLastCompaction value in the condition.
+   * @return true if it could be triggered, false else.

Review comment:
       Can we fix the document of param `deltaCommitsSinceLastCompaction ` and `deltaSecondsSinceLastCompaction `, give a detailed explanation.

##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/CompactionTriggerStrategy.java
##########
@@ -18,13 +18,87 @@
 
 package org.apache.hudi.table.action.compact;
 
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+
+@SuppressWarnings("checkstyle:LineLength")
 public enum CompactionTriggerStrategy {
-    // trigger compaction when reach N delta commits
-    NUM_COMMITS,
-    // trigger compaction when time elapsed > N seconds since last compaction
-    TIME_ELAPSED,
-    // trigger compaction when both NUM_COMMITS and TIME_ELAPSED are satisfied
-    NUM_AND_TIME,
-    // trigger compaction when NUM_COMMITS or TIME_ELAPSED is satisfied
-    NUM_OR_TIME
+
+  // trigger compaction when reach N delta commits
+  NUM_COMMITS {
+    @Override
+    public boolean compactable(long compactInlineMaxDeltaCommits,
+                               long deltaCommitsSinceLastCompaction,
+                               long compactInlineMaxDeltaSeconds,
+                               long deltaSecondsSinceLastCompaction) {
+      boolean compactable = compactInlineMaxDeltaCommits <= deltaCommitsSinceLastCompaction;
+      if (compactable) {
+        LOG.info(String.format("The delta commits >= %s, trigger compaction scheduler.", compactInlineMaxDeltaCommits));
+      }
+      return compactable;
+    }
+  },
+  // trigger compaction when time elapsed > N seconds since last compaction
+  TIME_ELAPSED {
+    @Override
+    public boolean compactable(long compactInlineMaxDeltaCommits,
+                               long deltaCommitsSinceLastCompaction,
+                               long compactInlineMaxDeltaSeconds,
+                               long deltaSecondsSinceLastCompaction) {
+      boolean compactable = compactInlineMaxDeltaSeconds <= deltaSecondsSinceLastCompaction;
+      if (compactable) {
+        LOG.info(String.format("The elapsed time >=%ss, trigger compaction scheduler.", compactInlineMaxDeltaSeconds));
+      }
+      return compactable;
+    }
+  },
+  // trigger compaction when both NUM_COMMITS and TIME_ELAPSED are satisfied
+  NUM_AND_TIME {
+    @Override
+    public boolean compactable(long compactInlineMaxDeltaCommits,
+                               long deltaCommitsSinceLastCompaction,
+                               long compactInlineMaxDeltaSeconds,
+                               long deltaSecondsSinceLastCompaction) {
+      boolean compactable = compactInlineMaxDeltaCommits <= deltaCommitsSinceLastCompaction
+          && compactInlineMaxDeltaSeconds <= deltaSecondsSinceLastCompaction;
+      if (compactable) {
+        LOG.info(String.format("The delta commits >= %s or elapsed_time >=%ss, trigger compaction scheduler.",
+            compactInlineMaxDeltaCommits, compactInlineMaxDeltaSeconds));
+      }
+      return compactable;
+    }
+  },
+  // trigger compaction when NUM_COMMITS or TIME_ELAPSED is satisfied
+  NUM_OR_TIME {
+    @Override
+    public boolean compactable(long compactInlineMaxDeltaCommits,
+                               long deltaCommitsSinceLastCompaction,
+                               long compactInlineMaxDeltaSeconds,
+                               long deltaSecondsSinceLastCompaction) {
+      boolean compactable = compactInlineMaxDeltaCommits <= deltaCommitsSinceLastCompaction
+          || compactInlineMaxDeltaSeconds <= deltaSecondsSinceLastCompaction;
+      if (compactable) {
+        LOG.info(String.format("The delta commits >= %s and elapsed_time >=%ss, trigger compaction scheduler.",
+            compactInlineMaxDeltaCommits, compactInlineMaxDeltaSeconds));
+      }
+      return compactable;
+    }
+  };
+
+  /**
+   * Judge if the strategy  could fire based on the condition.
+   *

Review comment:
       `strategy  could` => `strategy could`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] RocMarshal commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-968271847


   @xushiyan @yanghua @leesf .
   Excuse me.I looked into this CI failure case in the backgroud of this pr. There are some interesting appearance in test cases , such as `TestHoodieSparkMergeOnReadTableInsertUpdateDelete`, etc. 
   
   `      
         String newCommitTime = "001"; // ---------------(1)
         client.startCommitWithTime(newCommitTime);
         List<HoodieRecord> records = dataGen.generateInserts(newCommitTime, 200);
         insertRecords(metaClient, records, client, cfg, newCommitTime);
   `
   
   The new `CompactionTriggerStrategy` will use commit instant time parameters and use delta commit info parameters to judge the state. 
   When the variable "001" tagged with `(1)` was transported into `HoodieInstantTimeGenerator#parseInstantTime(String timestamp)` , the `newCommitTime` value was not compatible with the parse pattern `yyyyMMddHHmmss` declared in `HoodieInstantTimeGenerator#INSTANT_TIME_FORMATTER`. At the same time, the compact configuration item was set as 'NUM_COMMITS' . As a result of the setting, the old `CompactionTriggerStrategy` would judge the state without instantTime parameters. The new `CompactionTriggerStrategy` will use both instantTime and commitNumber parameters to judge the state  on the contrary, which is the reason why the old  `CompactionTriggerStrategy` could be successful but new `CompactionTriggerStrategy` would be unsuccessful. With my limited read, we could enhance the validation of commitTime `(1)` in the target format `yyyyMMddHHmmss` or stop the refactor in the pr. 
   
   Please let me know what's your opinion.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-972510246


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453",
       "triggerID" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 08173246c29fda1c9880f5ad897cf61423523e1a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] RocMarshal commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-970178412


   @yanghua Thanks so much for your suggestions, which appears to have a good result on checking check the Azure CI. 
   Thanks again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-976191892


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453",
       "triggerID" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617",
       "triggerID" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622",
       "triggerID" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3628",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 32af53f7ed580024923128fa63a9dcd2adbf2b56 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617) 
   * fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3628) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-998478837


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453",
       "triggerID" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617",
       "triggerID" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622",
       "triggerID" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3628",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "f05b7dc67c6fb1d6b9bf75fac0c37b42925bfa23",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4621",
       "triggerID" : "f05b7dc67c6fb1d6b9bf75fac0c37b42925bfa23",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f05b7dc67c6fb1d6b9bf75fac0c37b42925bfa23 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4621) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-998444121


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453",
       "triggerID" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617",
       "triggerID" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622",
       "triggerID" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3628",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "f05b7dc67c6fb1d6b9bf75fac0c37b42925bfa23",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f05b7dc67c6fb1d6b9bf75fac0c37b42925bfa23",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3628) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622) 
   * f05b7dc67c6fb1d6b9bf75fac0c37b42925bfa23 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] RocMarshal edited a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
RocMarshal edited a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-970178412






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yanghua commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-970199377


   > @yanghua Thanks so much for your suggestions, which has a good result for my checking the Azure CI. Thanks again.
   
   You are welcome, I will have a final check soon. Since you have refactored code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-961588588


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-971409041


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d28da05aad1955161c37ee0800b8e89ed08ff1b5 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404) 
   * 9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-944948402


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c7fe591872690c7c87881d5b470716260b93692c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920) 
   * 4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor XScheduleCompactionActionExecutor and CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-944948402


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d9ce212502533fde85a832c13622738c5c9e97af Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683) 
   * e60d1b23a6a3627556df3edb014a41ca71cc122d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] RocMarshal edited a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
RocMarshal edited a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-950336344


   > @RocMarshal Thanks for your contribution. Can you describe if there is any test case to verify your changes?
   
   Hi, @yanghua Thanks for reminding. it's already covered in org.apache.hudi.table.action.compact.TestInlineCompaction


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-998444121


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453",
       "triggerID" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617",
       "triggerID" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622",
       "triggerID" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3628",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "f05b7dc67c6fb1d6b9bf75fac0c37b42925bfa23",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f05b7dc67c6fb1d6b9bf75fac0c37b42925bfa23",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3628) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622) 
   * f05b7dc67c6fb1d6b9bf75fac0c37b42925bfa23 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-976141950


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453",
       "triggerID" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617",
       "triggerID" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 08173246c29fda1c9880f5ad897cf61423523e1a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453) 
   * 32af53f7ed580024923128fa63a9dcd2adbf2b56 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617) 
   * fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-976164451


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453",
       "triggerID" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617",
       "triggerID" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622",
       "triggerID" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 32af53f7ed580024923128fa63a9dcd2adbf2b56 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617) 
   * fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] RocMarshal commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-976249155


   cc @leesf 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] RocMarshal commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-982832067


   Excuse me, @xushiyan Shall we close the PR ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-972475571


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453",
       "triggerID" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437) 
   * 08173246c29fda1c9880f5ad897cf61423523e1a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-976142646


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453",
       "triggerID" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617",
       "triggerID" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 32af53f7ed580024923128fa63a9dcd2adbf2b56 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617) 
   * fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-972510246


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453",
       "triggerID" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 08173246c29fda1c9880f5ad897cf61423523e1a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] RocMarshal commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-976191473


   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-971409041


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d28da05aad1955161c37ee0800b8e89ed08ff1b5 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404) 
   * 9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yanghua commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-972569536


   @danny0405 Double check?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-976231160


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453",
       "triggerID" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617",
       "triggerID" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622",
       "triggerID" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3628",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3628) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor XScheduleCompactionActionExecutor and CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-944948402


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d9ce212502533fde85a832c13622738c5c9e97af Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683) 
   * e60d1b23a6a3627556df3edb014a41ca71cc122d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-944948402


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c7fe591872690c7c87881d5b470716260b93692c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920) 
   * 4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-944948402


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e60d1b23a6a3627556df3edb014a41ca71cc122d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698) 
   * 822dbe03dc77531858ffd83ebeb91f210f4e7851 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-944948402


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 822dbe03dc77531858ffd83ebeb91f210f4e7851 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818) 
   * 7a7ee072ae225fe015b73545ac8d50acc5746ea7 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor XScheduleCompactionActionExecutor and CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-944948402






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-971521945


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-976141950


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453",
       "triggerID" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617",
       "triggerID" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 08173246c29fda1c9880f5ad897cf61423523e1a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453) 
   * 32af53f7ed580024923128fa63a9dcd2adbf2b56 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617) 
   * fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-998444978


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453",
       "triggerID" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617",
       "triggerID" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622",
       "triggerID" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3628",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "f05b7dc67c6fb1d6b9bf75fac0c37b42925bfa23",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4621",
       "triggerID" : "f05b7dc67c6fb1d6b9bf75fac0c37b42925bfa23",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3628) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622) 
   * f05b7dc67c6fb1d6b9bf75fac0c37b42925bfa23 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4621) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-969785112


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924) 
   * 2afbd368d00403fda5056e0e8795f18ee4582768 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-971411406


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d28da05aad1955161c37ee0800b8e89ed08ff1b5 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404) 
   * 9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-944948402


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e60d1b23a6a3627556df3edb014a41ca71cc122d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698) 
   * 822dbe03dc77531858ffd83ebeb91f210f4e7851 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-944948402


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 822dbe03dc77531858ffd83ebeb91f210f4e7851 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818) 
   * 7a7ee072ae225fe015b73545ac8d50acc5746ea7 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-944948402


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7a7ee072ae225fe015b73545ac8d50acc5746ea7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan commented on a change in pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#discussion_r775695199



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/CompactionTriggerStrategy.java
##########
@@ -18,13 +18,112 @@
 
 package org.apache.hudi.table.action.compact;
 
+import java.text.ParseException;
+import org.apache.hudi.common.table.timeline.HoodieActiveTimeline;
+import org.apache.hudi.common.util.collection.Pair;
+import org.apache.hudi.config.HoodieWriteConfig;
+import org.apache.hudi.exception.HoodieCompactionException;
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+
+@SuppressWarnings("checkstyle:LineLength")
 public enum CompactionTriggerStrategy {
-    // trigger compaction when reach N delta commits
-    NUM_COMMITS,
-    // trigger compaction when time elapsed > N seconds since last compaction
-    TIME_ELAPSED,
-    // trigger compaction when both NUM_COMMITS and TIME_ELAPSED are satisfied
-    NUM_AND_TIME,
-    // trigger compaction when NUM_COMMITS or TIME_ELAPSED is satisfied
-    NUM_OR_TIME
+
+  // trigger compaction when reach N delta commits
+  NUM_COMMITS {
+    @Override
+    public boolean isCompactable(
+        HoodieWriteConfig config,

Review comment:
       this class is only about compaction so you don't need to pass the whole write config. would just Compaction config give you all the config needed? 

##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/ScheduleCompactionActionExecutor.java
##########
@@ -146,53 +144,14 @@ private HoodieCompactionPlan scheduleCompaction() {
   }
 
   private boolean needCompact(CompactionTriggerStrategy compactionTriggerStrategy) {
-    boolean compactable;
+
+    if (compactionTriggerStrategy == null) {
+      throw new HoodieCompactionException("Unsupported compaction trigger strategy: {}"
+          + config.getInlineCompactTriggerStrategy());
+    }

Review comment:
       don't think this check is needed.. we always expect non-null arg to be passed in. 
   
   Also `compactionTriggerStrategy` being null does not make sense with "Unsupported compaction trigger strategy"; it's simply being misused with null argument.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-969797527


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2afbd368d00403fda5056e0e8795f18ee4582768 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400) 
   * d28da05aad1955161c37ee0800b8e89ed08ff1b5 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-969785112


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924) 
   * 2afbd368d00403fda5056e0e8795f18ee4582768 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-969847717


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2afbd368d00403fda5056e0e8795f18ee4582768 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400) 
   * d28da05aad1955161c37ee0800b8e89ed08ff1b5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] RocMarshal commented on a change in pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on a change in pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#discussion_r750877073



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/CompactionTriggerStrategy.java
##########
@@ -18,13 +18,114 @@
 
 package org.apache.hudi.table.action.compact;
 
+import java.text.ParseException;
+import org.apache.hudi.common.table.timeline.HoodieActiveTimeline;
+import org.apache.hudi.common.util.collection.Pair;
+import org.apache.hudi.exception.HoodieCompactionException;
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+
+@SuppressWarnings("checkstyle:LineLength")
 public enum CompactionTriggerStrategy {
-    // trigger compaction when reach N delta commits
-    NUM_COMMITS,
-    // trigger compaction when time elapsed > N seconds since last compaction
-    TIME_ELAPSED,
-    // trigger compaction when both NUM_COMMITS and TIME_ELAPSED are satisfied
-    NUM_AND_TIME,
-    // trigger compaction when NUM_COMMITS or TIME_ELAPSED is satisfied
-    NUM_OR_TIME
+
+  // trigger compaction when reach N delta commits
+  NUM_COMMITS {
+    @Override
+    public boolean compactable(
+        long compactInlineMaxDeltaCommits,
+        long compactInlineMaxDeltaSeconds,
+        Pair<Integer, String> latestDeltaCommitInfo,
+        String instantTime) {
+
+      boolean compactable = compactInlineMaxDeltaCommits <= latestDeltaCommitInfo.getLeft();
+      if (compactable) {
+        LOG.info(String.format("The delta commits >= %s, trigger compaction scheduler.", compactInlineMaxDeltaCommits));
+      }
+      return compactable;
+    }
+  },
+  // trigger compaction when time elapsed > N seconds since last compaction
+  TIME_ELAPSED {
+    @Override
+    public boolean compactable(
+        long compactInlineMaxDeltaCommits,
+        long compactInlineMaxDeltaSeconds,
+        Pair<Integer, String> latestDeltaCommitInfo,
+        String instantTime) {
+
+      boolean compactable = compactInlineMaxDeltaSeconds
+          <= (parsedToSeconds(instantTime) - parsedToSeconds(latestDeltaCommitInfo.getRight()));

Review comment:
       It's a good idea that putting (parsedToSeconds(instantTime) - parsedToSeconds(latestDeltaCommitInfo.getRight()) into a variable . Thanks @yanghua for the suggestion.
   
   [ERROR] src/main/java/org/apache/hudi/table/action/compact/CompactionTriggerStrategy.java:[56,58] (whitespace) OperatorWrap: '<=' 应另起一行。
   [ERROR] src/main/java/org/apache/hudi/table/action/compact/CompactionTriggerStrategy.java:[73,93] (whitespace) OperatorWrap: '&&' 应另起一行。
   [ERROR] src/main/java/org/apache/hudi/table/action/compact/CompactionTriggerStrategy.java:[74,40] (whitespace) OperatorWrap: '<=' 应另起一行。
   [ERROR] src/main/java/org/apache/hudi/table/action/compact/CompactionTriggerStrategy.java:[92,93] (whitespace) OperatorWrap: '||' 应另起一行。
   [ERROR] src/main/java/org/apache/hudi/table/action/compact/CompactionTriggerStrategy.java:[93,40] (whitespace) OperatorWrap: '<=' 应另起一行。
   
   It's the hint message when the '<=' position was at the line end. Should we find other drafts to resolve the case ?   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-972474159


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437) 
   * 08173246c29fda1c9880f5ad897cf61423523e1a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-971649641


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] RocMarshal removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
RocMarshal removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-971482574


   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-972474159


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437) 
   * 08173246c29fda1c9880f5ad897cf61423523e1a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-976141256


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453",
       "triggerID" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 08173246c29fda1c9880f5ad897cf61423523e1a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453) 
   * 32af53f7ed580024923128fa63a9dcd2adbf2b56 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-976192862


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453",
       "triggerID" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617",
       "triggerID" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622",
       "triggerID" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3628",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3628) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-976231160


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453",
       "triggerID" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617",
       "triggerID" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622",
       "triggerID" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3628",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3628) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor XScheduleCompactionActionExecutor and CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-944948402


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d9ce212502533fde85a832c13622738c5c9e97af UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yanghua commented on pull request #3813: [HUDI-2563][hudi-client] Refactor XScheduleCompactionActionExecutor and CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-946827638


   @RocMarshal Thanks for your contribution. Can you describe if there is any test case to verify your changes?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-971707039


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-971484714


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yanghua commented on a change in pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#discussion_r750834212



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/CompactionTriggerStrategy.java
##########
@@ -18,13 +18,114 @@
 
 package org.apache.hudi.table.action.compact;
 
+import java.text.ParseException;
+import org.apache.hudi.common.table.timeline.HoodieActiveTimeline;
+import org.apache.hudi.common.util.collection.Pair;
+import org.apache.hudi.exception.HoodieCompactionException;
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+
+@SuppressWarnings("checkstyle:LineLength")
 public enum CompactionTriggerStrategy {
-    // trigger compaction when reach N delta commits
-    NUM_COMMITS,
-    // trigger compaction when time elapsed > N seconds since last compaction
-    TIME_ELAPSED,
-    // trigger compaction when both NUM_COMMITS and TIME_ELAPSED are satisfied
-    NUM_AND_TIME,
-    // trigger compaction when NUM_COMMITS or TIME_ELAPSED is satisfied
-    NUM_OR_TIME
+
+  // trigger compaction when reach N delta commits
+  NUM_COMMITS {
+    @Override
+    public boolean compactable(
+        long compactInlineMaxDeltaCommits,
+        long compactInlineMaxDeltaSeconds,
+        Pair<Integer, String> latestDeltaCommitInfo,
+        String instantTime) {
+
+      boolean compactable = compactInlineMaxDeltaCommits <= latestDeltaCommitInfo.getLeft();
+      if (compactable) {
+        LOG.info(String.format("The delta commits >= %s, trigger compaction scheduler.", compactInlineMaxDeltaCommits));
+      }
+      return compactable;
+    }
+  },
+  // trigger compaction when time elapsed > N seconds since last compaction
+  TIME_ELAPSED {
+    @Override
+    public boolean compactable(
+        long compactInlineMaxDeltaCommits,
+        long compactInlineMaxDeltaSeconds,
+        Pair<Integer, String> latestDeltaCommitInfo,
+        String instantTime) {
+
+      boolean compactable = compactInlineMaxDeltaSeconds
+          <= (parsedToSeconds(instantTime) - parsedToSeconds(latestDeltaCommitInfo.getRight()));
+      if (compactable) {
+        LOG.info(String.format("The elapsed time >=%ss, trigger compaction scheduler.", compactInlineMaxDeltaSeconds));
+      }
+      return compactable;
+    }
+  },
+  // trigger compaction when both NUM_COMMITS and TIME_ELAPSED are satisfied
+  NUM_AND_TIME {
+    @Override
+    public boolean compactable(
+        long compactInlineMaxDeltaCommits,
+        long compactInlineMaxDeltaSeconds,
+        Pair<Integer, String> latestDeltaCommitInfo,
+        String instantTime) {
+
+      boolean compactable = compactInlineMaxDeltaCommits <= latestDeltaCommitInfo.getLeft()
+          && compactInlineMaxDeltaSeconds
+          <= (parsedToSeconds(instantTime) - parsedToSeconds(latestDeltaCommitInfo.getRight()));
+      if (compactable) {
+        LOG.info(String.format("The delta commits >= %s or elapsed_time >=%ss, trigger compaction scheduler.",
+            compactInlineMaxDeltaCommits, compactInlineMaxDeltaSeconds));
+      }
+      return compactable;
+    }
+  },
+  // trigger compaction when NUM_COMMITS or TIME_ELAPSED is satisfied
+  NUM_OR_TIME {
+    @Override
+    public boolean compactable(
+        long compactInlineMaxDeltaCommits,
+        long compactInlineMaxDeltaSeconds,
+        Pair<Integer, String> latestDeltaCommitInfo,
+        String instantTime) {
+
+      boolean compactable = compactInlineMaxDeltaCommits <= latestDeltaCommitInfo.getLeft()
+          || compactInlineMaxDeltaSeconds
+          <= (parsedToSeconds(instantTime) - parsedToSeconds(latestDeltaCommitInfo.getRight()));

Review comment:
       ditto

##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/CompactionTriggerStrategy.java
##########
@@ -18,13 +18,114 @@
 
 package org.apache.hudi.table.action.compact;
 
+import java.text.ParseException;
+import org.apache.hudi.common.table.timeline.HoodieActiveTimeline;
+import org.apache.hudi.common.util.collection.Pair;
+import org.apache.hudi.exception.HoodieCompactionException;
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+
+@SuppressWarnings("checkstyle:LineLength")
 public enum CompactionTriggerStrategy {
-    // trigger compaction when reach N delta commits
-    NUM_COMMITS,
-    // trigger compaction when time elapsed > N seconds since last compaction
-    TIME_ELAPSED,
-    // trigger compaction when both NUM_COMMITS and TIME_ELAPSED are satisfied
-    NUM_AND_TIME,
-    // trigger compaction when NUM_COMMITS or TIME_ELAPSED is satisfied
-    NUM_OR_TIME
+
+  // trigger compaction when reach N delta commits
+  NUM_COMMITS {
+    @Override
+    public boolean compactable(
+        long compactInlineMaxDeltaCommits,
+        long compactInlineMaxDeltaSeconds,
+        Pair<Integer, String> latestDeltaCommitInfo,
+        String instantTime) {
+
+      boolean compactable = compactInlineMaxDeltaCommits <= latestDeltaCommitInfo.getLeft();
+      if (compactable) {
+        LOG.info(String.format("The delta commits >= %s, trigger compaction scheduler.", compactInlineMaxDeltaCommits));
+      }
+      return compactable;
+    }
+  },
+  // trigger compaction when time elapsed > N seconds since last compaction
+  TIME_ELAPSED {
+    @Override
+    public boolean compactable(
+        long compactInlineMaxDeltaCommits,
+        long compactInlineMaxDeltaSeconds,
+        Pair<Integer, String> latestDeltaCommitInfo,
+        String instantTime) {
+
+      boolean compactable = compactInlineMaxDeltaSeconds
+          <= (parsedToSeconds(instantTime) - parsedToSeconds(latestDeltaCommitInfo.getRight()));

Review comment:
       this style is strange. can we do not start with `<=` and put `(parsedToSeconds(instantTime) - parsedToSeconds(latestDeltaCommitInfo.getRight())` into a variable?

##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/CompactionTriggerStrategy.java
##########
@@ -18,13 +18,114 @@
 
 package org.apache.hudi.table.action.compact;
 
+import java.text.ParseException;
+import org.apache.hudi.common.table.timeline.HoodieActiveTimeline;
+import org.apache.hudi.common.util.collection.Pair;
+import org.apache.hudi.exception.HoodieCompactionException;
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+
+@SuppressWarnings("checkstyle:LineLength")
 public enum CompactionTriggerStrategy {
-    // trigger compaction when reach N delta commits
-    NUM_COMMITS,
-    // trigger compaction when time elapsed > N seconds since last compaction
-    TIME_ELAPSED,
-    // trigger compaction when both NUM_COMMITS and TIME_ELAPSED are satisfied
-    NUM_AND_TIME,
-    // trigger compaction when NUM_COMMITS or TIME_ELAPSED is satisfied
-    NUM_OR_TIME
+
+  // trigger compaction when reach N delta commits
+  NUM_COMMITS {
+    @Override
+    public boolean compactable(
+        long compactInlineMaxDeltaCommits,
+        long compactInlineMaxDeltaSeconds,
+        Pair<Integer, String> latestDeltaCommitInfo,
+        String instantTime) {
+
+      boolean compactable = compactInlineMaxDeltaCommits <= latestDeltaCommitInfo.getLeft();
+      if (compactable) {
+        LOG.info(String.format("The delta commits >= %s, trigger compaction scheduler.", compactInlineMaxDeltaCommits));
+      }
+      return compactable;
+    }
+  },
+  // trigger compaction when time elapsed > N seconds since last compaction
+  TIME_ELAPSED {
+    @Override
+    public boolean compactable(
+        long compactInlineMaxDeltaCommits,
+        long compactInlineMaxDeltaSeconds,
+        Pair<Integer, String> latestDeltaCommitInfo,
+        String instantTime) {
+
+      boolean compactable = compactInlineMaxDeltaSeconds
+          <= (parsedToSeconds(instantTime) - parsedToSeconds(latestDeltaCommitInfo.getRight()));
+      if (compactable) {
+        LOG.info(String.format("The elapsed time >=%ss, trigger compaction scheduler.", compactInlineMaxDeltaSeconds));
+      }
+      return compactable;
+    }
+  },
+  // trigger compaction when both NUM_COMMITS and TIME_ELAPSED are satisfied
+  NUM_AND_TIME {
+    @Override
+    public boolean compactable(
+        long compactInlineMaxDeltaCommits,
+        long compactInlineMaxDeltaSeconds,
+        Pair<Integer, String> latestDeltaCommitInfo,
+        String instantTime) {
+
+      boolean compactable = compactInlineMaxDeltaCommits <= latestDeltaCommitInfo.getLeft()
+          && compactInlineMaxDeltaSeconds
+          <= (parsedToSeconds(instantTime) - parsedToSeconds(latestDeltaCommitInfo.getRight()));

Review comment:
       ditto




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-969789717


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924) 
   * 2afbd368d00403fda5056e0e8795f18ee4582768 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400) 
   * d28da05aad1955161c37ee0800b8e89ed08ff1b5 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-971521945


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-971411406


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d28da05aad1955161c37ee0800b8e89ed08ff1b5 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404) 
   * 9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-971469882


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-944948402


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-944948402


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7a7ee072ae225fe015b73545ac8d50acc5746ea7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822) 
   * c7fe591872690c7c87881d5b470716260b93692c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] RocMarshal commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-950336344


   > @RocMarshal Thanks for your contribution. Can you describe if there is any test case to verify your changes?
   
   it's lready covered in org.apache.hudi.table.action.compact.TestInlineCompaction


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-961588588


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-944948402


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor XScheduleCompactionActionExecutor and CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-944948402


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e60d1b23a6a3627556df3edb014a41ca71cc122d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-998444978


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453",
       "triggerID" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617",
       "triggerID" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622",
       "triggerID" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3628",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "f05b7dc67c6fb1d6b9bf75fac0c37b42925bfa23",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4621",
       "triggerID" : "f05b7dc67c6fb1d6b9bf75fac0c37b42925bfa23",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3628) Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622) 
   * f05b7dc67c6fb1d6b9bf75fac0c37b42925bfa23 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4621) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] RocMarshal removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
RocMarshal removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-976249155


   cc @leesf 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] RocMarshal commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-971646258


   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-971707039


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-971469882


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-971484714


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-969789717


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924) 
   * 2afbd368d00403fda5056e0e8795f18ee4582768 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400) 
   * d28da05aad1955161c37ee0800b8e89ed08ff1b5 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-969847717


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2afbd368d00403fda5056e0e8795f18ee4582768 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400) 
   * d28da05aad1955161c37ee0800b8e89ed08ff1b5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] vinothchandar commented on a change in pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#discussion_r772775398



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/ScheduleCompactionActionExecutor.java
##########
@@ -141,53 +139,16 @@ private HoodieCompactionPlan scheduleCompaction() {
   }
 
   private boolean needCompact(CompactionTriggerStrategy compactionTriggerStrategy) {
-    boolean compactable;
+
+    if (compactionTriggerStrategy == null) {
+      throw new HoodieCompactionException("Unsupported compaction trigger strategy: {}"
+          + config.getInlineCompactTriggerStrategy());
+    }
     // get deltaCommitsSinceLastCompaction and lastCompactionTs
     Pair<Integer, String> latestDeltaCommitInfo = getLatestDeltaCommitInfo();
     int inlineCompactDeltaCommitMax = config.getInlineCompactDeltaCommitMax();
     int inlineCompactDeltaSecondsMax = config.getInlineCompactDeltaSecondsMax();
-    switch (compactionTriggerStrategy) {
-      case NUM_COMMITS:
-        compactable = inlineCompactDeltaCommitMax <= latestDeltaCommitInfo.getLeft();
-        if (compactable) {
-          LOG.info(String.format("The delta commits >= %s, trigger compaction scheduler.", inlineCompactDeltaCommitMax));
-        }
-        break;
-      case TIME_ELAPSED:
-        compactable = inlineCompactDeltaSecondsMax <= parsedToSeconds(instantTime) - parsedToSeconds(latestDeltaCommitInfo.getRight());
-        if (compactable) {
-          LOG.info(String.format("The elapsed time >=%ss, trigger compaction scheduler.", inlineCompactDeltaSecondsMax));
-        }
-        break;
-      case NUM_OR_TIME:
-        compactable = inlineCompactDeltaCommitMax <= latestDeltaCommitInfo.getLeft()
-            || inlineCompactDeltaSecondsMax <= parsedToSeconds(instantTime) - parsedToSeconds(latestDeltaCommitInfo.getRight());
-        if (compactable) {
-          LOG.info(String.format("The delta commits >= %s or elapsed_time >=%ss, trigger compaction scheduler.", inlineCompactDeltaCommitMax,
-              inlineCompactDeltaSecondsMax));
-        }
-        break;
-      case NUM_AND_TIME:
-        compactable = inlineCompactDeltaCommitMax <= latestDeltaCommitInfo.getLeft()
-            && inlineCompactDeltaSecondsMax <= parsedToSeconds(instantTime) - parsedToSeconds(latestDeltaCommitInfo.getRight());
-        if (compactable) {
-          LOG.info(String.format("The delta commits >= %s and elapsed_time >=%ss, trigger compaction scheduler.", inlineCompactDeltaCommitMax,
-              inlineCompactDeltaSecondsMax));
-        }
-        break;
-      default:
-        throw new HoodieCompactionException("Unsupported compaction trigger strategy: " + config.getInlineCompactTriggerStrategy());
-    }
-    return compactable;
-  }
-
-  private Long parsedToSeconds(String time) {
-    long timestamp;
-    try {
-      timestamp = HoodieActiveTimeline.parseDateFromInstantTime(time).getTime() / 1000;
-    } catch (ParseException e) {
-      throw new HoodieCompactionException(e.getMessage(), e);
-    }
-    return timestamp;
+    return compactionTriggerStrategy

Review comment:
       rename: isCompactable() to be consistent with how we name booleans?

##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/CompactionTriggerStrategy.java
##########
@@ -18,13 +18,116 @@
 
 package org.apache.hudi.table.action.compact;
 
+import java.text.ParseException;
+import org.apache.hudi.common.table.timeline.HoodieActiveTimeline;
+import org.apache.hudi.common.util.collection.Pair;
+import org.apache.hudi.exception.HoodieCompactionException;
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+
+@SuppressWarnings("checkstyle:LineLength")
 public enum CompactionTriggerStrategy {
-    // trigger compaction when reach N delta commits
-    NUM_COMMITS,
-    // trigger compaction when time elapsed > N seconds since last compaction
-    TIME_ELAPSED,
-    // trigger compaction when both NUM_COMMITS and TIME_ELAPSED are satisfied
-    NUM_AND_TIME,
-    // trigger compaction when NUM_COMMITS or TIME_ELAPSED is satisfied
-    NUM_OR_TIME
+
+  // trigger compaction when reach N delta commits
+  NUM_COMMITS {
+    @Override
+    public boolean compactable(
+        long compactInlineMaxDeltaCommits,

Review comment:
       can we wrap these around, without placing them on each line, consistent with most of our code?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-944948402


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7a7ee072ae225fe015b73545ac8d50acc5746ea7 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822) 
   * c7fe591872690c7c87881d5b470716260b93692c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] RocMarshal commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-953446456


   > @RocMarshal Please check the Azure CI.
   
   Thanks @yanghua for the review. And Thanks  @nsivabalan for looking into this.
   I'll check the Azure CI ASAP.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-944948402


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c7fe591872690c7c87881d5b470716260b93692c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-976141256


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453",
       "triggerID" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 08173246c29fda1c9880f5ad897cf61423523e1a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453) 
   * 32af53f7ed580024923128fa63a9dcd2adbf2b56 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-976191892


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453",
       "triggerID" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617",
       "triggerID" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622",
       "triggerID" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3628",
       "triggerID" : "976191473",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 32af53f7ed580024923128fa63a9dcd2adbf2b56 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617) 
   * fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3622) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3628) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-944948402


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-961588588


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-961588588


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-976142646


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3453",
       "triggerID" : "08173246c29fda1c9880f5ad897cf61423523e1a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617",
       "triggerID" : "32af53f7ed580024923128fa63a9dcd2adbf2b56",
       "triggerType" : "PUSH"
     }, {
       "hash" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 32af53f7ed580024923128fa63a9dcd2adbf2b56 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3617) 
   * fb97a5759a60ffa76ae776ed1c53f9c33f8eb81b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-971649641


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431",
       "triggerID" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434",
       "triggerID" : "971482574",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437",
       "triggerID" : "971646258",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 9c1e75f71938f6c57104cf80d5bc5ce010f6fdb3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3431) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3434) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3437) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] RocMarshal commented on a change in pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on a change in pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#discussion_r772792723



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/ScheduleCompactionActionExecutor.java
##########
@@ -141,53 +139,16 @@ private HoodieCompactionPlan scheduleCompaction() {
   }
 
   private boolean needCompact(CompactionTriggerStrategy compactionTriggerStrategy) {
-    boolean compactable;
+
+    if (compactionTriggerStrategy == null) {
+      throw new HoodieCompactionException("Unsupported compaction trigger strategy: {}"
+          + config.getInlineCompactTriggerStrategy());
+    }
     // get deltaCommitsSinceLastCompaction and lastCompactionTs
     Pair<Integer, String> latestDeltaCommitInfo = getLatestDeltaCommitInfo();
     int inlineCompactDeltaCommitMax = config.getInlineCompactDeltaCommitMax();
     int inlineCompactDeltaSecondsMax = config.getInlineCompactDeltaSecondsMax();
-    switch (compactionTriggerStrategy) {
-      case NUM_COMMITS:
-        compactable = inlineCompactDeltaCommitMax <= latestDeltaCommitInfo.getLeft();
-        if (compactable) {
-          LOG.info(String.format("The delta commits >= %s, trigger compaction scheduler.", inlineCompactDeltaCommitMax));
-        }
-        break;
-      case TIME_ELAPSED:
-        compactable = inlineCompactDeltaSecondsMax <= parsedToSeconds(instantTime) - parsedToSeconds(latestDeltaCommitInfo.getRight());
-        if (compactable) {
-          LOG.info(String.format("The elapsed time >=%ss, trigger compaction scheduler.", inlineCompactDeltaSecondsMax));
-        }
-        break;
-      case NUM_OR_TIME:
-        compactable = inlineCompactDeltaCommitMax <= latestDeltaCommitInfo.getLeft()
-            || inlineCompactDeltaSecondsMax <= parsedToSeconds(instantTime) - parsedToSeconds(latestDeltaCommitInfo.getRight());
-        if (compactable) {
-          LOG.info(String.format("The delta commits >= %s or elapsed_time >=%ss, trigger compaction scheduler.", inlineCompactDeltaCommitMax,
-              inlineCompactDeltaSecondsMax));
-        }
-        break;
-      case NUM_AND_TIME:
-        compactable = inlineCompactDeltaCommitMax <= latestDeltaCommitInfo.getLeft()
-            && inlineCompactDeltaSecondsMax <= parsedToSeconds(instantTime) - parsedToSeconds(latestDeltaCommitInfo.getRight());
-        if (compactable) {
-          LOG.info(String.format("The delta commits >= %s and elapsed_time >=%ss, trigger compaction scheduler.", inlineCompactDeltaCommitMax,
-              inlineCompactDeltaSecondsMax));
-        }
-        break;
-      default:
-        throw new HoodieCompactionException("Unsupported compaction trigger strategy: " + config.getInlineCompactTriggerStrategy());
-    }
-    return compactable;
-  }
-
-  private Long parsedToSeconds(String time) {
-    long timestamp;
-    try {
-      timestamp = HoodieActiveTimeline.parseDateFromInstantTime(time).getTime() / 1000;
-    } catch (ParseException e) {
-      throw new HoodieCompactionException(e.getMessage(), e);
-    }
-    return timestamp;
+    return compactionTriggerStrategy

Review comment:
       Good idea.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] RocMarshal commented on a change in pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on a change in pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#discussion_r738023840



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/CompactionTriggerStrategy.java
##########
@@ -18,13 +18,87 @@
 
 package org.apache.hudi.table.action.compact;
 
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+
+@SuppressWarnings("checkstyle:LineLength")
 public enum CompactionTriggerStrategy {
-    // trigger compaction when reach N delta commits
-    NUM_COMMITS,
-    // trigger compaction when time elapsed > N seconds since last compaction
-    TIME_ELAPSED,
-    // trigger compaction when both NUM_COMMITS and TIME_ELAPSED are satisfied
-    NUM_AND_TIME,
-    // trigger compaction when NUM_COMMITS or TIME_ELAPSED is satisfied
-    NUM_OR_TIME
+
+  // trigger compaction when reach N delta commits
+  NUM_COMMITS {
+    @Override
+    public boolean compactable(long compactInlineMaxDeltaCommits,
+                               long deltaCommitsSinceLastCompaction,
+                               long compactInlineMaxDeltaSeconds,
+                               long deltaSecondsSinceLastCompaction) {
+      boolean compactable = compactInlineMaxDeltaCommits <= deltaCommitsSinceLastCompaction;
+      if (compactable) {
+        LOG.info(String.format("The delta commits >= %s, trigger compaction scheduler.", compactInlineMaxDeltaCommits));
+      }
+      return compactable;
+    }
+  },
+  // trigger compaction when time elapsed > N seconds since last compaction
+  TIME_ELAPSED {
+    @Override
+    public boolean compactable(long compactInlineMaxDeltaCommits,
+                               long deltaCommitsSinceLastCompaction,
+                               long compactInlineMaxDeltaSeconds,
+                               long deltaSecondsSinceLastCompaction) {
+      boolean compactable = compactInlineMaxDeltaSeconds <= deltaSecondsSinceLastCompaction;
+      if (compactable) {
+        LOG.info(String.format("The elapsed time >=%ss, trigger compaction scheduler.", compactInlineMaxDeltaSeconds));
+      }
+      return compactable;
+    }
+  },
+  // trigger compaction when both NUM_COMMITS and TIME_ELAPSED are satisfied
+  NUM_AND_TIME {
+    @Override
+    public boolean compactable(long compactInlineMaxDeltaCommits,
+                               long deltaCommitsSinceLastCompaction,
+                               long compactInlineMaxDeltaSeconds,
+                               long deltaSecondsSinceLastCompaction) {
+      boolean compactable = compactInlineMaxDeltaCommits <= deltaCommitsSinceLastCompaction
+          && compactInlineMaxDeltaSeconds <= deltaSecondsSinceLastCompaction;
+      if (compactable) {
+        LOG.info(String.format("The delta commits >= %s or elapsed_time >=%ss, trigger compaction scheduler.",
+            compactInlineMaxDeltaCommits, compactInlineMaxDeltaSeconds));
+      }
+      return compactable;
+    }
+  },
+  // trigger compaction when NUM_COMMITS or TIME_ELAPSED is satisfied
+  NUM_OR_TIME {
+    @Override
+    public boolean compactable(long compactInlineMaxDeltaCommits,
+                               long deltaCommitsSinceLastCompaction,
+                               long compactInlineMaxDeltaSeconds,
+                               long deltaSecondsSinceLastCompaction) {
+      boolean compactable = compactInlineMaxDeltaCommits <= deltaCommitsSinceLastCompaction
+          || compactInlineMaxDeltaSeconds <= deltaSecondsSinceLastCompaction;
+      if (compactable) {
+        LOG.info(String.format("The delta commits >= %s and elapsed_time >=%ss, trigger compaction scheduler.",
+            compactInlineMaxDeltaCommits, compactInlineMaxDeltaSeconds));
+      }
+      return compactable;
+    }
+  };
+
+  /**
+   * Judge if the strategy  could fire based on the condition.
+   *

Review comment:
       done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] RocMarshal commented on a change in pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on a change in pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#discussion_r738024300



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/CompactionTriggerStrategy.java
##########
@@ -18,13 +18,87 @@
 
 package org.apache.hudi.table.action.compact;
 
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+
+@SuppressWarnings("checkstyle:LineLength")
 public enum CompactionTriggerStrategy {
-    // trigger compaction when reach N delta commits
-    NUM_COMMITS,
-    // trigger compaction when time elapsed > N seconds since last compaction
-    TIME_ELAPSED,
-    // trigger compaction when both NUM_COMMITS and TIME_ELAPSED are satisfied
-    NUM_AND_TIME,
-    // trigger compaction when NUM_COMMITS or TIME_ELAPSED is satisfied
-    NUM_OR_TIME
+
+  // trigger compaction when reach N delta commits
+  NUM_COMMITS {
+    @Override
+    public boolean compactable(long compactInlineMaxDeltaCommits,
+                               long deltaCommitsSinceLastCompaction,
+                               long compactInlineMaxDeltaSeconds,
+                               long deltaSecondsSinceLastCompaction) {
+      boolean compactable = compactInlineMaxDeltaCommits <= deltaCommitsSinceLastCompaction;
+      if (compactable) {
+        LOG.info(String.format("The delta commits >= %s, trigger compaction scheduler.", compactInlineMaxDeltaCommits));
+      }
+      return compactable;
+    }
+  },
+  // trigger compaction when time elapsed > N seconds since last compaction
+  TIME_ELAPSED {
+    @Override
+    public boolean compactable(long compactInlineMaxDeltaCommits,
+                               long deltaCommitsSinceLastCompaction,
+                               long compactInlineMaxDeltaSeconds,
+                               long deltaSecondsSinceLastCompaction) {
+      boolean compactable = compactInlineMaxDeltaSeconds <= deltaSecondsSinceLastCompaction;
+      if (compactable) {
+        LOG.info(String.format("The elapsed time >=%ss, trigger compaction scheduler.", compactInlineMaxDeltaSeconds));
+      }
+      return compactable;
+    }
+  },
+  // trigger compaction when both NUM_COMMITS and TIME_ELAPSED are satisfied
+  NUM_AND_TIME {
+    @Override
+    public boolean compactable(long compactInlineMaxDeltaCommits,
+                               long deltaCommitsSinceLastCompaction,
+                               long compactInlineMaxDeltaSeconds,
+                               long deltaSecondsSinceLastCompaction) {
+      boolean compactable = compactInlineMaxDeltaCommits <= deltaCommitsSinceLastCompaction
+          && compactInlineMaxDeltaSeconds <= deltaSecondsSinceLastCompaction;
+      if (compactable) {
+        LOG.info(String.format("The delta commits >= %s or elapsed_time >=%ss, trigger compaction scheduler.",
+            compactInlineMaxDeltaCommits, compactInlineMaxDeltaSeconds));
+      }
+      return compactable;
+    }
+  },
+  // trigger compaction when NUM_COMMITS or TIME_ELAPSED is satisfied
+  NUM_OR_TIME {
+    @Override
+    public boolean compactable(long compactInlineMaxDeltaCommits,
+                               long deltaCommitsSinceLastCompaction,
+                               long compactInlineMaxDeltaSeconds,
+                               long deltaSecondsSinceLastCompaction) {
+      boolean compactable = compactInlineMaxDeltaCommits <= deltaCommitsSinceLastCompaction
+          || compactInlineMaxDeltaSeconds <= deltaSecondsSinceLastCompaction;
+      if (compactable) {
+        LOG.info(String.format("The delta commits >= %s and elapsed_time >=%ss, trigger compaction scheduler.",
+            compactInlineMaxDeltaCommits, compactInlineMaxDeltaSeconds));
+      }
+      return compactable;
+    }
+  };
+
+  /**
+   * Judge if the strategy  could fire based on the condition.
+   *
+   * @param compactInlineMaxDeltaCommits    {@link org.apache.hudi.config.HoodieCompactionConfig#INLINE_COMPACT_NUM_DELTA_COMMITS}
+   * @param deltaCommitsSinceLastCompaction value in the condition.
+   * @param compactInlineMaxDeltaSeconds    {@link org.apache.hudi.config.HoodieCompactionConfig#INLINE_COMPACT_TIME_DELTA_SECONDS}
+   * @param deltaSecondsSinceLastCompaction value in the condition.
+   * @return true if it could be triggered, false else.

Review comment:
       Thanks @danny0405  for the review . I updated it. Please let me know what do you think of it .




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-950963470


   @yihua : Feel free to review this. related to refactoring. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] RocMarshal commented on pull request #3813: [HUDI-2563][hudi-client] Refactor XScheduleCompactionActionExecutor and CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-945626073


   Could someone help me to review it ? Thank you very much.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] RocMarshal commented on a change in pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on a change in pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#discussion_r750877073



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/CompactionTriggerStrategy.java
##########
@@ -18,13 +18,114 @@
 
 package org.apache.hudi.table.action.compact;
 
+import java.text.ParseException;
+import org.apache.hudi.common.table.timeline.HoodieActiveTimeline;
+import org.apache.hudi.common.util.collection.Pair;
+import org.apache.hudi.exception.HoodieCompactionException;
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+
+@SuppressWarnings("checkstyle:LineLength")
 public enum CompactionTriggerStrategy {
-    // trigger compaction when reach N delta commits
-    NUM_COMMITS,
-    // trigger compaction when time elapsed > N seconds since last compaction
-    TIME_ELAPSED,
-    // trigger compaction when both NUM_COMMITS and TIME_ELAPSED are satisfied
-    NUM_AND_TIME,
-    // trigger compaction when NUM_COMMITS or TIME_ELAPSED is satisfied
-    NUM_OR_TIME
+
+  // trigger compaction when reach N delta commits
+  NUM_COMMITS {
+    @Override
+    public boolean compactable(
+        long compactInlineMaxDeltaCommits,
+        long compactInlineMaxDeltaSeconds,
+        Pair<Integer, String> latestDeltaCommitInfo,
+        String instantTime) {
+
+      boolean compactable = compactInlineMaxDeltaCommits <= latestDeltaCommitInfo.getLeft();
+      if (compactable) {
+        LOG.info(String.format("The delta commits >= %s, trigger compaction scheduler.", compactInlineMaxDeltaCommits));
+      }
+      return compactable;
+    }
+  },
+  // trigger compaction when time elapsed > N seconds since last compaction
+  TIME_ELAPSED {
+    @Override
+    public boolean compactable(
+        long compactInlineMaxDeltaCommits,
+        long compactInlineMaxDeltaSeconds,
+        Pair<Integer, String> latestDeltaCommitInfo,
+        String instantTime) {
+
+      boolean compactable = compactInlineMaxDeltaSeconds
+          <= (parsedToSeconds(instantTime) - parsedToSeconds(latestDeltaCommitInfo.getRight()));

Review comment:
       It's a good idea to putting (parsedToSeconds(instantTime) - parsedToSeconds(latestDeltaCommitInfo.getRight()) into a variable . Thanks @yanghua for the suggestion.
   
   [ERROR] src/main/java/org/apache/hudi/table/action/compact/CompactionTriggerStrategy.java:[56,58] (whitespace) OperatorWrap: '<=' 应另起一行。
   [ERROR] src/main/java/org/apache/hudi/table/action/compact/CompactionTriggerStrategy.java:[73,93] (whitespace) OperatorWrap: '&&' 应另起一行。
   [ERROR] src/main/java/org/apache/hudi/table/action/compact/CompactionTriggerStrategy.java:[74,40] (whitespace) OperatorWrap: '<=' 应另起一行。
   [ERROR] src/main/java/org/apache/hudi/table/action/compact/CompactionTriggerStrategy.java:[92,93] (whitespace) OperatorWrap: '||' 应另起一行。
   [ERROR] src/main/java/org/apache/hudi/table/action/compact/CompactionTriggerStrategy.java:[93,40] (whitespace) OperatorWrap: '<=' 应另起一行。
   
   It's the hint message when the '<=' position was at the line end. Should we find other drafts to resolve the case ?   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yanghua commented on a change in pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#discussion_r751001502



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/CompactionTriggerStrategy.java
##########
@@ -18,13 +18,114 @@
 
 package org.apache.hudi.table.action.compact;
 
+import java.text.ParseException;
+import org.apache.hudi.common.table.timeline.HoodieActiveTimeline;
+import org.apache.hudi.common.util.collection.Pair;
+import org.apache.hudi.exception.HoodieCompactionException;
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+
+@SuppressWarnings("checkstyle:LineLength")
 public enum CompactionTriggerStrategy {
-    // trigger compaction when reach N delta commits
-    NUM_COMMITS,
-    // trigger compaction when time elapsed > N seconds since last compaction
-    TIME_ELAPSED,
-    // trigger compaction when both NUM_COMMITS and TIME_ELAPSED are satisfied
-    NUM_AND_TIME,
-    // trigger compaction when NUM_COMMITS or TIME_ELAPSED is satisfied
-    NUM_OR_TIME
+
+  // trigger compaction when reach N delta commits
+  NUM_COMMITS {
+    @Override
+    public boolean compactable(
+        long compactInlineMaxDeltaCommits,
+        long compactInlineMaxDeltaSeconds,
+        Pair<Integer, String> latestDeltaCommitInfo,
+        String instantTime) {
+
+      boolean compactable = compactInlineMaxDeltaCommits <= latestDeltaCommitInfo.getLeft();
+      if (compactable) {
+        LOG.info(String.format("The delta commits >= %s, trigger compaction scheduler.", compactInlineMaxDeltaCommits));
+      }
+      return compactable;
+    }
+  },
+  // trigger compaction when time elapsed > N seconds since last compaction
+  TIME_ELAPSED {
+    @Override
+    public boolean compactable(
+        long compactInlineMaxDeltaCommits,
+        long compactInlineMaxDeltaSeconds,
+        Pair<Integer, String> latestDeltaCommitInfo,
+        String instantTime) {
+
+      boolean compactable = compactInlineMaxDeltaSeconds
+          <= (parsedToSeconds(instantTime) - parsedToSeconds(latestDeltaCommitInfo.getRight()));

Review comment:
       IMO, if you addressed this suggestion: `put (parsedToSeconds(instantTime) - parsedToSeconds(latestDeltaCommitInfo.getRight()) into a variable`, than we can avoid to start or end with compare operator(<=, >=), right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-969881218


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d28da05aad1955161c37ee0800b8e89ed08ff1b5 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] RocMarshal commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-971482574


   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-969881218


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2683",
       "triggerID" : "d9ce212502533fde85a832c13622738c5c9e97af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2698",
       "triggerID" : "e60d1b23a6a3627556df3edb014a41ca71cc122d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2818",
       "triggerID" : "822dbe03dc77531858ffd83ebeb91f210f4e7851",
       "triggerType" : "PUSH"
     }, {
       "hash" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2822",
       "triggerID" : "7a7ee072ae225fe015b73545ac8d50acc5746ea7",
       "triggerType" : "PUSH"
     }, {
       "hash" : "c7fe591872690c7c87881d5b470716260b93692c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2920",
       "triggerID" : "c7fe591872690c7c87881d5b470716260b93692c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2924",
       "triggerID" : "4afb1a587e0809c4d6d3106aa33e6cf1eda47f0e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3400",
       "triggerID" : "2afbd368d00403fda5056e0e8795f18ee4582768",
       "triggerType" : "PUSH"
     }, {
       "hash" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404",
       "triggerID" : "d28da05aad1955161c37ee0800b8e89ed08ff1b5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d28da05aad1955161c37ee0800b8e89ed08ff1b5 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3404) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] RocMarshal edited a comment on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
RocMarshal edited a comment on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-970178412


   @yanghua Thanks so much for your suggestions, which has a good result for my checking the Azure CI. 
   Thanks again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] RocMarshal commented on pull request #3813: [HUDI-2563][hudi-client] Refactor CompactionTriggerStrategy.

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #3813:
URL: https://github.com/apache/hudi/pull/3813#issuecomment-1002441676


   > I'm not in favor of fat Enum either. But would like to understand the main benefit of this change: is it meant for portability of these logic? @RocMarshal
   
   Thanks @xushiyan for the review. After listening to your opinions, I don't think this reconstruction seems to be much significant.
   Or turn it off.
   If new strategies are introduced in the future, it goes perhaps without good scalability.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org