[GitHub] [fineract] francisguchie commented on pull request #1894: FINERACT-1410 :Allow Payment types to map to all types of Ledgers

[GitBox <gi...@apache.org>]

francisguchie commented on pull request #1894:
URL: https://github.com/apache/fineract/pull/1894#issuecomment-947213198


   Dear Victor,
   
   Most tests do not pass (at least for me) I think i have seen more than 10
   tests fail, so Ignore them most of the time. before you send a PR below are
   the steps you must do
   
   STEPS TAKEN
   1a- Add your Changes
   git add .
   
   1b- Apply Spotless
   ./gradlew spotlessApply
   
   2- Add your Changes
   git add .
   
   3- To Build War / Jar for deployment (any one below)
   ./gradlew clean bootWar  -- boots and builds war file
   ./gradlew clean war      -- builds war file
   ./gradlew bootJar        -- builds jar file
   
   Then you commit and push PR
   
   When these 3 sections pass on your PC then your PR should be OK
   
   
   
   My Kind Regards
   
   Francis Guchie Kirago
   *Skype:* francisguchie
   *Telegram: *232 79 19 44 07
   *Whatsapp: *232 79 19 44 07
   *LINKEDIN:* https://www.linkedin.com/in/francis-guchie-kirago-a4379617/
   twitter: @FrancisGuchie
   
   
   
   
   
   
   
   
   
   On Tue, Oct 19, 2021 at 7:49 PM Víctor Romero ***@***.***>
   wrote:
   
   > @ankita10r <https://github.com/ankita10r> @avikganguly01
   > <https://github.com/avikganguly01> in the testings I see these messages:
   >
   > org.apache.fineract.integrationtests.SkipRepaymentOnMonthFirstTest
   > Test testSkippingRepaymentOnFirstDayOfMonth() FAILED (3.8s)
   > org.opentest4j.AssertionFailedError: expected: <30> but was: <32>
   > at
   > app//org.apache.fineract.integrationtests.SkipRepaymentOnMonthFirstTest.tearDown(SkipRepaymentOnMonthFirstTest.java:71)
   > Test checkRepaymentSkipOnFirstDayOfMonth() SKIPPED
   > FAILURE: Executed 86 tests in 2m 16s (1 failed, 2 skipped)
   >
   > Are they expected?
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/fineract/pull/1894#issuecomment-947053724>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AFNCABTVWJ7KN4EA477EXE3UHXDWJANCNFSM5GG2FFOQ>
   > .
   > Triage notifications on the go with GitHub Mobile for iOS
   > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
   > or Android
   > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
   >
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org