You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/09 10:47:17 UTC
[GitHub] [airflow] potiuk opened a new pull request, #28254: Proper Python Host output from composite tasks in CI
potiuk opened a new pull request, #28254:
URL: https://github.com/apache/airflow/pull/28254
When we separated actions into composite workflows in #27369 and the #27371 we missed the fact that there was a step passing the host python version to static checks - to make sure we start with a fresh cache every time new python version is changed (this caused problems in the past)
The "host-python-version" was therefore empty and not really used in the cache key determining.
This has no bad effect when Python version does not change but when there is an upgrade of Python, the symbolic links in stored cache get broken, and next time new Python version is used in the AMIs, we might get them broken, so better to fix it now.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28254: Proper Python Host output from composite tasks in CI
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28254:
URL: https://github.com/apache/airflow/pull/28254#issuecomment-1344309500
re-running with debugging (debugging shows outputs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28254: Proper Python Host output from composite tasks in CI
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28254:
URL: https://github.com/apache/airflow/pull/28254#issuecomment-1344882654
OK. All looks good, cache is solved. Ready to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #28254: Proper Python Host output from composite tasks in CI
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #28254:
URL: https://github.com/apache/airflow/pull/28254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28254: Proper Python Host output from composite tasks in CI
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28254:
URL: https://github.com/apache/airflow/pull/28254#issuecomment-1345277559
This one wil (finally) cut down the time for static checks by 3 minutes for all PRs when merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28254: Proper Python Host output from composite tasks in CI
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28254:
URL: https://github.com/apache/airflow/pull/28254#issuecomment-1344308478
Still something is missing :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org