You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/06/03 17:00:06 UTC
[GitHub] [ignite-3] sashapolo commented on a change in pull request #161: IGNITE-14819 Propagate exceptions from NettyServer and NettyClient
sashapolo commented on a change in pull request #161:
URL: https://github.com/apache/ignite-3/pull/161#discussion_r644973942
##########
File path: modules/network/src/main/java/org/apache/ignite/network/internal/netty/ConnectionManager.java
##########
@@ -116,11 +117,17 @@ public ConnectionManager(
*/
public void start() throws IgniteInternalException {
try {
- server.start().join();
+ server.start().get(3, TimeUnit.SECONDS);
Review comment:
sorry, I don't understand what are you trying to say. Do you mean that we should a common configuration for all timeouts in the module?
##########
File path: modules/network/src/main/java/org/apache/ignite/network/internal/netty/ConnectionManager.java
##########
@@ -116,11 +117,17 @@ public ConnectionManager(
*/
public void start() throws IgniteInternalException {
try {
- server.start().join();
+ server.start().get(3, TimeUnit.SECONDS);
Review comment:
sorry, I don't understand what are you trying to say. Do you mean that we should have a common configuration for all timeouts in the module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org