You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "sadwitdastreetz (via GitHub)" <gi...@apache.org> on 2025/07/03 13:26:22 UTC

[PR] Fix : SameNeighborsBatchAPI diff between inner and community Ver [incubator-hugegraph]

sadwitdastreetz opened a new pull request, #2825:
URL: https://github.com/apache/incubator-hugegraph/pull/2825

   ## Purpose of the PR
   
   close #2798
   
   ## Main Changes
   
   Previously, SameNeighborBatch was included in inner version of Client and Server, and the Community version of Client, not including the Comunity version of Server.
   This PR would add this API to avoid the lack of the SameNeighborBatch function.
   
   ## Verifying these changes
   
   - [ ] Trivial rework / code cleanup without any test coverage. (No Need)
   - [x] Already covered by existing tests, such as *(please modify tests here)*.
   - [ ] Need tests and can be verified as follows:
       - xxx
   
   ## Does this PR potentially affect the following parts?
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ]  Dependencies ([add/update license](https://hugegraph.apache.org/docs/contribution-guidelines/contribute/#321-check-licenses) info & [regenerate_known_dependencies.sh](../install-dist/scripts/dependency/regenerate_known_dependencies.sh)) <!-- Don't forget to add/update the info in "LICENSE" & "NOTICE" files (both in root & dist module) -->
   - [ ]  Modify configurations
   - [x]  The public API
   - [ ]  Other affects (typed here)
   - [ ]  Nope
   
   
   ## Documentation Status
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ]  `Doc - TODO` <!-- Your PR changes impact docs and you will update later -->
   - [ ]  `Doc - Done` <!-- Related docs have been already added or updated -->
   - [x]  `Doc - No Need` <!-- Your PR changes don't impact/need docs -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] Fix : SameNeighborsBatchAPI diff between inner and community Ver [incubator-hugegraph]

Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #2825:
URL: https://github.com/apache/incubator-hugegraph/pull/2825#discussion_r2444769723


##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/traversers/SameNeighborsBatchAPI.java:
##########
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hugegraph.api.traversers;
+
+import static org.apache.hugegraph.traversal.algorithm.HugeTraverser.DEFAULT_ELEMENTS_LIMIT;
+import static org.apache.hugegraph.traversal.algorithm.HugeTraverser.DEFAULT_MAX_DEGREE;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+
+import org.apache.hugegraph.util.E;
+import org.apache.hugegraph.util.Log;
+import org.slf4j.Logger;
+
+import org.apache.hugegraph.HugeGraph;
+import org.apache.hugegraph.api.API;
+import org.apache.hugegraph.api.graph.EdgeAPI;
+import org.apache.hugegraph.core.GraphManager;
+import org.apache.hugegraph.backend.id.Id;
+import org.apache.hugegraph.server.RestServer;
+import org.apache.hugegraph.structure.HugeVertex;
+import org.apache.hugegraph.traversal.algorithm.SameNeighborTraverser;
+import org.apache.hugegraph.type.define.Directions;
+import com.codahale.metrics.annotation.Timed;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.databind.ObjectMapper;
+
+import io.swagger.v3.oas.annotations.tags.Tag;
+import jakarta.inject.Singleton;
+import jakarta.ws.rs.POST;
+import jakarta.ws.rs.Path;
+import jakarta.ws.rs.PathParam;
+import jakarta.ws.rs.Produces;
+import jakarta.ws.rs.core.Context;
+
+@Path("graphspaces/{graphspace}/graphs/{graph}/traversers/sameneighborsbatch")
+@Singleton
+@Tag(name = "SameNeighborsBatchAPI")
+public class SameNeighborsBatchAPI extends API {
+
+    private static final Logger LOG = Log.logger(RestServer.class);
+
+    @POST
+    @Timed
+    @Produces(APPLICATION_JSON_WITH_CHARSET)
+    public String sameNeighborsBatch(@Context GraphManager manager,
+                                     @PathParam("graphspace") String graphSpace,
+                                     @PathParam("graph") String graph,
+                                     Request req) {
+        LOG.debug("Graph [{}] get same neighbors batch, '{}'", graph, req.toString());
+
+        Directions dir = Directions.convert(EdgeAPI.parseDirection(req.direction));
+
+        ApiMeasurer measure = new ApiMeasurer();
+        HugeGraph g = graph(manager, graph);
+        SameNeighborTraverser traverser = new SameNeighborTraverser(g);
+
+        List<Set<Id>> result = new ArrayList<>();
+        for (List<Object> vertexPair : req.vertexList) {
+            E.checkArgument(vertexPair.size() == 2,
+                    "vertex_list size must be 2");
+            Id sourceId = HugeVertex.getIdValue(vertexPair.get(0));
+            Id targetId = HugeVertex.getIdValue(vertexPair.get(1));
+            Set<Id> neighbors = traverser.sameNeighbors(sourceId, targetId, dir,
+                    req.label, req.maxDegree, req.limit);
+            result.add(neighbors);
+        }
+        measure.addIterCount(traverser.vertexIterCounter.get(),
+                traverser.edgeIterCounter.get());
+
+        return manager.serializer(g, measure.measures()).writeList("same_neighbors", result);
+    }
+
+    private static class Request {
+        @JsonProperty("vertex_list")
+        private List<List<Object>> vertexList;
+        @JsonProperty("direction")
+        private String direction;
+        @JsonProperty("label")
+        private String label;
+        @JsonProperty("max_degree")
+        public long maxDegree = Long.parseLong(DEFAULT_MAX_DEGREE);
+        @JsonProperty("limit")
+        public int limit = Integer.parseInt(DEFAULT_ELEMENTS_LIMIT);
+
+        @Override
+        public String toString() {
+            ObjectMapper om = new ObjectMapper();
+            String vertexStr = "";
+            try {
+                vertexStr = om.writeValueAsString(this.vertexList);

Review Comment:
   ⚠️ **Important: Silent exception swallowing**
   
   Lines 106-107 catch an exception but do nothing with it - not even logging. This is a bad practice that makes debugging impossible.
   
   **Issues:**
   1. No logging of the error
   2. Returns empty string on failure, which may cause confusing behavior
   3. No indication to caller that serialization failed
   
   **Fix:**
   ```java
   try {
       vertexStr = om.writeValueAsString(this.vertexList);
   } catch (Exception e) {
       LOG.warn("Failed to serialize vertex list: {}", e.getMessage());
       vertexStr = "<serialization failed>";
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] Fix : SameNeighborsBatchAPI diff between inner and community Ver [incubator-hugegraph]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2825:
URL: https://github.com/apache/incubator-hugegraph/pull/2825#issuecomment-3041253984

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2825?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 93.25%. Comparing base [(`a53af86`)](https://app.codecov.io/gh/apache/incubator-hugegraph/commit/a53af864b31f803780a1db31cb20d3d94d5d34fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`d7b10d6`)](https://app.codecov.io/gh/apache/incubator-hugegraph/commit/d7b10d61e17bc79bb0bf66f8874fa57cdcffc9cf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #2825       +/-   ##
   =============================================
   + Coverage     41.23%   93.25%   +52.01%     
   + Complexity      333       65      -268     
   =============================================
     Files           747        9      -738     
     Lines         60163      267    -59896     
     Branches       7680       22     -7658     
   =============================================
   - Hits          24811      249    -24562     
   + Misses        32765        8    -32757     
   + Partials       2587       10     -2577     
   ```
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2825?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] refactor(server): handle SameNeighborsBatchAPI diff for client [hugegraph]

Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin merged PR #2825:
URL: https://github.com/apache/hugegraph/pull/2825


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] Fix : SameNeighborsBatchAPI diff between inner and community Ver [incubator-hugegraph]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2825:
URL: https://github.com/apache/incubator-hugegraph/pull/2825#issuecomment-3250799253

   Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] refactor: handle SameNeighborsBatchAPI diff for client [hugegraph]

Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on PR #2825:
URL: https://github.com/apache/hugegraph/pull/2825#issuecomment-6175972920

   +1 for 90bbe86. Cross-review found no blocking correctness or maintainability issues in the batch API or schema-cache ID bounds fix. Server CI (Memory, RocksDB and HStore) and CodeQL passed; project coverage is still red and should be checked before merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] Fix : SameNeighborsBatchAPI diff between inner and community Ver [incubator-hugegraph]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #2825:
URL: https://github.com/apache/incubator-hugegraph/pull/2825#discussion_r2444766799


##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/traversers/SameNeighborsBatchAPI.java:
##########
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hugegraph.api.traversers;
+
+import static org.apache.hugegraph.traversal.algorithm.HugeTraverser.DEFAULT_ELEMENTS_LIMIT;
+import static org.apache.hugegraph.traversal.algorithm.HugeTraverser.DEFAULT_MAX_DEGREE;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+
+import org.apache.hugegraph.util.E;
+import org.apache.hugegraph.util.Log;
+import org.slf4j.Logger;
+
+import org.apache.hugegraph.HugeGraph;
+import org.apache.hugegraph.api.API;
+import org.apache.hugegraph.api.graph.EdgeAPI;
+import org.apache.hugegraph.core.GraphManager;
+import org.apache.hugegraph.backend.id.Id;
+import org.apache.hugegraph.server.RestServer;
+import org.apache.hugegraph.structure.HugeVertex;
+import org.apache.hugegraph.traversal.algorithm.SameNeighborTraverser;
+import org.apache.hugegraph.type.define.Directions;
+import com.codahale.metrics.annotation.Timed;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.databind.ObjectMapper;
+
+import io.swagger.v3.oas.annotations.tags.Tag;
+import jakarta.inject.Singleton;
+import jakarta.ws.rs.POST;
+import jakarta.ws.rs.Path;
+import jakarta.ws.rs.PathParam;
+import jakarta.ws.rs.Produces;
+import jakarta.ws.rs.core.Context;
+
+@Path("graphspaces/{graphspace}/graphs/{graph}/traversers/sameneighborsbatch")
+@Singleton
+@Tag(name = "SameNeighborsBatchAPI")
+public class SameNeighborsBatchAPI extends API {
+
+    private static final Logger LOG = Log.logger(RestServer.class);
+
+    @POST
+    @Timed
+    @Produces(APPLICATION_JSON_WITH_CHARSET)
+    public String sameNeighborsBatch(@Context GraphManager manager,
+                                     @PathParam("graphspace") String graphSpace,
+                                     @PathParam("graph") String graph,
+                                     Request req) {
+        LOG.debug("Graph [{}] get same neighbors batch, '{}'", graph, req.toString());
+
+        Directions dir = Directions.convert(EdgeAPI.parseDirection(req.direction));
+
+        ApiMeasurer measure = new ApiMeasurer();
+        HugeGraph g = graph(manager, graph);
+        SameNeighborTraverser traverser = new SameNeighborTraverser(g);
+
+        List<Set<Id>> result = new ArrayList<>();
+        for (List<Object> vertexPair : req.vertexList) {
+            E.checkArgument(vertexPair.size() == 2,
+                    "vertex_list size must be 2");
+            Id sourceId = HugeVertex.getIdValue(vertexPair.get(0));
+            Id targetId = HugeVertex.getIdValue(vertexPair.get(1));
+            Set<Id> neighbors = traverser.sameNeighbors(sourceId, targetId, dir,
+                    req.label, req.maxDegree, req.limit);
+            result.add(neighbors);
+        }
+        measure.addIterCount(traverser.vertexIterCounter.get(),
+                traverser.edgeIterCounter.get());
+
+        return manager.serializer(g, measure.measures()).writeList("same_neighbors", result);
+    }
+
+    private static class Request {
+        @JsonProperty("vertex_list")
+        private List<List<Object>> vertexList;
+        @JsonProperty("direction")
+        private String direction;
+        @JsonProperty("label")
+        private String label;
+        @JsonProperty("max_degree")
+        public long maxDegree = Long.parseLong(DEFAULT_MAX_DEGREE);
+        @JsonProperty("limit")
+        public int limit = Integer.parseInt(DEFAULT_ELEMENTS_LIMIT);
+
+        @Override
+        public String toString() {
+            ObjectMapper om = new ObjectMapper();
+            String vertexStr = "";
+            try {
+                vertexStr = om.writeValueAsString(this.vertexList);
+            } catch (Exception e) {

Review Comment:
   Empty catch block silently swallows exceptions. Consider logging the error or at minimum adding a comment explaining why the exception is intentionally ignored. For example: `LOG.debug(\"Failed to serialize vertex list: {}\", e.getMessage());`
   ```suggestion
               } catch (Exception e) {
                   LOG.debug("Failed to serialize vertex list: {}", e.getMessage());
   ```



##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/traversers/SameNeighborsBatchAPI.java:
##########
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hugegraph.api.traversers;
+
+import static org.apache.hugegraph.traversal.algorithm.HugeTraverser.DEFAULT_ELEMENTS_LIMIT;
+import static org.apache.hugegraph.traversal.algorithm.HugeTraverser.DEFAULT_MAX_DEGREE;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+
+import org.apache.hugegraph.util.E;
+import org.apache.hugegraph.util.Log;
+import org.slf4j.Logger;
+
+import org.apache.hugegraph.HugeGraph;
+import org.apache.hugegraph.api.API;
+import org.apache.hugegraph.api.graph.EdgeAPI;
+import org.apache.hugegraph.core.GraphManager;
+import org.apache.hugegraph.backend.id.Id;
+import org.apache.hugegraph.server.RestServer;
+import org.apache.hugegraph.structure.HugeVertex;
+import org.apache.hugegraph.traversal.algorithm.SameNeighborTraverser;
+import org.apache.hugegraph.type.define.Directions;
+import com.codahale.metrics.annotation.Timed;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.databind.ObjectMapper;
+
+import io.swagger.v3.oas.annotations.tags.Tag;
+import jakarta.inject.Singleton;
+import jakarta.ws.rs.POST;
+import jakarta.ws.rs.Path;
+import jakarta.ws.rs.PathParam;
+import jakarta.ws.rs.Produces;
+import jakarta.ws.rs.core.Context;
+
+@Path("graphspaces/{graphspace}/graphs/{graph}/traversers/sameneighborsbatch")
+@Singleton
+@Tag(name = "SameNeighborsBatchAPI")
+public class SameNeighborsBatchAPI extends API {
+
+    private static final Logger LOG = Log.logger(RestServer.class);
+
+    @POST
+    @Timed
+    @Produces(APPLICATION_JSON_WITH_CHARSET)
+    public String sameNeighborsBatch(@Context GraphManager manager,
+                                     @PathParam("graphspace") String graphSpace,
+                                     @PathParam("graph") String graph,
+                                     Request req) {
+        LOG.debug("Graph [{}] get same neighbors batch, '{}'", graph, req.toString());
+
+        Directions dir = Directions.convert(EdgeAPI.parseDirection(req.direction));
+
+        ApiMeasurer measure = new ApiMeasurer();
+        HugeGraph g = graph(manager, graph);
+        SameNeighborTraverser traverser = new SameNeighborTraverser(g);
+
+        List<Set<Id>> result = new ArrayList<>();
+        for (List<Object> vertexPair : req.vertexList) {
+            E.checkArgument(vertexPair.size() == 2,
+                    "vertex_list size must be 2");
+            Id sourceId = HugeVertex.getIdValue(vertexPair.get(0));
+            Id targetId = HugeVertex.getIdValue(vertexPair.get(1));
+            Set<Id> neighbors = traverser.sameNeighbors(sourceId, targetId, dir,
+                    req.label, req.maxDegree, req.limit);
+            result.add(neighbors);
+        }
+        measure.addIterCount(traverser.vertexIterCounter.get(),
+                traverser.edgeIterCounter.get());
+
+        return manager.serializer(g, measure.measures()).writeList("same_neighbors", result);
+    }
+
+    private static class Request {
+        @JsonProperty("vertex_list")
+        private List<List<Object>> vertexList;
+        @JsonProperty("direction")
+        private String direction;
+        @JsonProperty("label")
+        private String label;
+        @JsonProperty("max_degree")
+        public long maxDegree = Long.parseLong(DEFAULT_MAX_DEGREE);
+        @JsonProperty("limit")
+        public int limit = Integer.parseInt(DEFAULT_ELEMENTS_LIMIT);
+
+        @Override
+        public String toString() {
+            ObjectMapper om = new ObjectMapper();
+            String vertexStr = "";
+            try {
+                vertexStr = om.writeValueAsString(this.vertexList);
+            } catch (Exception e) {
+            }
+            return String.format("SameNeighborsBatchRequest{vertex=%s,direction=%s,label=%s," +
+                            "max_degree=%d,limit=%d", vertexStr, this.direction,

Review Comment:
   Missing closing brace in format string. The string should end with `}` after `limit=%d`. Current output will be malformed like `limit=10` instead of `limit=10}`.
   ```suggestion
                               "max_degree=%d,limit=%d}", vertexStr, this.direction,
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] Fix : SameNeighborsBatchAPI diff between inner and community Ver [incubator-hugegraph]

Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #2825:
URL: https://github.com/apache/incubator-hugegraph/pull/2825#discussion_r2444770365


##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/traversers/SameNeighborsBatchAPI.java:
##########
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hugegraph.api.traversers;
+
+import static org.apache.hugegraph.traversal.algorithm.HugeTraverser.DEFAULT_ELEMENTS_LIMIT;
+import static org.apache.hugegraph.traversal.algorithm.HugeTraverser.DEFAULT_MAX_DEGREE;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+
+import org.apache.hugegraph.util.E;
+import org.apache.hugegraph.util.Log;
+import org.slf4j.Logger;
+
+import org.apache.hugegraph.HugeGraph;
+import org.apache.hugegraph.api.API;
+import org.apache.hugegraph.api.graph.EdgeAPI;
+import org.apache.hugegraph.core.GraphManager;
+import org.apache.hugegraph.backend.id.Id;
+import org.apache.hugegraph.server.RestServer;
+import org.apache.hugegraph.structure.HugeVertex;
+import org.apache.hugegraph.traversal.algorithm.SameNeighborTraverser;
+import org.apache.hugegraph.type.define.Directions;
+import com.codahale.metrics.annotation.Timed;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.databind.ObjectMapper;
+
+import io.swagger.v3.oas.annotations.tags.Tag;
+import jakarta.inject.Singleton;
+import jakarta.ws.rs.POST;
+import jakarta.ws.rs.Path;
+import jakarta.ws.rs.PathParam;
+import jakarta.ws.rs.Produces;
+import jakarta.ws.rs.core.Context;
+
+@Path("graphspaces/{graphspace}/graphs/{graph}/traversers/sameneighborsbatch")
+@Singleton
+@Tag(name = "SameNeighborsBatchAPI")
+public class SameNeighborsBatchAPI extends API {
+
+    private static final Logger LOG = Log.logger(RestServer.class);
+
+    @POST
+    @Timed
+    @Produces(APPLICATION_JSON_WITH_CHARSET)
+    public String sameNeighborsBatch(@Context GraphManager manager,
+                                     @PathParam("graphspace") String graphSpace,
+                                     @PathParam("graph") String graph,
+                                     Request req) {
+        LOG.debug("Graph [{}] get same neighbors batch, '{}'", graph, req.toString());
+
+        Directions dir = Directions.convert(EdgeAPI.parseDirection(req.direction));
+
+        ApiMeasurer measure = new ApiMeasurer();
+        HugeGraph g = graph(manager, graph);
+        SameNeighborTraverser traverser = new SameNeighborTraverser(g);
+
+        List<Set<Id>> result = new ArrayList<>();

Review Comment:
   ⚠️ **Important: Missing validation**
   
   No null check for `req.vertexList` before iterating. If the request body is malformed or missing `vertex_list`, this will throw a NullPointerException.
   
   **Add validation:**
   ```java
   E.checkArgumentNotNull(req.vertexList, "vertex_list cannot be null");
   E.checkArgument(!req.vertexList.isEmpty(), "vertex_list cannot be empty");
   
   for (List<Object> vertexPair : req.vertexList) {
       E.checkArgumentNotNull(vertexPair, "vertex pair cannot be null");
       E.checkArgument(vertexPair.size() == 2, "vertex_list size must be 2");
       // ...
   }
   ```



##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/traversers/SameNeighborsBatchAPI.java:
##########
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hugegraph.api.traversers;
+
+import static org.apache.hugegraph.traversal.algorithm.HugeTraverser.DEFAULT_ELEMENTS_LIMIT;
+import static org.apache.hugegraph.traversal.algorithm.HugeTraverser.DEFAULT_MAX_DEGREE;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+
+import org.apache.hugegraph.util.E;
+import org.apache.hugegraph.util.Log;
+import org.slf4j.Logger;
+
+import org.apache.hugegraph.HugeGraph;
+import org.apache.hugegraph.api.API;
+import org.apache.hugegraph.api.graph.EdgeAPI;
+import org.apache.hugegraph.core.GraphManager;
+import org.apache.hugegraph.backend.id.Id;
+import org.apache.hugegraph.server.RestServer;
+import org.apache.hugegraph.structure.HugeVertex;
+import org.apache.hugegraph.traversal.algorithm.SameNeighborTraverser;
+import org.apache.hugegraph.type.define.Directions;
+import com.codahale.metrics.annotation.Timed;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.databind.ObjectMapper;
+
+import io.swagger.v3.oas.annotations.tags.Tag;
+import jakarta.inject.Singleton;
+import jakarta.ws.rs.POST;
+import jakarta.ws.rs.Path;
+import jakarta.ws.rs.PathParam;
+import jakarta.ws.rs.Produces;
+import jakarta.ws.rs.core.Context;
+
+@Path("graphspaces/{graphspace}/graphs/{graph}/traversers/sameneighborsbatch")
+@Singleton
+@Tag(name = "SameNeighborsBatchAPI")
+public class SameNeighborsBatchAPI extends API {
+
+    private static final Logger LOG = Log.logger(RestServer.class);
+
+    @POST
+    @Timed
+    @Produces(APPLICATION_JSON_WITH_CHARSET)
+    public String sameNeighborsBatch(@Context GraphManager manager,
+                                     @PathParam("graphspace") String graphSpace,
+                                     @PathParam("graph") String graph,
+                                     Request req) {
+        LOG.debug("Graph [{}] get same neighbors batch, '{}'", graph, req.toString());
+
+        Directions dir = Directions.convert(EdgeAPI.parseDirection(req.direction));
+
+        ApiMeasurer measure = new ApiMeasurer();
+        HugeGraph g = graph(manager, graph);
+        SameNeighborTraverser traverser = new SameNeighborTraverser(g);
+
+        List<Set<Id>> result = new ArrayList<>();
+        for (List<Object> vertexPair : req.vertexList) {
+            E.checkArgument(vertexPair.size() == 2,
+                    "vertex_list size must be 2");
+            Id sourceId = HugeVertex.getIdValue(vertexPair.get(0));
+            Id targetId = HugeVertex.getIdValue(vertexPair.get(1));
+            Set<Id> neighbors = traverser.sameNeighbors(sourceId, targetId, dir,
+                    req.label, req.maxDegree, req.limit);
+            result.add(neighbors);
+        }
+        measure.addIterCount(traverser.vertexIterCounter.get(),
+                traverser.edgeIterCounter.get());
+
+        return manager.serializer(g, measure.measures()).writeList("same_neighbors", result);
+    }
+
+    private static class Request {
+        @JsonProperty("vertex_list")
+        private List<List<Object>> vertexList;
+        @JsonProperty("direction")
+        private String direction;
+        @JsonProperty("label")
+        private String label;
+        @JsonProperty("max_degree")
+        public long maxDegree = Long.parseLong(DEFAULT_MAX_DEGREE);
+        @JsonProperty("limit")
+        public int limit = Integer.parseInt(DEFAULT_ELEMENTS_LIMIT);
+
+        @Override
+        public String toString() {
+            ObjectMapper om = new ObjectMapper();
+            String vertexStr = "";
+            try {
+                vertexStr = om.writeValueAsString(this.vertexList);
+            } catch (Exception e) {
+            }

Review Comment:
   🧹 **Minor: Typo in format string**
   
   Line 109 has an incomplete format string - missing closing brace `}` after `limit=%d`.
   
   **Fix:**
   ```java
   return String.format("SameNeighborsBatchRequest{vertex=%s,direction=%s,label=%s," +
                        "max_degree=%d,limit=%d}", vertexStr, this.direction,
           this.label, this.maxDegree, this.limit);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] Fix : SameNeighborsBatchAPI diff between inner and community Ver [incubator-hugegraph]

Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #2825:
URL: https://github.com/apache/incubator-hugegraph/pull/2825#discussion_r2444769077


##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/traversers/SameNeighborsBatchAPI.java:
##########
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hugegraph.api.traversers;
+
+import static org.apache.hugegraph.traversal.algorithm.HugeTraverser.DEFAULT_ELEMENTS_LIMIT;
+import static org.apache.hugegraph.traversal.algorithm.HugeTraverser.DEFAULT_MAX_DEGREE;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+
+import org.apache.hugegraph.util.E;
+import org.apache.hugegraph.util.Log;
+import org.slf4j.Logger;
+
+import org.apache.hugegraph.HugeGraph;
+import org.apache.hugegraph.api.API;
+import org.apache.hugegraph.api.graph.EdgeAPI;
+import org.apache.hugegraph.core.GraphManager;
+import org.apache.hugegraph.backend.id.Id;
+import org.apache.hugegraph.server.RestServer;
+import org.apache.hugegraph.structure.HugeVertex;
+import org.apache.hugegraph.traversal.algorithm.SameNeighborTraverser;
+import org.apache.hugegraph.type.define.Directions;
+import com.codahale.metrics.annotation.Timed;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.databind.ObjectMapper;
+
+import io.swagger.v3.oas.annotations.tags.Tag;
+import jakarta.inject.Singleton;
+import jakarta.ws.rs.POST;
+import jakarta.ws.rs.Path;
+import jakarta.ws.rs.PathParam;
+import jakarta.ws.rs.Produces;
+import jakarta.ws.rs.core.Context;
+
+@Path("graphspaces/{graphspace}/graphs/{graph}/traversers/sameneighborsbatch")
+@Singleton
+@Tag(name = "SameNeighborsBatchAPI")
+public class SameNeighborsBatchAPI extends API {
+

Review Comment:
   ‼️ **Critical: Wrong Logger class usage**
   
   Line 56 creates a logger for `RestServer.class` instead of the current class `SameNeighborsBatchAPI.class`. This is incorrect and will make debugging difficult as log messages will appear to come from the wrong class.
   
   **Fix:**
   ```java
   private static final Logger LOG = Log.logger(SameNeighborsBatchAPI.class);
   ```



##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/traversers/SameNeighborsBatchAPI.java:
##########
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hugegraph.api.traversers;
+
+import static org.apache.hugegraph.traversal.algorithm.HugeTraverser.DEFAULT_ELEMENTS_LIMIT;
+import static org.apache.hugegraph.traversal.algorithm.HugeTraverser.DEFAULT_MAX_DEGREE;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+
+import org.apache.hugegraph.util.E;
+import org.apache.hugegraph.util.Log;
+import org.slf4j.Logger;
+
+import org.apache.hugegraph.HugeGraph;
+import org.apache.hugegraph.api.API;
+import org.apache.hugegraph.api.graph.EdgeAPI;
+import org.apache.hugegraph.core.GraphManager;
+import org.apache.hugegraph.backend.id.Id;
+import org.apache.hugegraph.server.RestServer;
+import org.apache.hugegraph.structure.HugeVertex;
+import org.apache.hugegraph.traversal.algorithm.SameNeighborTraverser;
+import org.apache.hugegraph.type.define.Directions;
+import com.codahale.metrics.annotation.Timed;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.databind.ObjectMapper;
+
+import io.swagger.v3.oas.annotations.tags.Tag;
+import jakarta.inject.Singleton;
+import jakarta.ws.rs.POST;
+import jakarta.ws.rs.Path;
+import jakarta.ws.rs.PathParam;
+import jakarta.ws.rs.Produces;
+import jakarta.ws.rs.core.Context;
+
+@Path("graphspaces/{graphspace}/graphs/{graph}/traversers/sameneighborsbatch")
+@Singleton
+@Tag(name = "SameNeighborsBatchAPI")
+public class SameNeighborsBatchAPI extends API {
+
+    private static final Logger LOG = Log.logger(RestServer.class);
+
+    @POST
+    @Timed
+    @Produces(APPLICATION_JSON_WITH_CHARSET)
+    public String sameNeighborsBatch(@Context GraphManager manager,
+                                     @PathParam("graphspace") String graphSpace,
+                                     @PathParam("graph") String graph,
+                                     Request req) {
+        LOG.debug("Graph [{}] get same neighbors batch, '{}'", graph, req.toString());
+
+        Directions dir = Directions.convert(EdgeAPI.parseDirection(req.direction));
+
+        ApiMeasurer measure = new ApiMeasurer();
+        HugeGraph g = graph(manager, graph);
+        SameNeighborTraverser traverser = new SameNeighborTraverser(g);
+
+        List<Set<Id>> result = new ArrayList<>();
+        for (List<Object> vertexPair : req.vertexList) {
+            E.checkArgument(vertexPair.size() == 2,
+                    "vertex_list size must be 2");
+            Id sourceId = HugeVertex.getIdValue(vertexPair.get(0));
+            Id targetId = HugeVertex.getIdValue(vertexPair.get(1));
+            Set<Id> neighbors = traverser.sameNeighbors(sourceId, targetId, dir,
+                    req.label, req.maxDegree, req.limit);
+            result.add(neighbors);
+        }
+        measure.addIterCount(traverser.vertexIterCounter.get(),
+                traverser.edgeIterCounter.get());
+
+        return manager.serializer(g, measure.measures()).writeList("same_neighbors", result);
+    }
+
+    private static class Request {
+        @JsonProperty("vertex_list")
+        private List<List<Object>> vertexList;
+        @JsonProperty("direction")
+        private String direction;
+        @JsonProperty("label")
+        private String label;
+        @JsonProperty("max_degree")
+        public long maxDegree = Long.parseLong(DEFAULT_MAX_DEGREE);

Review Comment:
   ⚠️ **Important: Inefficient parsing of constants**
   
   Lines 97-98 use `Long.parseLong()` and `Integer.parseInt()` on constants that are already defined as strings. This is inefficient and error-prone.
   
   If `DEFAULT_MAX_DEGREE` and `DEFAULT_ELEMENTS_LIMIT` are string constants like "10000", consider:
   1. Defining them as numeric constants directly, OR
   2. Parsing them once in a static initializer, OR
   3. If they must remain as strings elsewhere, create numeric constant versions for API usage
   
   **Current:**
   ```java
   public long maxDegree = Long.parseLong(DEFAULT_MAX_DEGREE);
   public int limit = Integer.parseInt(DEFAULT_ELEMENTS_LIMIT);
   ```
   
   **Better approach:**
   ```java
   public long maxDegree = DEFAULT_MAX_DEGREE_VALUE; // Define as long constant
   public int limit = DEFAULT_ELEMENTS_LIMIT_VALUE;   // Define as int constant
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] Fix : SameNeighborsBatchAPI diff between inner and community Ver [incubator-hugegraph]

Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #2825:
URL: https://github.com/apache/incubator-hugegraph/pull/2825#discussion_r2444768384


##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/api/traversers/SameNeighborsBatchAPI.java:
##########
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hugegraph.api.traversers;
+
+import static org.apache.hugegraph.traversal.algorithm.HugeTraverser.DEFAULT_ELEMENTS_LIMIT;
+import static org.apache.hugegraph.traversal.algorithm.HugeTraverser.DEFAULT_MAX_DEGREE;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+
+import org.apache.hugegraph.util.E;
+import org.apache.hugegraph.util.Log;
+import org.slf4j.Logger;
+
+import org.apache.hugegraph.HugeGraph;
+import org.apache.hugegraph.api.API;
+import org.apache.hugegraph.api.graph.EdgeAPI;
+import org.apache.hugegraph.core.GraphManager;
+import org.apache.hugegraph.backend.id.Id;
+import org.apache.hugegraph.server.RestServer;
+import org.apache.hugegraph.structure.HugeVertex;
+import org.apache.hugegraph.traversal.algorithm.SameNeighborTraverser;
+import org.apache.hugegraph.type.define.Directions;
+import com.codahale.metrics.annotation.Timed;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.databind.ObjectMapper;

Review Comment:
   ‼️ **Critical: Import organization issue**
   
   The import statements are not properly ordered. Standard Java convention and most projects require imports to be grouped and sorted:
   1. java/javax imports
   2. Third-party imports
   3. Project imports
   
   Current order mixes Apache HugeGraph imports with third-party libraries (Codahale, Jackson, Swagger, Jakarta). This violates standard Java conventions.
   
   **Suggestion:** Reorder imports to follow standard conventions:
   ```java
   // Java standard
   import java.util.ArrayList;
   import java.util.List;
   import java.util.Set;
   
   // Third-party
   import com.codahale.metrics.annotation.Timed;
   import com.fasterxml.jackson.annotation.JsonProperty;
   import com.fasterxml.jackson.databind.ObjectMapper;
   import io.swagger.v3.oas.annotations.tags.Tag;
   import jakarta.inject.Singleton;
   import jakarta.ws.rs.POST;
   // ... other jakarta imports
   
   // Apache HugeGraph
   import org.apache.hugegraph.HugeGraph;
   import org.apache.hugegraph.api.API;
   // ... other project imports
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] Fix : SameNeighborsBatchAPI diff between inner and community Ver [hugegraph]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #2825: Fix : SameNeighborsBatchAPI diff between inner and community Ver
URL: https://github.com/apache/hugegraph/pull/2825


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org