You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "hasnain-db (via GitHub)" <gi...@apache.org> on 2023/09/28 05:20:45 UTC
[GitHub] [spark] hasnain-db opened a new pull request, #43163: [SPARK-44937][CORE] Add test keys for SSL functionality
hasnain-db opened a new pull request, #43163:
URL: https://github.com/apache/spark/pull/43163
### What changes were proposed in this pull request?
This PR introduces test keys for SSL functionality. They keys were generated using something like the following:
```
openssl genpkey -algorithm RSA -out key.pem -hexseed deadbeef
openssl pkcs8 -topk8 -in key.pem -out key.pem.out
openssl req -new -key key.pem -out csr.csr -days 3650 -subj "/CN=test/ST=California/L=San Francisco/OU=Org1/O=Org2/C=US"
openssl x509 -req -in csr.csr -signkey key.pem -out certchain.pem -days 3650
rm key.pem csr.csr
mv key.pem.enc key.pem
```
And then copied to all the relevant folders. I also copied over the keystore and trustore files (did not regenerate those).
### Why are the changes needed?
We need these test files to run tests using PEM keys for SSL connections.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
These test files will be used by follow up PRs. This was tested as part of https://github.com/apache/spark/pull/42685, whic is being split.
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm closed pull request #43163: [SPARK-44937][CORE] Add test keys for SSL functionality
Posted by "mridulm (via GitHub)" <gi...@apache.org>.
mridulm closed pull request #43163: [SPARK-44937][CORE] Add test keys for SSL functionality
URL: https://github.com/apache/spark/pull/43163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hasnain-db commented on pull request #43163: [SPARK-44937][CORE] Add test keys for SSL functionality
Posted by "hasnain-db (via GitHub)" <gi...@apache.org>.
hasnain-db commented on PR #43163:
URL: https://github.com/apache/spark/pull/43163#issuecomment-1740126698
happy to do so, I'll update the inflight PRs that haven't merged yet and let you know if I need help re-linking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hasnain-db commented on pull request #43163: [SPARK-44937][CORE] Add test keys for SSL functionality
Posted by "hasnain-db (via GitHub)" <gi...@apache.org>.
hasnain-db commented on PR #43163:
URL: https://github.com/apache/spark/pull/43163#issuecomment-1739651461
@srowen these were used in https://github.com/apache/spark/pull/42685, I am splitting up that PR into parts to make it easier to review, per @mridulm 's sugestion. The tests using these will be added soon (once this and a few other foundational PRs are merged)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #43163: [SPARK-44937][CORE] Add test keys for SSL functionality
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #43163:
URL: https://github.com/apache/spark/pull/43163#issuecomment-1739650589
Where are these used though?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #43163: [SPARK-44937][CORE] Add test keys for SSL functionality
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #43163:
URL: https://github.com/apache/spark/pull/43163#issuecomment-1739655950
OK, hm, I don't really see the value in splitting this part out, but it doesn't hurt. @mridulm has the ball.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on pull request #43163: [SPARK-44937][CORE] Add test keys for SSL functionality
Posted by "mridulm (via GitHub)" <gi...@apache.org>.
mridulm commented on PR #43163:
URL: https://github.com/apache/spark/pull/43163#issuecomment-1740124899
Just noticed that we are using the same jira for all of the PR's.
Can you create this as an umbrella jira and have individual tasks for each of the PR's please ? Makes it easier to track.
We can manually relink the merged PR's in the jira for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on pull request #43163: [SPARK-44937][CORE] Add test keys for SSL functionality
Posted by "mridulm (via GitHub)" <gi...@apache.org>.
mridulm commented on PR #43163:
URL: https://github.com/apache/spark/pull/43163#issuecomment-1740123711
Merged to master.
Thanks for adding this @hasnain-db.
Thanks @srowen and @JoshRosen for review :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org