You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Paul Burba <pt...@gmail.com> on 2009/01/29 04:19:56 UTC
Attn: Windows Devs -- Need to add missing sqlite build options for
Windows (issue #3364)
Right now when building trunk on Windows you have one option when it
comes to sqlite: Use the --with-sqlite option to gen-make.py to point
to a directory with this structure and contents:
inc/
inc/sqlite3.h
lib/
lib/sqlite3.lib
So basically, if you haven't built sqlite on your own already then
Subversion won't build. It seems to me we should support sqlite build
options analogous to those on *nix, e.g. just drop the amalgamation
files in .\sqlite-amalgamation and it gets built.
I created issue #3364 to track this and added the start of a patch to
fix things. I need to work on some higher priority things right now
and will get back to this eventually, *BUT* in the meantime, if
anybody more familiar with the voodoo that is the Windows build system
wants to take a look please, please do!
Thanks,
Paul
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1066562
RE: Attn: Windows Devs -- Need to add missing sqlite build options
for Windows (issue #3364)
Posted by Bert Huijben <rh...@sharpsvn.net>.
> -----Original Message-----
> From: chemodax@gmail.com [mailto:chemodax@gmail.com] On Behalf Of Ivan
Zhakov
> Sent: woensdag 18 februari 2009 14:43
> To: Paul Burba
> Cc: dev@subversion.tigris.org
> Subject: Re: Attn: Windows Devs -- Need to add missing sqlite build
options
> for Windows (issue #3364)
>
> On Thu, Jan 29, 2009 at 7:19 AM, Paul Burba <pt...@gmail.com> wrote:
> > Right now when building trunk on Windows you have one option when it
> > comes to sqlite: Use the --with-sqlite option to gen-make.py to point
> > to a directory with this structure and contents:
> >
> > inc/
> > inc/sqlite3.h
> > lib/
> > lib/sqlite3.lib
> >
> > So basically, if you haven't built sqlite on your own already then
> > Subversion won't build. It seems to me we should support sqlite build
> > options analogous to those on *nix, e.g. just drop the amalgamation
> > files in .\sqlite-amalgamation and it gets built.
> >
> Hi Paul,
>
> Thanks for noting that. I've looked to current sqlite build stuff on
> Windows. It still does not support sqlite-amalgamation.
>
> So I propose to implement only amalgamation option for sqlite, without
> supporting to use "installed" version of library. Since there is no
> term of installed libraries on Windows. I do not see benefits of using
> sqlite compiled out of source tree on Windows. It can be only source
> of problems if different compiler or compiler options will be used.
>
> I volunteer to implement support for sqlite amalgamation on Windows,
> if no one object to drop other sqlite build option on Windows.
Is it a problem to just keep the current build option?
(+1 on making the amalgamation default on Windows)
The amalgamation build makes it impossible to re-use Sqlite from
applications that use both Subversion and Sqlite (Requiring them to link to
two separate copies).
The current method works for at least my automated build and TortoiseSVN's,
so why break it?
Bert
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1186812
Re: Attn: Windows Devs -- Need to add missing sqlite build options
for Windows (issue #3364)
Posted by Ivan Zhakov <iv...@visualsvn.com>.
On Wed, Feb 18, 2009 at 5:30 PM, Mark Phippard <ma...@gmail.com> wrote:
> On Wed, Feb 18, 2009 at 8:42 AM, Ivan Zhakov <iv...@visualsvn.com> wrote:
>> On Thu, Jan 29, 2009 at 7:19 AM, Paul Burba <pt...@gmail.com> wrote:
>>> Right now when building trunk on Windows you have one option when it
>>> comes to sqlite: Use the --with-sqlite option to gen-make.py to point
>>> to a directory with this structure and contents:
>>>
>>> inc/
>>> inc/sqlite3.h
>>> lib/
>>> lib/sqlite3.lib
>>>
>>> So basically, if you haven't built sqlite on your own already then
>>> Subversion won't build. It seems to me we should support sqlite build
>>> options analogous to those on *nix, e.g. just drop the amalgamation
>>> files in .\sqlite-amalgamation and it gets built.
>>>
>> Hi Paul,
>>
>> Thanks for noting that. I've looked to current sqlite build stuff on
>> Windows. It still does not support sqlite-amalgamation.
>>
>> So I propose to implement only amalgamation option for sqlite, without
>> supporting to use "installed" version of library. Since there is no
>> term of installed libraries on Windows. I do not see benefits of using
>> sqlite compiled out of source tree on Windows. It can be only source
>> of problems if different compiler or compiler options will be used.
>>
>> I volunteer to implement support for sqlite amalgamation on Windows,
>> if no one object to drop other sqlite build option on Windows.
>
> +1
>
> I'd ask that you make it work with the format of the way it is shipped
> in our deps zip file, assuming we are not going to include it in the
> source tree.
Ok, I take account of this.
>
> Personally, I'd also like to see it statically linked in
> libsvn_subr-1.dll and not an external DLL as well. If we are going to
> build it, then let's not make it possible to load the wrong DLL at
> runtime too.
Sure, I'll make it in the same as we do with serf and zlib. There
statically linked to our libraries.
--
Ivan Zhakov
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1186458
Re: Attn: Windows Devs -- Need to add missing sqlite build options
for Windows (issue #3364)
Posted by Mark Phippard <ma...@gmail.com>.
On Wed, Feb 18, 2009 at 8:42 AM, Ivan Zhakov <iv...@visualsvn.com> wrote:
> On Thu, Jan 29, 2009 at 7:19 AM, Paul Burba <pt...@gmail.com> wrote:
>> Right now when building trunk on Windows you have one option when it
>> comes to sqlite: Use the --with-sqlite option to gen-make.py to point
>> to a directory with this structure and contents:
>>
>> inc/
>> inc/sqlite3.h
>> lib/
>> lib/sqlite3.lib
>>
>> So basically, if you haven't built sqlite on your own already then
>> Subversion won't build. It seems to me we should support sqlite build
>> options analogous to those on *nix, e.g. just drop the amalgamation
>> files in .\sqlite-amalgamation and it gets built.
>>
> Hi Paul,
>
> Thanks for noting that. I've looked to current sqlite build stuff on
> Windows. It still does not support sqlite-amalgamation.
>
> So I propose to implement only amalgamation option for sqlite, without
> supporting to use "installed" version of library. Since there is no
> term of installed libraries on Windows. I do not see benefits of using
> sqlite compiled out of source tree on Windows. It can be only source
> of problems if different compiler or compiler options will be used.
>
> I volunteer to implement support for sqlite amalgamation on Windows,
> if no one object to drop other sqlite build option on Windows.
+1
I'd ask that you make it work with the format of the way it is shipped
in our deps zip file, assuming we are not going to include it in the
source tree.
Personally, I'd also like to see it statically linked in
libsvn_subr-1.dll and not an external DLL as well. If we are going to
build it, then let's not make it possible to load the wrong DLL at
runtime too.
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1186262
Re: Attn: Windows Devs -- Need to add missing sqlite build options
for Windows (issue #3364)
Posted by Paul Burba <pt...@gmail.com>.
On Wed, Feb 18, 2009 at 8:42 AM, Ivan Zhakov <iv...@visualsvn.com> wrote:
> On Thu, Jan 29, 2009 at 7:19 AM, Paul Burba <pt...@gmail.com> wrote:
>> Right now when building trunk on Windows you have one option when it
>> comes to sqlite: Use the --with-sqlite option to gen-make.py to point
>> to a directory with this structure and contents:
>>
>> inc/
>> inc/sqlite3.h
>> lib/
>> lib/sqlite3.lib
>>
>> So basically, if you haven't built sqlite on your own already then
>> Subversion won't build. It seems to me we should support sqlite build
>> options analogous to those on *nix, e.g. just drop the amalgamation
>> files in .\sqlite-amalgamation and it gets built.
>>
> Hi Paul,
>
> Thanks for noting that. I've looked to current sqlite build stuff on
> Windows. It still does not support sqlite-amalgamation.
>
> So I propose to implement only amalgamation option for sqlite, without
> supporting to use "installed" version of library.
+1
> Since there is no
> term of installed libraries on Windows. I do not see benefits of using
> sqlite compiled out of source tree on Windows. It can be only source
> of problems if different compiler or compiler options will be used.
>
> I volunteer to implement support for sqlite amalgamation on Windows,
> if no one object to drop other sqlite build option on Windows.
Thanks for taking this on Ivan.
Paul
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1186139
Re: Attn: Windows Devs -- Need to add missing sqlite build options
for Windows (issue #3364)
Posted by Ivan Zhakov <iv...@visualsvn.com>.
On Wed, Feb 18, 2009 at 7:02 PM, Bert Huijben <be...@qqmail.nl> wrote:
> [Resending this mail as it didn't seem to reach the list or its other
> recipients]
>
>> -----Original Message-----
>> From: chemodax@gmail.com [mailto:chemodax@gmail.com] On Behalf Of Ivan
> Zhakov
>> Sent: woensdag 18 februari 2009 14:43
>> To: Paul Burba
>> Cc: dev@subversion.tigris.org
>> Subject: Re: Attn: Windows Devs -- Need to add missing sqlite build
> options
>> for Windows (issue #3364)
>>
>> On Thu, Jan 29, 2009 at 7:19 AM, Paul Burba <pt...@gmail.com> wrote:
>> > Right now when building trunk on Windows you have one option when it
>> > comes to sqlite: Use the --with-sqlite option to gen-make.py to point
>> > to a directory with this structure and contents:
>> >
>> > inc/
>> > inc/sqlite3.h
>> > lib/
>> > lib/sqlite3.lib
>> >
>> > So basically, if you haven't built sqlite on your own already then
>> > Subversion won't build. It seems to me we should support sqlite build
>> > options analogous to those on *nix, e.g. just drop the amalgamation
>> > files in .\sqlite-amalgamation and it gets built.
>> >
>> Hi Paul,
>>
>> Thanks for noting that. I've looked to current sqlite build stuff on
>> Windows. It still does not support sqlite-amalgamation.
>>
>> So I propose to implement only amalgamation option for sqlite, without
>> supporting to use "installed" version of library. Since there is no
>> term of installed libraries on Windows. I do not see benefits of using
>> sqlite compiled out of source tree on Windows. It can be only source
>> of problems if different compiler or compiler options will be used.
>>
>> I volunteer to implement support for sqlite amalgamation on Windows,
>> if no one object to drop other sqlite build option on Windows.
>
> Is it a problem to just keep the current build option?
> (+1 on making the amalgamation default on Windows)
It's just additional code in already messy and overloaded build
system. I'm going to try support both methods if does not require a
lot of code in build system.
> The amalgamation build makes it impossible to re-use Sqlite from
> applications that use both Subversion and Sqlite (Requiring them to link to
> two separate copies).
Good point.
>
> The current method works for at least my automated build and TortoiseSVN's,
> so why break it?
--
Ivan Zhakov
VisualSVN Team
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1186855
Re: Attn: Windows Devs -- Need to add missing sqlite build options
for Windows (issue #3364)
Posted by Stefan Küng <to...@gmail.com>.
Mark Phippard wrote:
> On Wed, Feb 18, 2009 at 12:09 PM, Stefan Küng <to...@gmail.com> wrote:
>>> No we don't want users to look in our database, but why can't I access my
>>> own sqlite database? (TortoiseSVN uses sqlite for its log cache if I
>>> remember correctly)
>> Ahem: no. The log cache uses its own binary format. No db backend at all.
>>
>>> And why don't we want users to share the same sqlite installation on
>>> Windows, while we can't even specify a standard version of sqlite on other
>>> OSs?
>>>
>> shared libs on Windows is always a very bad idea. Only optimists who
>> never had their app in use by more than 2 people would even consider
>> such a thing.
>>
>> Seriously: in TSVN, we use our own build script not just because we can
>> automate the whole build that way, but also to 'rename' all the shared
>> libs to avoid any possible problems of the so called 'dll hell'.
>
> This is what I was thinking too. Look how often we have to deal with
> crappy apps that dump old OpenSSL DLL's into the Windows\System32
> folder. I am also thinking of apps like TortoiseSVN and AnkhSVN that
> will use the latest Visual Studio to compile everything, and Subclipse
> and the command line which still use MSVC 6. We would not want those
> DLL's to mix.
>
Exactly. Windows is a hostile environment for applications.
That's why TSVN doesn't use any shared lib at all (except the
C-runtimes, but those are stored in the GAC and versioned even if they
use the same dll name). Even OpenSSL is linked statically in TSVN
(because of some stupid firewalls (which shall kept unnamed) putting
their completely outdated and non-standard configured dll in the
SYSTEM32 folder.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1187194
Re: Attn: Windows Devs -- Need to add missing sqlite build options
for Windows (issue #3364)
Posted by Mark Phippard <ma...@gmail.com>.
On Wed, Feb 18, 2009 at 12:09 PM, Stefan Küng <to...@gmail.com> wrote:
>> No we don't want users to look in our database, but why can't I access my
>> own sqlite database? (TortoiseSVN uses sqlite for its log cache if I
>> remember correctly)
>
> Ahem: no. The log cache uses its own binary format. No db backend at all.
>
>> And why don't we want users to share the same sqlite installation on
>> Windows, while we can't even specify a standard version of sqlite on other
>> OSs?
>>
>
> shared libs on Windows is always a very bad idea. Only optimists who
> never had their app in use by more than 2 people would even consider
> such a thing.
>
> Seriously: in TSVN, we use our own build script not just because we can
> automate the whole build that way, but also to 'rename' all the shared
> libs to avoid any possible problems of the so called 'dll hell'.
This is what I was thinking too. Look how often we have to deal with
crappy apps that dump old OpenSSL DLL's into the Windows\System32
folder. I am also thinking of apps like TortoiseSVN and AnkhSVN that
will use the latest Visual Studio to compile everything, and Subclipse
and the command line which still use MSVC 6. We would not want those
DLL's to mix.
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1187158
Re: Attn: Windows Devs -- Need to add missing sqlite build options
for Windows (issue #3364)
Posted by Stefan Küng <to...@gmail.com>.
Bert Huijben wrote:
>> -----Original Message-----
>> From: Mark Phippard [mailto:markphip@gmail.com]
>> Sent: woensdag 18 februari 2009 17:08
>> To: Bert Huijben
>> Cc: Ivan Zhakov; Paul Burba; dev@subversion.tigris.org
>> Subject: Re: Attn: Windows Devs -- Need to add missing sqlite build
> options
>> for Windows (issue #3364)
>>
>> On Wed, Feb 18, 2009 at 11:02 AM, Bert Huijben <rh...@sharpsvn.net>
> wrote:
>>> Is it a problem to just keep the current build option?
>>> (+1 on making the amalgamation default on Windows)
>>>
>>> The amalgamation build makes it impossible to re-use Sqlite from
>>> applications that use both Subversion and Sqlite (Requiring them to link
> to
>>> two separate copies).
>> Do we really want to support that? I'd assume for example, we do not
>> want application to use SQLite to directly access whatever database we
>> are using. So the only issue would be a client that uses Subversion
>> and also uses SQLite for its own datastore. In that scenario,
>> assuming it exists, is it so bad for the application to use another
>> SQLite for that purpose?
>
> No we don't want users to look in our database, but why can't I access my
> own sqlite database? (TortoiseSVN uses sqlite for its log cache if I
> remember correctly)
Ahem: no. The log cache uses its own binary format. No db backend at all.
> And why don't we want users to share the same sqlite installation on
> Windows, while we can't even specify a standard version of sqlite on other
> OSs?
>
shared libs on Windows is always a very bad idea. Only optimists who
never had their app in use by more than 2 people would even consider
such a thing.
Seriously: in TSVN, we use our own build script not just because we can
automate the whole build that way, but also to 'rename' all the shared
libs to avoid any possible problems of the so called 'dll hell'.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1187080
RE: Attn: Windows Devs -- Need to add missing sqlite build options
for Windows (issue #3364)
Posted by Bert Huijben <rh...@sharpsvn.net>.
> -----Original Message-----
> From: Mark Phippard [mailto:markphip@gmail.com]
> Sent: woensdag 18 februari 2009 17:08
> To: Bert Huijben
> Cc: Ivan Zhakov; Paul Burba; dev@subversion.tigris.org
> Subject: Re: Attn: Windows Devs -- Need to add missing sqlite build
options
> for Windows (issue #3364)
>
> On Wed, Feb 18, 2009 at 11:02 AM, Bert Huijben <rh...@sharpsvn.net>
wrote:
> > Is it a problem to just keep the current build option?
> > (+1 on making the amalgamation default on Windows)
> >
> > The amalgamation build makes it impossible to re-use Sqlite from
> > applications that use both Subversion and Sqlite (Requiring them to link
to
> > two separate copies).
>
> Do we really want to support that? I'd assume for example, we do not
> want application to use SQLite to directly access whatever database we
> are using. So the only issue would be a client that uses Subversion
> and also uses SQLite for its own datastore. In that scenario,
> assuming it exists, is it so bad for the application to use another
> SQLite for that purpose?
No we don't want users to look in our database, but why can't I access my
own sqlite database? (TortoiseSVN uses sqlite for its log cache if I
remember correctly)
And why don't we want users to share the same sqlite installation on
Windows, while we can't even specify a standard version of sqlite on other
OSs?
Using sqlite shared works right now... Why disable it?
Why break specific Windows scenarios on purpose?
Just for the fun of doing this because windows is .... (fill in your
favorite problem) ?
Bert
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1186958
Re: Attn: Windows Devs -- Need to add missing sqlite build options
for Windows (issue #3364)
Posted by Paul Burba <pt...@gmail.com>.
On Wed, Feb 18, 2009 at 2:24 PM, Mark Phippard <ma...@gmail.com> wrote:
> On Wed, Feb 18, 2009 at 2:22 PM, Paul Burba <pt...@gmail.com> wrote:
>> This is supposed to *build* sqlite if I point --with-sqlite to a
>> directory containing the amalgamation files right? Because no matter
>> where I put the amalgamation the build fails for me because
>> sqlite3.lib is not created:
>
> I thought you had to leave off the option and have an in-tree folder
> named sqlite-amalgamation?
I meant that whether I used the --with-sqlite option or not, and
whether or not there was a pre-built sqlite or just the amalgamation
files in .\sqlite-amalgamation (or the target of --with-sqlite), that
nothing built no matter what the combination. The build output I
printed was just to demonstrate the problem. Sorry for the confusion.
Paul
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1188409
Re: Attn: Windows Devs -- Need to add missing sqlite build options
for Windows (issue #3364)
Posted by Mark Phippard <ma...@gmail.com>.
On Wed, Feb 18, 2009 at 2:22 PM, Paul Burba <pt...@gmail.com> wrote:
> This is supposed to *build* sqlite if I point --with-sqlite to a
> directory containing the amalgamation files right? Because no matter
> where I put the amalgamation the build fails for me because
> sqlite3.lib is not created:
I thought you had to leave off the option and have an in-tree folder
named sqlite-amalgamation?
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1187710
Re: Attn: Windows Devs -- Need to add missing sqlite build options
for Windows (issue #3364)
Posted by Ivan Zhakov <iv...@visualsvn.com>.
On Thu, Feb 19, 2009 at 1:25 AM, Paul Burba <pt...@gmail.com> wrote:
> On Wed, Feb 18, 2009 at 3:10 PM, Ivan Zhakov <iv...@visualsvn.com> wrote:
>> On Wed, Feb 18, 2009 at 10:57 PM, Ivan Zhakov <iv...@visualsvn.com> wrote:
>>> On Wed, Feb 18, 2009 at 10:22 PM, Paul Burba <pt...@gmail.com> wrote:
>
> <snip>
>
>>>> Ivan,
>>>>
>>>> This is supposed to *build* sqlite if I point --with-sqlite to a
>>>> directory containing the amalgamation files right? Because no matter
>>>> where I put the amalgamation the build fails for me because
>>>> sqlite3.lib is not created:
>>>>
>>>> (If this is working for you I suspect you are picking up some existing
>>>> sqlite.lib)
>>> Oops, my fault. I post updated patch in ten minutes.
>>>
>> Here is updated patch.
>>
>> --
>> Ivan Zhakov
>
> Ivan,
>
> I checked the following scenarios, everything works fine:
>
Thanks Paul for testing this stuff. I've committed patch in r35967.
PS: I'm going to bed, so feel free to nominate it to 1.6.x branch.
--
Ivan Zhakov
VisualSVN Team
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1188520
Re: Attn: Windows Devs -- Need to add missing sqlite build options
for Windows (issue #3364)
Posted by Paul Burba <pt...@gmail.com>.
On Wed, Feb 18, 2009 at 3:10 PM, Ivan Zhakov <iv...@visualsvn.com> wrote:
> On Wed, Feb 18, 2009 at 10:57 PM, Ivan Zhakov <iv...@visualsvn.com> wrote:
>> On Wed, Feb 18, 2009 at 10:22 PM, Paul Burba <pt...@gmail.com> wrote:
<snip>
>>> Ivan,
>>>
>>> This is supposed to *build* sqlite if I point --with-sqlite to a
>>> directory containing the amalgamation files right? Because no matter
>>> where I put the amalgamation the build fails for me because
>>> sqlite3.lib is not created:
>>>
>>> (If this is working for you I suspect you are picking up some existing
>>> sqlite.lib)
>> Oops, my fault. I post updated patch in ten minutes.
>>
> Here is updated patch.
>
> --
> Ivan Zhakov
Ivan,
I checked the following scenarios, everything works fine:
--with-sqlite | TARGET | .\sqlite-amalgamation | Result
gen-make.py OPTION | | |
============================================================================
--with-sqlite TARGET | sqlite3.h | Empty | Build
| sqlite3.c | | Successful
============================================================================
--with-sqlite TARGET | VS2008 sqlite | Empty | Build
| solution with | | Successful
| .\bin | |
| .\src | |
| .\lib | |
| setup | |
============================================================================
None | Empty | VS2007 sqlite | Build
| | solution | Successful
| | with |
| | .\bin |
| | .\src |
| | .\lib |
| | setup |
============================================================================
None | Empty | sqlite3.h | Build
| | sqlite3.c | Successful
============================================================================
None | Empty | Empty | SQLite not
| | | found
| | | error.
============================================================================
The only other thing we might want to add is to stop the build if we
detect sqlite < 3.4.0, rather than simply issuing a warning; the
attached variant of your patch does that.
Paul
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1188411
Re: Attn: Windows Devs -- Need to add missing sqlite build options
for Windows (issue #3364)
Posted by Ivan Zhakov <iv...@visualsvn.com>.
On Wed, Feb 18, 2009 at 10:57 PM, Ivan Zhakov <iv...@visualsvn.com> wrote:
> On Wed, Feb 18, 2009 at 10:22 PM, Paul Burba <pt...@gmail.com> wrote:
>> On Wed, Feb 18, 2009 at 11:44 AM, Ivan Zhakov <iv...@visualsvn.com> wrote:
>>> On Wed, Feb 18, 2009 at 7:08 PM, Mark Phippard <ma...@gmail.com> wrote:
>>>> On Wed, Feb 18, 2009 at 11:02 AM, Bert Huijben <rh...@sharpsvn.net> wrote:
>>>>> Is it a problem to just keep the current build option?
>>>>> (+1 on making the amalgamation default on Windows)
>>>>>
>>>>> The amalgamation build makes it impossible to re-use Sqlite from
>>>>> applications that use both Subversion and Sqlite (Requiring them to link to
>>>>> two separate copies).
>>>>
>>>> That said, I am not against supporting other options as long as we can
>>>> make the default fairly easy.
>>>>
>>> Paul, Mark and Bert,
>>>
>>> Please check attached patch. I've implemented the same behavior as
>>> *nix system which is described in build\ac-macros\sqlite.m4:
>>> [[[
>>> If a --with-sqlite=PREFIX option is passed, look for a suitable sqlite
>>> either installed under the directory PREFIX or as an amalgamation file
>>> at the path PREFIX. In this case ignore any sqlite-amalgamation/ subdir
>>> within the source tree.
>>>
>>> If no --with-sqlite option is passed, look first for
>>> sqlite-amalgamation/sqlite3.c which should be the amalgamated version of
>>> the source distribution. If the amalgamation exists and is the wrong
>>> version, exit with a failure. If no sqlite-amalgamation/ subdir is
>>> present, search for a sqlite installed on the system.
>>> ]]]
>>>
>>> So existing builds should not be broken with this patch. While simple
>>> point --with-sqlite to directory with SQLite amalgamation directory or
>>> putting it to directory sqlite-amalgamation should be enough to build
>>> Subversion.
>>>
>>> Log message:
>>> [[[
>>> Add support to build and use SQLite amalgamation version on Windows.
>> ^^^
>>> This implements the same behavior as *nix build system does.
>>
>> Ivan,
>>
>> This is supposed to *build* sqlite if I point --with-sqlite to a
>> directory containing the amalgamation files right? Because no matter
>> where I put the amalgamation the build fails for me because
>> sqlite3.lib is not created:
>>
>> (If this is working for you I suspect you are picking up some existing
>> sqlite.lib)
> Oops, my fault. I post updated patch in ten minutes.
>
Here is updated patch.
--
Ivan Zhakov
VisualSVN Team
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1187888
Re: Attn: Windows Devs -- Need to add missing sqlite build options
for Windows (issue #3364)
Posted by Ivan Zhakov <iv...@visualsvn.com>.
On Wed, Feb 18, 2009 at 10:22 PM, Paul Burba <pt...@gmail.com> wrote:
> On Wed, Feb 18, 2009 at 11:44 AM, Ivan Zhakov <iv...@visualsvn.com> wrote:
>> On Wed, Feb 18, 2009 at 7:08 PM, Mark Phippard <ma...@gmail.com> wrote:
>>> On Wed, Feb 18, 2009 at 11:02 AM, Bert Huijben <rh...@sharpsvn.net> wrote:
>>>> Is it a problem to just keep the current build option?
>>>> (+1 on making the amalgamation default on Windows)
>>>>
>>>> The amalgamation build makes it impossible to re-use Sqlite from
>>>> applications that use both Subversion and Sqlite (Requiring them to link to
>>>> two separate copies).
>>>
>>> That said, I am not against supporting other options as long as we can
>>> make the default fairly easy.
>>>
>> Paul, Mark and Bert,
>>
>> Please check attached patch. I've implemented the same behavior as
>> *nix system which is described in build\ac-macros\sqlite.m4:
>> [[[
>> If a --with-sqlite=PREFIX option is passed, look for a suitable sqlite
>> either installed under the directory PREFIX or as an amalgamation file
>> at the path PREFIX. In this case ignore any sqlite-amalgamation/ subdir
>> within the source tree.
>>
>> If no --with-sqlite option is passed, look first for
>> sqlite-amalgamation/sqlite3.c which should be the amalgamated version of
>> the source distribution. If the amalgamation exists and is the wrong
>> version, exit with a failure. If no sqlite-amalgamation/ subdir is
>> present, search for a sqlite installed on the system.
>> ]]]
>>
>> So existing builds should not be broken with this patch. While simple
>> point --with-sqlite to directory with SQLite amalgamation directory or
>> putting it to directory sqlite-amalgamation should be enough to build
>> Subversion.
>>
>> Log message:
>> [[[
>> Add support to build and use SQLite amalgamation version on Windows.
> ^^^
>> This implements the same behavior as *nix build system does.
>
> Ivan,
>
> This is supposed to *build* sqlite if I point --with-sqlite to a
> directory containing the amalgamation files right? Because no matter
> where I put the amalgamation the build fails for me because
> sqlite3.lib is not created:
>
> (If this is working for you I suspect you are picking up some existing
> sqlite.lib)
Oops, my fault. I post updated patch in ten minutes.
--
Ivan Zhakov
VisualSVN Team
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1187828
Re: Attn: Windows Devs -- Need to add missing sqlite build options
for Windows (issue #3364)
Posted by Paul Burba <pt...@gmail.com>.
On Wed, Feb 18, 2009 at 11:44 AM, Ivan Zhakov <iv...@visualsvn.com> wrote:
> On Wed, Feb 18, 2009 at 7:08 PM, Mark Phippard <ma...@gmail.com> wrote:
>> On Wed, Feb 18, 2009 at 11:02 AM, Bert Huijben <rh...@sharpsvn.net> wrote:
>>> Is it a problem to just keep the current build option?
>>> (+1 on making the amalgamation default on Windows)
>>>
>>> The amalgamation build makes it impossible to re-use Sqlite from
>>> applications that use both Subversion and Sqlite (Requiring them to link to
>>> two separate copies).
>>
>> That said, I am not against supporting other options as long as we can
>> make the default fairly easy.
>>
> Paul, Mark and Bert,
>
> Please check attached patch. I've implemented the same behavior as
> *nix system which is described in build\ac-macros\sqlite.m4:
> [[[
> If a --with-sqlite=PREFIX option is passed, look for a suitable sqlite
> either installed under the directory PREFIX or as an amalgamation file
> at the path PREFIX. In this case ignore any sqlite-amalgamation/ subdir
> within the source tree.
>
> If no --with-sqlite option is passed, look first for
> sqlite-amalgamation/sqlite3.c which should be the amalgamated version of
> the source distribution. If the amalgamation exists and is the wrong
> version, exit with a failure. If no sqlite-amalgamation/ subdir is
> present, search for a sqlite installed on the system.
> ]]]
>
> So existing builds should not be broken with this patch. While simple
> point --with-sqlite to directory with SQLite amalgamation directory or
> putting it to directory sqlite-amalgamation should be enough to build
> Subversion.
>
> Log message:
> [[[
> Add support to build and use SQLite amalgamation version on Windows.
^^^
> This implements the same behavior as *nix build system does.
Ivan,
This is supposed to *build* sqlite if I point --with-sqlite to a
directory containing the amalgamation files right? Because no matter
where I put the amalgamation the build fails for me because
sqlite3.lib is not created:
(If this is working for you I suspect you are picking up some existing
sqlite.lib)
C:\SVN\src-trunk>dir \SVN\sqlite3.6.10.FLAT
Volume in drive C has no label.
Volume Serial Number is 3037-EF67
Directory of C:\SVN\sqlite3.6.10.FLAT
02/18/2009 01:38 PM <DIR> .
02/18/2009 01:38 PM <DIR> ..
11/19/2008 01:13 PM 60,350 shell.c
01/15/2009 11:10 AM 3,508,892 sqlite3.c
01/15/2009 11:10 AM 312,953 sqlite3.h
01/15/2009 11:11 AM 20,754 sqlite3ext.h
4 File(s) 3,902,949 bytes
2 Dir(s) 32,294,293,504 bytes free
C:\SVN\src-trunk>gen-make.py -t vcproj --vsnet-version=2008
--with-httpd=C:\SVN\httpd-2.2.10 --with-openssl=C:\SVN\openssl
--with-berkeley-db=C:\SVN\bdb --with-apr=C:\SVN\httpd-2.2
.10\srclib\apr --with-apr-util=C:\SVN\httpd-2.2.10\srclib\apr-util
--with-zlib=C:\SVN\zlib --enable-bdb-in-apr-util
--with-serf=C:\SVN\serf --with-swig=C:\SVN\swig --with-junit="C:
\Program Files\Java\jdk1.6.0_07\jre\lib\ext\junit-4.4.jar"
--with-sqlite=C:\SVN\sqlite3.6.10.FLAT
build\generator\gen_vcnet_vcproj.py:6: DeprecationWarning: the md5
module is deprecated; use hashlib instead
import md5
Found libdb47.lib in C:\SVN\bdb
Generating for VS.NET 2008
Could not detect Ruby version.
Ruby bindings will be linked with msvcrt-ruby18.lib
Found installed perl version number.
Perl bindings will be linked with perl510.lib
Found installed SWIG version 1.3.36
Using SWIG library directory C:\SVN\swig\Lib
Found JDK version 1.6 in C:\Program Files\Java\jdk1.6.0_07
Found SQLite version 3.6.10
Found neon version 0.28.2
Wrote: build\win32\build_zlib.bat
Wrote: build\win32\build_locale.bat
WARNING: "Winver.h" header not found, file
subversion\libsvn_subr\win32_crashrpt.c
Wrote: build\win32\svn_config.vcproj
Wrote: build\win32\svn_locale.vcproj
Wrote: build\win32\zlib.vcproj
Wrote: neon\neon.vcproj
Wrote: build\win32\vcnet-vcproj\__ALL_TESTS___vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\__ALL___vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\__JAVAHL___vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\__LIBS___vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\__SWIG_PERL___vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\__SWIG_PYTHON___vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\__SWIG_RUBY___vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_auth_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_cache_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_changes_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_checksum_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_client_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_compat_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_config_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\diff_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_diff_diff3_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\diff3_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\diff4_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_dirent_uri_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_error_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_fs_base_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_fs_pack_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_fs_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_hashdump_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\javahl_java_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\javahl_javah_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_javahl_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_key_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvn_client_dll_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvn_delta_dll_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvn_diff_dll_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvn_fs_dll_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvn_fs_base_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvn_fs_fs_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvn_fs_util_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvn_ra_dll_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvn_ra_local_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvn_ra_neon_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvn_ra_serf_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvn_ra_svn_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvn_repos_dll_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvn_subr_dll_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvn_swig_perl_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvn_swig_py_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvn_swig_ruby_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvn_test_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvn_wc_dll_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvnjavahl_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_locks_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_mergeinfo_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\mod_authz_svn_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\mod_dav_svn_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_opt_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_path_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\swig_perl_client_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\swig_perl_core_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\swig_perl_delta_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\swig_perl_diff_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\swig_perl_fs_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\swig_perl_ra_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\swig_perl_repos_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\swig_perl_wc_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\swig_python_client_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\swig_python_core_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\swig_python_delta_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\swig_python_diff_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\swig_python_fs_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\swig_python_ra_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\swig_python_repos_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\swig_python_wc_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_ra_local_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_random_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_repos_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_revision_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\swig_ruby_client_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\swig_ruby_core_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\swig_ruby_delta_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\swig_ruby_diff_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\swig_ruby_fs_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\swig_ruby_ra_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\swig_ruby_repos_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\swig_ruby_wc_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_skel_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_stream_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_string_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_strings_reps_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\svn_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\svn_populate_node_origins_index_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\svn_push_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvn_client_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvn_delta_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvn_diff_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvn_fs_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvn_ra_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvn_repos_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvn_subr_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\libsvn_wc_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\svnadmin_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\svnauthz_validate_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_svndiff_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\svndumpfilter_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\svnlook_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\svnmucc_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\svnserve_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\svnsync_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\svnversion_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_target_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_time_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_translate_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_tree_conflict_data_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_utf_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_vdelta_vcnet.vcproj
Wrote: build\win32\vcnet-vcproj\test_window_vcnet.vcproj
Wrote: subversion_vcnet.sln
C:\SVN\src-trunk>msbuild subversion_vcnet.sln /t:__ALL_TESTS__
/p:Configuration=Debug
Microsoft (R) Build Engine Version 3.5.21022.8
[Microsoft .NET Framework, Version 2.0.50727.1433]
Copyright (C) Microsoft Corporation 2007. All rights reserved.
Build started 2/18/2009 2:09:09 PM.
Project "C:\SVN\src-trunk\subversion_vcnet.sln" on node 0
(__ALL_TESTS__ target(s)).
Building solution configuration "Debug|Win32".
..\..\..\subversion\libsvn_subr\cache-memcache.c(374): warning C4244:
'=' : conversion from 'int' to 'apr_uint16_t', possible loss of data
..\..\..\subversion\libsvn_subr\config.c(350): warning C4244: '=' :
conversion from 'int' to 'char', possible loss of data
..\..\..\subversion\libsvn_subr\config_file.c(159): warning C4244:
'initializing' : conversion from 'int' to 'const char', possible loss
of data
..\..\..\subversion\libsvn_subr\config_file.c(215): warning C4244:
'initializing' : conversion from 'int' to 'const char', possible loss
of data
..\..\..\subversion\libsvn_subr\config_file.c(243): warning C4244:
'initializing' : conversion from 'int' to 'const char', possible loss
of data
..\..\..\subversion\libsvn_subr\config_file.c(286): warning C4244:
'initializing' : conversion from 'int' to 'const char', possible loss
of data
..\..\..\subversion\libsvn_subr\config_win.c(128): warning C4057:
'function' : 'LPBYTE' differs in indirection to slightly different
base types from 'char *'
..\..\..\subversion\libsvn_subr\config_win.c(133): warning C4057:
'function' : 'LPBYTE' differs in indirection to slightly different
base types from 'char *'
c:\svn\src-trunk\subversion\libsvn_subr\error.c(71): warning C4716:
'err_abort' : must return a value
..\..\..\subversion\libsvn_subr\quoprint.c(231): warning C4244: '=' :
conversion from 'int' to 'char', possible loss of data
C:\SVN\sqlite3.6.10.FLAT\sqlite3.c(32587): warning C4244: '=' :
conversion from 'i64' to 'u32', possible loss of data
C:\SVN\sqlite3.6.10.FLAT\sqlite3.c(32815): warning C4018: '<' :
signed/unsigned mismatch
C:\SVN\sqlite3.6.10.FLAT\sqlite3.c(41060): warning C4244: '-=' :
conversion from 'int' to 'u16', possible loss of data
C:\SVN\sqlite3.6.10.FLAT\sqlite3.c(82589): warning C4244: '=' :
conversion from 'int' to 'u8', possible loss of data
C:\SVN\sqlite3.6.10.FLAT\sqlite3.c(85889): warning C4244: '=' :
conversion from 'int' to 'unsigned short', possible loss of data
C:\SVN\sqlite3.6.10.FLAT\sqlite3.c(85890): warning C4244: '=' :
conversion from 'int' to 'unsigned char', possible loss of data
c:\svn\src-trunk\subversion\libsvn_subr\prompt.c(59): warning C4702:
unreachable code
c:\svn\src-trunk\subversion\libsvn_subr\prompt.c(66): warning C4702:
unreachable code
c:\svn\src-trunk\subversion\libsvn_subr\prompt.c(67): warning C4702:
unreachable code
c:\svn\src-trunk\subversion\libsvn_subr\prompt.c(69): warning C4702:
unreachable code
c:\svn\src-trunk\subversion\libsvn_subr\pool.c(50): warning C4716:
'abort_on_pool_failure' : must return a value
..\..\..\subversion\libsvn_subr\win32_crypto.c(70): warning C4057:
'function' : 'const char *' differs in indirection to slightly
different base types from 'BYTE *'
..\..\..\subversion\libsvn_subr\win32_crypto.c(104): warning C4057:
'function' : 'char *' differs in indirection to slightly different
base types from 'BYTE *'
..\..\..\subversion\libsvn_subr\win32_crypto.c(110): warning C4057:
'function' : 'const char *' differs in indirection to slightly
different base types from 'BYTE *'
..\..\..\subversion\libsvn_subr\win32_crypto.c(204): warning C4057:
'function' : 'const char *' differs in indirection to slightly
different base types from 'BYTE *'
..\..\..\subversion\libsvn_subr\win32_crypto.c(238): warning C4057:
'function' : 'char *' differs in indirection to slightly different
base types from 'BYTE *'
..\..\..\subversion\libsvn_subr\win32_crypto.c(244): warning C4057:
'function' : 'const char *' differs in indirection to slightly
different base types from 'BYTE *'
..\..\..\subversion\libsvn_subr\win32_crypto.c(344): warning C4057:
'function' : 'const BYTE *' differs in indirection to slightly
different base types from 'char *'
Deleting file
"C:\SVN\src-trunk\build\win32\vcnet-vcproj\libsvn_subr_vcnet.tmp_Debug_Win32.vcproj".
Libraries\zlib:
Deleting file "C:\SVN\src-trunk\build\win32\zlib.tmp_Debug_Win32.vcproj".
C:\SVN\src-trunk\subversion_vcnet.sln : warning MSB3422: Failed to
retrieve VC project information through the VC project engine object
model. Unable to determine default tool for
the specified file configuration.
C:\SVN\src-trunk\subversion_vcnet.sln : warning MSB3425: Could not
resolve VC project reference
"C:\SVN\src-trunk\build\win32\zlib.vcproj".
..\empty.c(3): warning C4206: nonstandard extension used : translation
unit is empty
LINK : fatal error LNK1104: cannot open file 'sqlite3.lib'
Done Building Project "C:\SVN\src-trunk\subversion_vcnet.sln"
(__ALL_TESTS__ target(s)) -- FAILED.
Build FAILED.
"C:\SVN\src-trunk\subversion_vcnet.sln" (__ALL_TESTS__ target) (1) ->
(Libraries\svn_subr target) ->
..\..\..\subversion\libsvn_subr\cache-memcache.c(374): warning
C4244: '=' : conversion from 'int' to 'apr_uint16_t', possible loss of
data
..\..\..\subversion\libsvn_subr\config.c(350): warning C4244: '=' :
conversion from 'int' to 'char', possible loss of data
..\..\..\subversion\libsvn_subr\config_file.c(159): warning C4244:
'initializing' : conversion from 'int' to 'const char', possible loss
of data
..\..\..\subversion\libsvn_subr\config_file.c(215): warning C4244:
'initializing' : conversion from 'int' to 'const char', possible loss
of data
..\..\..\subversion\libsvn_subr\config_file.c(243): warning C4244:
'initializing' : conversion from 'int' to 'const char', possible loss
of data
..\..\..\subversion\libsvn_subr\config_file.c(286): warning C4244:
'initializing' : conversion from 'int' to 'const char', possible loss
of data
..\..\..\subversion\libsvn_subr\config_win.c(128): warning C4057:
'function' : 'LPBYTE' differs in indirection to slightly different
base types from 'char *'
..\..\..\subversion\libsvn_subr\config_win.c(133): warning C4057:
'function' : 'LPBYTE' differs in indirection to slightly different
base types from 'char *'
c:\svn\src-trunk\subversion\libsvn_subr\error.c(71): warning C4716:
'err_abort' : must return a value
..\..\..\subversion\libsvn_subr\quoprint.c(231): warning C4244: '='
: conversion from 'int' to 'char', possible loss of data
C:\SVN\sqlite3.6.10.FLAT\sqlite3.c(32587): warning C4244: '=' :
conversion from 'i64' to 'u32', possible loss of data
C:\SVN\sqlite3.6.10.FLAT\sqlite3.c(32815): warning C4018: '<' :
signed/unsigned mismatch
C:\SVN\sqlite3.6.10.FLAT\sqlite3.c(41060): warning C4244: '-=' :
conversion from 'int' to 'u16', possible loss of data
C:\SVN\sqlite3.6.10.FLAT\sqlite3.c(82589): warning C4244: '=' :
conversion from 'int' to 'u8', possible loss of data
C:\SVN\sqlite3.6.10.FLAT\sqlite3.c(85889): warning C4244: '=' :
conversion from 'int' to 'unsigned short', possible loss of data
C:\SVN\sqlite3.6.10.FLAT\sqlite3.c(85890): warning C4244: '=' :
conversion from 'int' to 'unsigned char', possible loss of data
c:\svn\src-trunk\subversion\libsvn_subr\prompt.c(59): warning C4702:
unreachable code
c:\svn\src-trunk\subversion\libsvn_subr\prompt.c(66): warning C4702:
unreachable code
c:\svn\src-trunk\subversion\libsvn_subr\prompt.c(67): warning C4702:
unreachable code
c:\svn\src-trunk\subversion\libsvn_subr\prompt.c(69): warning C4702:
unreachable code
c:\svn\src-trunk\subversion\libsvn_subr\pool.c(50): warning C4716:
'abort_on_pool_failure' : must return a value
..\..\..\subversion\libsvn_subr\win32_crypto.c(70): warning C4057:
'function' : 'const char *' differs in indirection to slightly
different base types from 'BYTE *'
..\..\..\subversion\libsvn_subr\win32_crypto.c(104): warning C4057:
'function' : 'char *' differs in indirection to slightly different
base types from 'BYTE *'
..\..\..\subversion\libsvn_subr\win32_crypto.c(110): warning C4057:
'function' : 'const char *' differs in indirection to slightly
different base types from 'BYTE *'
..\..\..\subversion\libsvn_subr\win32_crypto.c(204): warning C4057:
'function' : 'const char *' differs in indirection to slightly
different base types from 'BYTE *'
..\..\..\subversion\libsvn_subr\win32_crypto.c(238): warning C4057:
'function' : 'char *' differs in indirection to slightly different
base types from 'BYTE *'
..\..\..\subversion\libsvn_subr\win32_crypto.c(244): warning C4057:
'function' : 'const char *' differs in indirection to slightly
different base types from 'BYTE *'
..\..\..\subversion\libsvn_subr\win32_crypto.c(344): warning C4057:
'function' : 'const BYTE *' differs in indirection to slightly
different base types from 'char *'
"C:\SVN\src-trunk\subversion_vcnet.sln" (__ALL_TESTS__ target) (1) ->
(Libraries\Dlls\libsvn_subr target) ->
C:\SVN\src-trunk\subversion_vcnet.sln : warning MSB3422: Failed to
retrieve VC project information through the VC project engine object
model. Unable to determine default tool f
or the specified file configuration.
C:\SVN\src-trunk\subversion_vcnet.sln : warning MSB3425: Could not
resolve VC project reference
"C:\SVN\src-trunk\build\win32\zlib.vcproj".
..\empty.c(3): warning C4206: nonstandard extension used :
translation unit is empty
"C:\SVN\src-trunk\subversion_vcnet.sln" (__ALL_TESTS__ target) (1) ->
(Libraries\Dlls\libsvn_subr target) ->
LINK : fatal error LNK1104: cannot open file 'sqlite3.lib'
31 Warning(s)
1 Error(s)
Time Elapsed 00:00:23.20
C:\SVN\src-trunk>
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1187699
Re: Attn: Windows Devs -- Need to add missing sqlite build options
for Windows (issue #3364)
Posted by Ivan Zhakov <iv...@visualsvn.com>.
On Wed, Feb 18, 2009 at 7:08 PM, Mark Phippard <ma...@gmail.com> wrote:
> On Wed, Feb 18, 2009 at 11:02 AM, Bert Huijben <rh...@sharpsvn.net> wrote:
>> Is it a problem to just keep the current build option?
>> (+1 on making the amalgamation default on Windows)
>>
>> The amalgamation build makes it impossible to re-use Sqlite from
>> applications that use both Subversion and Sqlite (Requiring them to link to
>> two separate copies).
>
> That said, I am not against supporting other options as long as we can
> make the default fairly easy.
>
Paul, Mark and Bert,
Please check attached patch. I've implemented the same behavior as
*nix system which is described in build\ac-macros\sqlite.m4:
[[[
If a --with-sqlite=PREFIX option is passed, look for a suitable sqlite
either installed under the directory PREFIX or as an amalgamation file
at the path PREFIX. In this case ignore any sqlite-amalgamation/ subdir
within the source tree.
If no --with-sqlite option is passed, look first for
sqlite-amalgamation/sqlite3.c which should be the amalgamated version of
the source distribution. If the amalgamation exists and is the wrong
version, exit with a failure. If no sqlite-amalgamation/ subdir is
present, search for a sqlite installed on the system.
]]]
So existing builds should not be broken with this patch. While simple
point --with-sqlite to directory with SQLite amalgamation directory or
putting it to directory sqlite-amalgamation should be enough to build
Subversion.
Log message:
[[[
Add support to build and use SQLite amalgamation version on Windows.
This implements the same behavior as *nix build system does.
* build/generator/gen_win.py
(parse_options): set self.sqlite_path to sqlite-amalgamation
directory if --with-sqlite
parameter not specified.
(get_win_defines): Add SVN_SQLITE_INLINE define in SQLite amalgamation used.
(get_win_includes,get_win_lib_dirs): Use headers and libraries from
correct location if
SQLite amalgamation used.
(_find_sqlite): Try SQLite amalgamation if compiled SQLite not found
in specified
location.
]]]
Testing is very appreciated.
--
Ivan Zhakov
VisualSVN Team
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1186952
Re: Attn: Windows Devs -- Need to add missing sqlite build options
for Windows (issue #3364)
Posted by Mark Phippard <ma...@gmail.com>.
On Wed, Feb 18, 2009 at 11:02 AM, Bert Huijben <rh...@sharpsvn.net> wrote:
> Is it a problem to just keep the current build option?
> (+1 on making the amalgamation default on Windows)
>
> The amalgamation build makes it impossible to re-use Sqlite from
> applications that use both Subversion and Sqlite (Requiring them to link to
> two separate copies).
Do we really want to support that? I'd assume for example, we do not
want application to use SQLite to directly access whatever database we
are using. So the only issue would be a client that uses Subversion
and also uses SQLite for its own datastore. In that scenario,
assuming it exists, is it so bad for the application to use another
SQLite for that purpose?
That said, I am not against supporting other options as long as we can
make the default fairly easy.
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1186770
RE: Attn: Windows Devs -- Need to add missing sqlite build options
for Windows (issue #3364)
Posted by Bert Huijben <rh...@sharpsvn.net>.
[Resending this mail as it didn't seem to reach the list or its other
recipients]
> -----Original Message-----
> From: chemodax@gmail.com [mailto:chemodax@gmail.com] On Behalf Of Ivan
Zhakov
> Sent: woensdag 18 februari 2009 14:43
> To: Paul Burba
> Cc: dev@subversion.tigris.org
> Subject: Re: Attn: Windows Devs -- Need to add missing sqlite build
options
> for Windows (issue #3364)
>
> On Thu, Jan 29, 2009 at 7:19 AM, Paul Burba <pt...@gmail.com> wrote:
> > Right now when building trunk on Windows you have one option when it
> > comes to sqlite: Use the --with-sqlite option to gen-make.py to point
> > to a directory with this structure and contents:
> >
> > inc/
> > inc/sqlite3.h
> > lib/
> > lib/sqlite3.lib
> >
> > So basically, if you haven't built sqlite on your own already then
> > Subversion won't build. It seems to me we should support sqlite build
> > options analogous to those on *nix, e.g. just drop the amalgamation
> > files in .\sqlite-amalgamation and it gets built.
> >
> Hi Paul,
>
> Thanks for noting that. I've looked to current sqlite build stuff on
> Windows. It still does not support sqlite-amalgamation.
>
> So I propose to implement only amalgamation option for sqlite, without
> supporting to use "installed" version of library. Since there is no
> term of installed libraries on Windows. I do not see benefits of using
> sqlite compiled out of source tree on Windows. It can be only source
> of problems if different compiler or compiler options will be used.
>
> I volunteer to implement support for sqlite amalgamation on Windows,
> if no one object to drop other sqlite build option on Windows.
Is it a problem to just keep the current build option?
(+1 on making the amalgamation default on Windows)
The amalgamation build makes it impossible to re-use Sqlite from
applications that use both Subversion and Sqlite (Requiring them to link to
two separate copies).
The current method works for at least my automated build and TortoiseSVN's,
so why break it?
Bert
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1186753
Re: Attn: Windows Devs -- Need to add missing sqlite build options
for Windows (issue #3364)
Posted by Ivan Zhakov <iv...@visualsvn.com>.
On Thu, Jan 29, 2009 at 7:19 AM, Paul Burba <pt...@gmail.com> wrote:
> Right now when building trunk on Windows you have one option when it
> comes to sqlite: Use the --with-sqlite option to gen-make.py to point
> to a directory with this structure and contents:
>
> inc/
> inc/sqlite3.h
> lib/
> lib/sqlite3.lib
>
> So basically, if you haven't built sqlite on your own already then
> Subversion won't build. It seems to me we should support sqlite build
> options analogous to those on *nix, e.g. just drop the amalgamation
> files in .\sqlite-amalgamation and it gets built.
>
Hi Paul,
Thanks for noting that. I've looked to current sqlite build stuff on
Windows. It still does not support sqlite-amalgamation.
So I propose to implement only amalgamation option for sqlite, without
supporting to use "installed" version of library. Since there is no
term of installed libraries on Windows. I do not see benefits of using
sqlite compiled out of source tree on Windows. It can be only source
of problems if different compiler or compiler options will be used.
I volunteer to implement support for sqlite amalgamation on Windows,
if no one object to drop other sqlite build option on Windows.
--
Ivan Zhakov
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1185981