You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by "craigcondit (via GitHub)" <gi...@apache.org> on 2023/05/23 15:26:08 UTC

[GitHub] [yunikorn-k8shim] craigcondit commented on pull request #595: [YUNIKORN-1746] Improve the performance of nodeInfoListerImpl.List()

craigcondit commented on PR #595:
URL: https://github.com/apache/yunikorn-k8shim/pull/595#issuecomment-1559664951

   Had a conversation offline about this. I'd like to see the caching logic encapsulated completely within the SchedulerCache object. We can add a GetNodeList() method that returns the list, and cache the list inside the SchedulerCache itself. If the pointer to that list is nil, then assume it is invalid. Then we compute it on demand in GetNodeList(), and set to nil any time the node map is modified. Finally, update the NodeLister to call GetNodeList() instead of the GetNodesInfoMap().


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org