[GitHub] [camel-quarkus] ppalaga commented on a diff in pull request #4653: Cxf-soap: Extend test coverage with Converter scenario #4652

["ppalaga (via GitHub)" <gi...@apache.org>]

ppalaga commented on code in PR #4653:
URL: https://github.com/apache/camel-quarkus/pull/4653#discussion_r1138699136


##########
integration-tests/cxf-soap-grouped/pom.xml:
##########
@@ -72,6 +72,10 @@
             <groupId>io.quarkus</groupId>
             <artifactId>quarkus-resteasy</artifactId>
         </dependency>
+        <dependency>
+            <groupId>org.apache.camel.quarkus</groupId>
+            <artifactId>camel-quarkus-jaxb</artifactId>
+        </dependency>

Review Comment:
   That's a good question. I'd say it depends on which kind of errors you saw. If camel-quarkus-jaxb just adds some conveniece converters so that expressions like `exchange.getIn().getBody(GetPerson.class)` work flawlessly, then I'd say it is not a pure camel-cxf use case and it should stay up to the user to add camel-quarkus-jaxb manually.
   If the error bubbles up from some pure camel-cxf code, then we need to take a precise look whether it is a bug in camel-quarkus-cxf or even in quarkus-cxf. 
   
   BTW, does the CSB test you are porting depend on camel-jaxb?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org