You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Ian Cook (Jira)" <ji...@apache.org> on 2021/05/04 13:02:00 UTC
[jira] [Comment Edited] (ARROW-12640) [C++] Fix errors from VS 2019
in cpp/src/parquet/types.h
[ https://issues.apache.org/jira/browse/ARROW-12640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338621#comment-17338621 ]
Ian Cook edited comment on ARROW-12640 at 5/4/21, 1:01 PM:
-----------------------------------------------------------
Ah, ok. Then I'll just add this below the includes:
{code:c++}
#ifdef _WIN32
// parquet.thrift's OPTIONAL RepetitionType conflicts with a #define from
// above, so we undefine it
#ifdef OPTIONAL
#undef OPTIONAL
#endif
#endif {code}
was (Author: icook):
Ah, ok. Then I'll just add this immediately below {{#pragma once}}:
{code:c++}
#ifdef _WIN32
// parquet.thrift's OPTIONAL RepetitionType conflicts with a #define from
// above, so we undefine it
#ifdef OPTIONAL
#undef OPTIONAL
#endif
#endif {code}
> [C++] Fix errors from VS 2019 in cpp/src/parquet/types.h
> --------------------------------------------------------
>
> Key: ARROW-12640
> URL: https://issues.apache.org/jira/browse/ARROW-12640
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: Ian Cook
> Assignee: Ian Cook
> Priority: Major
> Labels: pull-request-available
> Fix For: 5.0.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> On April 30, a nightly CI job that builds libarrow with Visual Studio 2019 ({{test-build-vcpkg-win}}) started failing because of numerous syntax errors:
> {code:java}
> D:\a\crossbow\crossbow\arrow\cpp\src\parquet/types.h(115,38): error C2143: syntax error: missing '}' before '=' [D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\dataset\arrow_dataset_shared.vcxproj]
> 4423D:\a\crossbow\crossbow\arrow\cpp\src\parquet/types.h(115,38): error C2059: syntax error: '=' [D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\dataset\arrow_dataset_shared.vcxproj]
> 4424D:\a\crossbow\crossbow\arrow\cpp\src\parquet/types.h(115,87): error C2143: syntax error: missing ';' before '}' [D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\dataset\arrow_dataset_shared.vcxproj]
> 4425D:\a\crossbow\crossbow\arrow\cpp\src\parquet/types.h(115,87): error C2238: unexpected token(s) preceding ';' [D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\dataset\arrow_dataset_shared.vcxproj]
> 4426D:\a\crossbow\crossbow\arrow\cpp\src\parquet/types.h(173,22): error C2039: 'schema': is not a member of 'parquet' [D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\dataset\arrow_dataset_shared.vcxproj]
> 4427D:\a\crossbow\crossbow\arrow\cpp\src\parquet/types.h(40): message : see declaration of 'parquet' [D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\dataset\arrow_dataset_shared.vcxproj]
> 4428D:\a\crossbow\crossbow\arrow\cpp\src\parquet/types.h(173,22): error C3083: 'schema': the symbol to the left of a '::' must be a type [D:\a\crossbow\crossbow\arrow\cpp\build\src\arrow\dataset\arrow_dataset_shared.vcxproj]
> 4429D:\a\crossbow\crossbow\arrow\cpp\src\parquet/types.h(173,30): error C2039: 'DecimalMetadata': is not a member of 'parquet' {code}
> See full log at [https://github.com/ursacomputing/crossbow/runs/2473230854#step:4:4422]
> [~bkietz] [~davidli] I am almost certain that this was caused by ARROW-11929
> PR: [https://github.com/apache/arrow/pull/10166]
> Commit: [https://github.com/apache/arrow/commit/7430bbdfcda5d23cf18d7222da8419eb594d9f3f]
> When I check out the commit immediately before this one, the build succeeds without these errors. When I check out this commit, the build shows these errors.
> I believe the issue is not directly related to vcpkg. It happens also when I use conda for dependencies. It seems to be related to Visual Studio 2019.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)