You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "acassis (via GitHub)" <gi...@apache.org> on 2023/08/31 13:33:52 UTC

[GitHub] [nuttx] acassis commented on a diff in pull request #10457: APDS9922 - add compiler warning if spinlock not enabled

acassis commented on code in PR #10457:
URL: https://github.com/apache/nuttx/pull/10457#discussion_r1311640744


##########
drivers/sensors/apds9922.c:
##########
@@ -48,6 +48,10 @@
  * Pre-process Definitions
  ****************************************************************************/
 
+#ifndef CONFIG_SPINLOCK
+#  warning Spinlock should be enabled if light AND proximity detection wanted

Review Comment:
   ```suggestion
   #  warning Spinlock (CONFIG_SPINLOCK) should be enabled if light AND proximity detection wanted
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org