[PATCH] More _() added

[Nicolás Lichtmaier <ni...@reloco.com.ar>]

Here's another round of _()'s added everywhere.

Re: [PATCH] More _() added

[John Peacock <jp...@rowman.com>]

Erik Huelsmann wrote:
> 3) You have wrapped over long lines nicely, but could you please indent them
> differently? Here's an example from your diff:
> 
> -       "Failed to add directory '%s': object of the same name already
> exists",
> -       db->path);
> +       _("Failed to add directory '%s': object of the same name "
> +       "already exists"), db->path);
> 
> should be indented:
> +       _("Failed to add directory '%s': object of the same name "
> +         "already exists"), db->path);
> 

Just as a reminder, there are editor macros which make the indenting for this 
project much easier to handle (i.e. you don't have to think about them).

for emacs - tools/dev/svn-dev.el
for vim - tools/dev/svn-dev.vim

HTH

John

-- 
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4720 Boston Way
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5747

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] More _() added

[Erik Huelsmann <e....@gmx.net>]

Hi Nicolas,

> Here's another round of _()'s added everywhere.

I shortly reviewed this patch (as I am still working on the indenting from
your last one), but have a few remarks:

1) could you provide a log message conforming to conventions described in
HACKING please?
2) your "added everywhere" above means that this is the last one? Or did you
work on a per library basis and is this everywhere for the next few
libraries? (Something to document in your log messag)
3) You have wrapped over long lines nicely, but could you please indent them
differently? Here's an example from your diff:

-       "Failed to add directory '%s': object of the same name already
exists",
-       db->path);
+       _("Failed to add directory '%s': object of the same name "
+       "already exists"), db->path);

should be indented:
+       _("Failed to add directory '%s': object of the same name "
+         "already exists"), db->path);


Thanks in advance!

bye,

Erik.

-- 
NEU : GMX Internet.FreeDSL
Ab sofort DSL-Tarif ohne Grundgebühr: http://www.gmx.net/info


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org