You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2023/10/07 06:57:13 UTC
Re: [PR] [SPARK-45439][SQL][UI] Reduce memory usage of LiveStageMetrics.accumIdsToMetricType [spark]
beliefer commented on code in PR #43250:
URL: https://github.com/apache/spark/pull/43250#discussion_r1349475794
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListener.scala:
##########
@@ -490,7 +490,12 @@ private class LiveExecutionData(val executionId: Long) extends LiveEntity {
var details: String = null
var physicalPlanDescription: String = null
var modifiedConfigs: Map[String, String] = _
- var metrics = collection.Seq[SQLPlanMetric]()
+ private var _metrics = collection.Seq[SQLPlanMetric]()
+ def metrics: collection.Seq[SQLPlanMetric] = _metrics
+ // This mapping is shared across all LiveStageMetrics instances associated with
+ // this LiveExecutionData, helping to reduce memory overhead by avoiding waste
+ // from separate immutable maps with largely overlapping sets of entries.
+ val metricAccumulatorIdToMetricType = new ConcurrentHashMap[Long, String]()
Review Comment:
AFAIK, SQLAppStatusListener only works in single thread. Should we only use Map here? please tell me detail if I thought missing something.
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListener.scala:
##########
@@ -490,7 +490,12 @@ private class LiveExecutionData(val executionId: Long) extends LiveEntity {
var details: String = null
var physicalPlanDescription: String = null
var modifiedConfigs: Map[String, String] = _
- var metrics = collection.Seq[SQLPlanMetric]()
+ private var _metrics = collection.Seq[SQLPlanMetric]()
+ def metrics: collection.Seq[SQLPlanMetric] = _metrics
+ // This mapping is shared across all LiveStageMetrics instances associated with
+ // this LiveExecutionData, helping to reduce memory overhead by avoiding waste
+ // from separate immutable maps with largely overlapping sets of entries.
+ val metricAccumulatorIdToMetricType = new ConcurrentHashMap[Long, String]()
Review Comment:
AFAIK, `SQLAppStatusListener` only works in single thread. Should we only use Map here? please tell me detail if I thought missing something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org