You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2009/11/06 23:46:32 UTC

[jira] Updated: (ZOOKEEPER-551) unnecessary SetWatches message on new session

     [ https://issues.apache.org/jira/browse/ZOOKEEPER-551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-551:
-----------------------------------

    Attachment: ZOOKEEPER-551.patch

This patch changes the c/java code to not send setwatches message if there are no pending watches.

I don't see how to neg test this - we are already verifying the positive cases so failure for hadoopqa should be expected but I think that's ok.


> unnecessary SetWatches message on new session
> ---------------------------------------------
>
>                 Key: ZOOKEEPER-551
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-551
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client, java client
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Priority: Minor
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-551.patch
>
>
> The java client is sending a SetWatches message even on a new session (always empty). Additionally SetWatches is called
> even in the case of re-establishing session, however no watches are set. The code should check for watches before
> sending this (ie don't send empty setwatches). I see this on java, investigate c as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.