You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/09/16 07:19:38 UTC

[GitHub] [incubator-dolphinscheduler] gaojun2048 commented on pull request #3601: [Feature-3189][alert,spi,dao,plugin-api] base code of dolphinscheduler spi and alert plugin implement

gaojun2048 commented on pull request #3601:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3601#issuecomment-693223122


   > SonarCloud Code Analysis not pass . please resolve
   > +1
   
   I run the ut covered in IDEA the result is this:
   
   org.apache.dolphinscheduler.alert | 57% (11/19) | 62% (65/104) | 48% (274/563)
   -- | -- | -- | --
   org.apache.dolphinscheduler.plugin.alert | 63% (7/11) | 64% (22/34) | 69% (245/351)
   org.apache.dolphinscheduler.spi | 65% (19/29) | 58% (82/139) | 56% (181/323)
   
   
   ![image](https://user-images.githubusercontent.com/32193458/93304589-d2158b00-f82f-11ea-857a-03f484d05d35.png)
   
   
   And I mainly changed these codes. Part of the code in pr is related to checkstyle. I did not write ut for this part of the code.
   
   But the SonarCloud / SonarCloud Code Analysis result is `Failed condition 0.0% Condition Coverage on New Code (is less than 33%)` ,why ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org