You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/05/13 02:12:17 UTC
[kudu-CR] log: use iterator interface for reading log while rebuilding footer
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3057
to review the following change.
Change subject: log: use iterator interface for reading log while rebuilding footer
......................................................................
log: use iterator interface for reading log while rebuilding footer
We no longer read all of the entries in the segment into memory,
but rather process them one by one. This should improve performance
of this operation a little bit, but more importantly, it allows
us to remove some complexity from the ReadEntries() function.
Change-Id: Ic0547f43ba741a8f189fd0419319b17725d64f95
---
M src/kudu/consensus/log.cc
M src/kudu/consensus/log.h
M src/kudu/consensus/log_util.cc
M src/kudu/consensus/log_util.h
4 files changed, 39 insertions(+), 50 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/3057/1
--
To view, visit http://gerrit.cloudera.org:8080/3057
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0547f43ba741a8f189fd0419319b17725d64f95
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>