You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Michael Dürig (JIRA)" <ji...@apache.org> on 2014/09/16 15:38:33 UTC

[jira] [Commented] (OAK-2100) Change NodeStore#release method to return a boolean

    [ https://issues.apache.org/jira/browse/OAK-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14135431#comment-14135431 ] 

Michael Dürig commented on OAK-2100:
------------------------------------

Could you also add JavaDoc to {{NodeStore.release}}. I'm specifically unclear on what the return value should be for a non existing checkpoint. Depending on that the implementations in {{DocumentNodeStore}} and {{MemoryNodeStore}} need to be improved. 

Regarding the API change, I think this is fine in general. But we should probably increase the package version.

> Change NodeStore#release method to return a boolean
> ---------------------------------------------------
>
>                 Key: OAK-2100
>                 URL: https://issues.apache.org/jira/browse/OAK-2100
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, segmentmk
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>             Fix For: 1.1, 1.0.6
>
>         Attachments: OAK-2100.patch
>
>
> I'd like to change the #release method to return a boolean. This allows for better checkpoint management (also affects OAK-2088).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)