[GitHub] tinkerpop pull request #:

[aholmberg <gi...@git.apache.org>]

Github user aholmberg commented on the pull request:

    https://github.com/apache/tinkerpop/commit/6ed7edc0b4ad2abf933e917812d49ad92230c8d1#commitcomment-18473940
  
    In gremlin-variant/src/main/groovy/org/apache/tinkerpop/gremlin/python/GremlinPythonGenerator.groovy:
    In gremlin-variant/src/main/groovy/org/apache/tinkerpop/gremlin/python/GremlinPythonGenerator.groovy on line 95:
    May I suggest that we use a trailing, instead of leading underscore for keyword collisions? This would make it more natural to begin typing for completion. It would also adhere to Python style guidelines, which says leading underscore indicates private, internal use, and to use trailing underscores to avoid keyword collisions.
    https://www.python.org/dev/peps/pep-0008/#descriptive-naming-styles


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---