[GitHub] [incubator-shardingsphere] CalvinKirs commented on issue #2747: add Java Microbenchmark Harness

[GitBox <gi...@apache.org>]

CalvinKirs commented on issue #2747: add Java Microbenchmark Harness
URL: https://github.com/apache/incubator-shardingsphere/pull/2747#issuecomment-517610156
 
 
   > @CalvinKirs Just as @nancyzrh said, this PR only add a maven dependency for jmh, but does not add any test cases yet, so I think you need add test cases for that.
   > 
   > As my understanding, jmh only can print benchmark info to console which is not very make sense, we have already use jmeter to test benchmark.
   > 
   > The precondition for introduce jmh to ShardingSphere is we need to auto assert if benchmark is under threshold.
   
   I don't quite agree with your point of view. The existence is reasonable. The microcode test I think needs more lightweight JMH, not Jmeter. The level of action of the two is different. Using JMH will make our committers more convincing when submitting certain code. Of course, it may be my fault. I still want to hear your suggestions or suggestions from others.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services