You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/17 16:03:54 UTC

[GitHub] [tvm] driazati opened a new pull request, #12473: [ci] Re-balance shards

driazati opened a new pull request, #12473:
URL: https://github.com/apache/tvm/pull/12473

   This uses numbers from this script (link TBD) that determines the number of shards to use given a goal runtime (in this case 60 minutes for tests)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch merged pull request #12473: [ci] Re-balance shards

Posted by GitBox <gi...@apache.org>.
areusch merged PR #12473:
URL: https://github.com/apache/tvm/pull/12473


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] github-actions[bot] commented on pull request #12473: [ci] Re-balance shards

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12473:
URL: https://github.com/apache/tvm/pull/12473#issuecomment-1218336775

   <!---docs-bot-comment-->
   
   Built docs for commit 08eada156e77aea10ed93a7bd110d225c5dddd0c can be found [here](https://pr-docs.tlcpack.ai/PR-12473/1/docs/index.html).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] driazati commented on a diff in pull request #12473: [ci] Re-balance shards

Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #12473:
URL: https://github.com/apache/tvm/pull/12473#discussion_r964181884


##########
tests/scripts/setup-pytest-env.sh:
##########
@@ -74,17 +75,14 @@ function run_pytest() {
 
     suite_name="${test_suite_name}-${current_shard}-${ffi_type}"
 
-    # Some test environments don't play well with parallelism
-    DEFAULT_PARALLELISM=2
-    if [[ "${TEST_STEP_NAME:-default}" == "frontend: GPU"* ]] || [[ "${TEST_STEP_NAME:-default}" == "test: Hexagon"* ]]; then
-        DEFAULT_PARALLELISM=1
-    fi
+    DEFAULT_PARALLELISM=1

Review Comment:
   The n=2 wasn't actually being used (the `if` below was always failing) and caused some CI issues that should be resolved in a follow up



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] driazati commented on pull request #12473: [ci] Re-balance shards

Posted by GitBox <gi...@apache.org>.
driazati commented on PR #12473:
URL: https://github.com/apache/tvm/pull/12473#issuecomment-1239947525

   > neat! should we add rebalance instructions to monitoring rotation runbook?
   
   good idea, done in: https://github.com/apache/tvm/wiki/CI-Monitoring-Runbook#test-sharding


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org