You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kanak Biscuitwala <ka...@apache.org> on 2014/06/25 19:06:18 UTC

Review Request 22971: [HELIX-461] Add partitions without top state metric

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22971/
-----------------------------------------------------------

Review request for helix, Zhen Zhang and Kishore Gopalakrishna.


Bugs: HELIX-461


Repository: helix-git


Description
-------

commit 0474ee0eee238383b916d4031973d9c1d3dacd05
Author: Kanak Biscuitwala <ka...@apache.org>
Date:   Wed Jun 25 10:00:13 2014 -0700

    [HELIX-461] Add partitions without top state metric

:100644 100644 9097189... 27c2cdf... M	.gitignore
:100644 100644 f427f3d... ba1f2b5... M	helix-core/src/main/java/org/apache/helix/controller/stages/ExternalViewComputeStage.java
:100644 100644 eaccc18... a4eaae3... M	helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java
:100644 100644 284beef... 1313686... M	helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ResourceMonitor.java
:100644 100644 33b001d... da1e4f8... M	helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ResourceMonitorMBean.java
:100644 100644 652eb88... d1a7e1e... M	helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestResourceMonitor.java


Diffs
-----

  .gitignore 9097189 
  helix-core/src/main/java/org/apache/helix/controller/stages/ExternalViewComputeStage.java f427f3d 
  helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java eaccc18 
  helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ResourceMonitor.java 284beef 
  helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ResourceMonitorMBean.java 33b001d 
  helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestResourceMonitor.java 652eb88 

Diff: https://reviews.apache.org/r/22971/diff/


Testing
-------


Thanks,

Kanak Biscuitwala

Re: Review Request 22971: [HELIX-461] Add partitions without top state metric

Posted by Zhen Zhang <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22971/#review46654
-----------------------------------------------------------

Ship it!


Ship It!

- Zhen Zhang


On June 25, 2014, 5:06 p.m., Kanak Biscuitwala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22971/
> -----------------------------------------------------------
> 
> (Updated June 25, 2014, 5:06 p.m.)
> 
> 
> Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
> 
> 
> Bugs: HELIX-461
> 
> 
> Repository: helix-git
> 
> 
> Description
> -------
> 
> commit 0474ee0eee238383b916d4031973d9c1d3dacd05
> Author: Kanak Biscuitwala <ka...@apache.org>
> Date:   Wed Jun 25 10:00:13 2014 -0700
> 
>     [HELIX-461] Add partitions without top state metric
> 
> :100644 100644 9097189... 27c2cdf... M	.gitignore
> :100644 100644 f427f3d... ba1f2b5... M	helix-core/src/main/java/org/apache/helix/controller/stages/ExternalViewComputeStage.java
> :100644 100644 eaccc18... a4eaae3... M	helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java
> :100644 100644 284beef... 1313686... M	helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ResourceMonitor.java
> :100644 100644 33b001d... da1e4f8... M	helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ResourceMonitorMBean.java
> :100644 100644 652eb88... d1a7e1e... M	helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestResourceMonitor.java
> 
> 
> Diffs
> -----
> 
>   .gitignore 9097189 
>   helix-core/src/main/java/org/apache/helix/controller/stages/ExternalViewComputeStage.java f427f3d 
>   helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java eaccc18 
>   helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ResourceMonitor.java 284beef 
>   helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ResourceMonitorMBean.java 33b001d 
>   helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestResourceMonitor.java 652eb88 
> 
> Diff: https://reviews.apache.org/r/22971/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kanak Biscuitwala
> 
>