[jira] [Commented] (THRIFT-2857) C# generator creates uncompilable code for struct constants

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226419#comment-14226419 ] 

ASF GitHub Bot commented on THRIFT-2857:
----------------------------------------

GitHub user stigsb opened a pull request:

    https://github.com/apache/thrift/pull/289

    C# generator creates uncompilable code for struct constants

     C# constant assignments where values are structs did not properly uppercase field names in the Constants constructor.
    Jira: THRIFT-2857


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stigsb/thrift THRIFT-2857

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/289.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #289
    
----
commit 72360ce502783de3588a410b87f13743a1e4e3a9
Author: Stig Bakken <st...@zedge.net>
Date:   2014-11-25T21:33:58Z

    C#: constant assignments where values are structs did not properly
        uppercase field names in the Constants constructor

----


> C# generator creates uncompilable code for struct constants
> -----------------------------------------------------------
>
>                 Key: THRIFT-2857
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2857
>             Project: Thrift
>          Issue Type: Bug
>          Components: C# - Compiler
>    Affects Versions: 0.9.2
>            Reporter: Stig Bakken
>            Priority: Minor
>
> If you have constants with struct values, the C# generator does not uppercase member names, leading to compile errors.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)