You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "emilie-wang (via GitHub)" <gi...@apache.org> on 2025/10/09 19:30:34 UTC
[PR] table.inspect.partitions(): add filter expression [iceberg-python]
emilie-wang opened a new pull request, #2596:
URL: https://github.com/apache/iceberg-python/pull/2596
Closes [2562](https://github.com/apache/iceberg-python/issues/2562)
# Rationale for this change
Allow users to query specific partitions with predicate while inspecting table partitions.
As suggested, add a predicate as an argument into `table.inspect.partitions()` that defaults to ALWAYS_TRUE.
## Are these changes tested?
Yes, new integration tests added.
## Are there any user-facing changes?
I believe no.
<!-- In the case of user-facing changes, please add the changelog label. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] table.inspect.partitions(): add filter expression [iceberg-python]
Posted by "emilie-wang (via GitHub)" <gi...@apache.org>.
emilie-wang commented on code in PR #2596:
URL: https://github.com/apache/iceberg-python/pull/2596#discussion_r2417773701
##########
pyiceberg/table/__init__.py:
##########
@@ -1942,11 +1943,11 @@ def _check_sequence_number(min_sequence_number: int, manifest: ManifestFile) ->
and (manifest.sequence_number or INITIAL_SEQUENCE_NUMBER) >= min_sequence_number
)
- def plan_files(self) -> Iterable[FileScanTask]:
- """Plans the relevant files by filtering on the PartitionSpecs.
+ def scan_plan_helper(self) -> Iterator[ManifestEntry]:
Review Comment:
I refactored this part so that it can be reused in inspect.partitions(), but not sure if it is the best way.
could you please let me know your thoughts @Fokko? Thanks! And the name is terrible and I could rework on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] table.inspect.partitions(): add filter expression [iceberg-python]
Posted by "emilie-wang (via GitHub)" <gi...@apache.org>.
emilie-wang commented on PR #2596:
URL: https://github.com/apache/iceberg-python/pull/2596#issuecomment-3407718345
Hi @Fokko sorry to ping you and I did a few updates after the initial commit and would like to have your feedbacks. Thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] table.inspect.partitions(): add filter expression [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #2596:
URL: https://github.com/apache/iceberg-python/pull/2596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org