You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "bowenliang123 (via GitHub)" <gi...@apache.org> on 2023/04/07 15:14:01 UTC
[GitHub] [kyuubi] bowenliang123 opened a new pull request, #4677: Check generated policy file in test suite
bowenliang123 opened a new pull request, #4677:
URL: https://github.com/apache/kyuubi/pull/4677
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 closed pull request #4677: [AUTHZ] Check generated policy file in test suite
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 closed pull request #4677: [AUTHZ] Check generated policy file in test suite
URL: https://github.com/apache/kyuubi/pull/4677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4677: [AUTHZ] Check generated policy file in test suite
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #4677:
URL: https://github.com/apache/kyuubi/pull/4677#discussion_r1163851497
##########
.github/workflows/style.yml:
##########
@@ -34,7 +34,7 @@ jobs:
strategy:
matrix:
profiles:
- - '-Pflink-provided,hive-provided,spark-provided,spark-block-cleaner,spark-3.3,spark-3.2,spark-3.1,tpcds,kubernetes-it'
+ - '-Pflink-provided,hive-provided,spark-provided,spark-block-cleaner,spark-3.3,spark-3.2,spark-3.1,tpcds,kubernetes-it,gen-policy'
Review Comment:
If without adding this profile, the generator won't be checked for styling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4677: [AUTHZ] Check generated policy file in test suite
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #4677:
URL: https://github.com/apache/kyuubi/pull/4677#discussion_r1163890865
##########
.github/workflows/style.yml:
##########
@@ -34,7 +34,7 @@ jobs:
strategy:
matrix:
profiles:
- - '-Pflink-provided,hive-provided,spark-provided,spark-block-cleaner,spark-3.3,spark-3.2,spark-3.1,tpcds,kubernetes-it'
+ - '-Pflink-provided,hive-provided,spark-provided,spark-block-cleaner,spark-3.3,spark-3.2,spark-3.1,tpcds,kubernetes-it,gen-policy'
Review Comment:
I think you are right, since it's included via spotless path rules. Removed this profile in style workflow.
##########
.github/workflows/style.yml:
##########
@@ -34,7 +34,7 @@ jobs:
strategy:
matrix:
profiles:
- - '-Pflink-provided,hive-provided,spark-provided,spark-block-cleaner,spark-3.3,spark-3.2,spark-3.1,tpcds,kubernetes-it'
+ - '-Pflink-provided,hive-provided,spark-provided,spark-block-cleaner,spark-3.3,spark-3.2,spark-3.1,tpcds,kubernetes-it,gen-policy'
Review Comment:
I think you are right since it's included via spotless path rules. Removed this profile from style workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4677: [AUTHZ] Check generated policy file in test suite
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #4677:
URL: https://github.com/apache/kyuubi/pull/4677#discussion_r1161446887
##########
extensions/spark/kyuubi-spark-authz/pom.xml:
##########
@@ -332,14 +332,7 @@
<profiles>
<profile>
- <id>genpolicy</id>
- <activation>
- <!-- activated when Ranger version is identical to required-->
- <property>
- <name>ranger.version</name>
- <value>2.4.0</value>
- </property>
Review Comment:
Here removes the property-based activation introduced previously in #4585, since it's not activated with `ranger. version` set in project parent pom in value `2.4.0` (which requires more investigation in profile mechanism).
cc @Yikf
##########
extensions/spark/kyuubi-spark-authz/pom.xml:
##########
@@ -332,14 +332,7 @@
<profiles>
<profile>
- <id>genpolicy</id>
- <activation>
- <!-- activated when Ranger version is identical to required-->
- <property>
- <name>ranger.version</name>
- <value>2.4.0</value>
- </property>
Review Comment:
Here removes the property-based activation introduced previously in #4585, since it's not activated with `ranger.version` set in project parent pom in value `2.4.0` (which requires more investigation in profile mechanism).
cc @Yikf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4677: [AUTHZ] Check generated policy file in test suite
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4677:
URL: https://github.com/apache/kyuubi/pull/4677#issuecomment-1506535975
Thanks, merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4677: [AUTHZ] Check generated policy file in test suite
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #4677:
URL: https://github.com/apache/kyuubi/pull/4677#discussion_r1161440901
##########
extensions/spark/kyuubi-spark-authz/src/test/gen/scala/org/apache/kyuubi/plugin/spark/authz/gen/PolicyJsonFileGenerator.scala:
##########
@@ -17,49 +17,59 @@
package org.apache.kyuubi.plugin.spark.authz.gen
-import java.nio.file.Paths
+import java.nio.charset.StandardCharsets
+import java.nio.file.{Files, Paths, StandardOpenOption}
import java.util.UUID
import java.util.concurrent.atomic.AtomicLong
-import scala.language.implicitConversions
+import scala.collection.JavaConverters._
import com.fasterxml.jackson.annotation.JsonInclude.Include
import com.fasterxml.jackson.databind.{JsonNode, ObjectMapper}
import com.fasterxml.jackson.databind.json.JsonMapper
import com.fasterxml.jackson.databind.node.ObjectNode
import com.fasterxml.jackson.module.scala.DefaultScalaModule
import org.apache.ranger.plugin.model.RangerPolicy
+// scalastyle:off
+import org.scalatest.funsuite.AnyFunSuite
import org.apache.kyuubi.plugin.spark.authz.gen.KRangerPolicyItemAccess.allowTypes
-import org.apache.kyuubi.plugin.spark.authz.gen.PolicyJsonFileGenerator.RangerAccessType.{all, alter, create, drop, index, lock, read, select, update, use, write, RangerAccessType}
+import org.apache.kyuubi.plugin.spark.authz.gen.RangerAccessType._
import org.apache.kyuubi.plugin.spark.authz.gen.RangerClassConversions.getRangerObject
-
-/**
- * Generates the policy file to test/main/resources dir.
- *
- * Usage:
- * build/mvn scala:run -pl :kyuubi-spark-authz_2.12
- * -DmainClass=org.apache.kyuubi.plugin.spark.authz.gen.PolicyJsonFileGenerator
- */
-private object PolicyJsonFileGenerator {
- def main(args: Array[String]): Unit = {
- writeRangerServicePolicesJson()
- }
-
+class PolicyJsonFileGenerator extends AnyFunSuite {
+ // scalastyle:on
final private val mapper: ObjectMapper = JsonMapper.builder()
.addModule(DefaultScalaModule)
.serializationInclusion(Include.NON_NULL)
.build()
- def writeRangerServicePolicesJson(): Unit = {
+ test("Check ranger policy file") {
val pluginHome = getClass.getProtectionDomain.getCodeSource.getLocation.getPath
.split("target").head
val policyFileName = "sparkSql_hive_jenkins.json"
- val policyFile = Paths.get(pluginHome, "src", "test", "resources", policyFileName).toFile
- // scalastyle:off println
- println(s"Writing ranger policies to $policyFileName.")
- // scalastyle:on println
- mapper.writerWithDefaultPrettyPrinter().writeValue(policyFile, servicePolicies)
+ val policyFilePath =
+ Paths.get(pluginHome, "src", "test", "resources", policyFileName)
+ val generatedStr = mapper.writerWithDefaultPrettyPrinter()
+ .writeValueAsString(servicePolicies)
+
+ if (sys.env.get("KYUUBI_UPDATE").contains("1")) {
+ // scalastyle:off println
+ println(s"Writing ranger policies to $policyFileName.")
+ // scalastyle:on println
+ Files.write(
+ policyFilePath,
+ generatedStr.getBytes(StandardCharsets.UTF_8),
+ StandardOpenOption.CREATE,
+ StandardOpenOption.TRUNCATE_EXISTING)
+ } else {
+ val existedFileContent = Files.readAllLines(policyFilePath).asScala.mkString("\n")
+ withClue("Please regenerate the ranger policy file by running"
+ + "`KYUUBI_UPDATE=1 build/mvn clean test -Pgenpolicy"
Review Comment:
maybe `gen-policy` is better, align the style w/ others
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4677: [AUTHZ] Check generated policy file in test suite
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #4677:
URL: https://github.com/apache/kyuubi/pull/4677#discussion_r1163890865
##########
.github/workflows/style.yml:
##########
@@ -34,7 +34,7 @@ jobs:
strategy:
matrix:
profiles:
- - '-Pflink-provided,hive-provided,spark-provided,spark-block-cleaner,spark-3.3,spark-3.2,spark-3.1,tpcds,kubernetes-it'
+ - '-Pflink-provided,hive-provided,spark-provided,spark-block-cleaner,spark-3.3,spark-3.2,spark-3.1,tpcds,kubernetes-it,gen-policy'
Review Comment:
I think you are right since it's included via spotless path rules. Removed this profile from the style workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4677: [AUTHZ] Check generated policy file in test suite
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #4677:
URL: https://github.com/apache/kyuubi/pull/4677#discussion_r1161447487
##########
extensions/spark/kyuubi-spark-authz/src/test/gen/scala/org/apache/kyuubi/plugin/spark/authz/gen/PolicyJsonFileGenerator.scala:
##########
@@ -17,49 +17,59 @@
package org.apache.kyuubi.plugin.spark.authz.gen
-import java.nio.file.Paths
+import java.nio.charset.StandardCharsets
+import java.nio.file.{Files, Paths, StandardOpenOption}
import java.util.UUID
import java.util.concurrent.atomic.AtomicLong
-import scala.language.implicitConversions
+import scala.collection.JavaConverters._
import com.fasterxml.jackson.annotation.JsonInclude.Include
import com.fasterxml.jackson.databind.{JsonNode, ObjectMapper}
import com.fasterxml.jackson.databind.json.JsonMapper
import com.fasterxml.jackson.databind.node.ObjectNode
import com.fasterxml.jackson.module.scala.DefaultScalaModule
import org.apache.ranger.plugin.model.RangerPolicy
+// scalastyle:off
+import org.scalatest.funsuite.AnyFunSuite
import org.apache.kyuubi.plugin.spark.authz.gen.KRangerPolicyItemAccess.allowTypes
-import org.apache.kyuubi.plugin.spark.authz.gen.PolicyJsonFileGenerator.RangerAccessType.{all, alter, create, drop, index, lock, read, select, update, use, write, RangerAccessType}
+import org.apache.kyuubi.plugin.spark.authz.gen.RangerAccessType._
import org.apache.kyuubi.plugin.spark.authz.gen.RangerClassConversions.getRangerObject
-
-/**
- * Generates the policy file to test/main/resources dir.
- *
- * Usage:
- * build/mvn scala:run -pl :kyuubi-spark-authz_2.12
- * -DmainClass=org.apache.kyuubi.plugin.spark.authz.gen.PolicyJsonFileGenerator
- */
-private object PolicyJsonFileGenerator {
- def main(args: Array[String]): Unit = {
- writeRangerServicePolicesJson()
- }
-
+class PolicyJsonFileGenerator extends AnyFunSuite {
+ // scalastyle:on
final private val mapper: ObjectMapper = JsonMapper.builder()
.addModule(DefaultScalaModule)
.serializationInclusion(Include.NON_NULL)
.build()
- def writeRangerServicePolicesJson(): Unit = {
+ test("Check ranger policy file") {
val pluginHome = getClass.getProtectionDomain.getCodeSource.getLocation.getPath
.split("target").head
val policyFileName = "sparkSql_hive_jenkins.json"
- val policyFile = Paths.get(pluginHome, "src", "test", "resources", policyFileName).toFile
- // scalastyle:off println
- println(s"Writing ranger policies to $policyFileName.")
- // scalastyle:on println
- mapper.writerWithDefaultPrettyPrinter().writeValue(policyFile, servicePolicies)
+ val policyFilePath =
+ Paths.get(pluginHome, "src", "test", "resources", policyFileName)
+ val generatedStr = mapper.writerWithDefaultPrettyPrinter()
+ .writeValueAsString(servicePolicies)
+
+ if (sys.env.get("KYUUBI_UPDATE").contains("1")) {
+ // scalastyle:off println
+ println(s"Writing ranger policies to $policyFileName.")
+ // scalastyle:on println
+ Files.write(
+ policyFilePath,
+ generatedStr.getBytes(StandardCharsets.UTF_8),
+ StandardOpenOption.CREATE,
+ StandardOpenOption.TRUNCATE_EXISTING)
+ } else {
+ val existedFileContent = Files.readAllLines(policyFilePath).asScala.mkString("\n")
+ withClue("Please regenerate the ranger policy file by running"
+ + "`KYUUBI_UPDATE=1 build/mvn clean test -Pgenpolicy"
Review Comment:
Good point, changed the profile name to `gen-policy`. Also updated usages in comments and ci workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4677: [AUTHZ] Check generated policy file in test suite
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #4677:
URL: https://github.com/apache/kyuubi/pull/4677#discussion_r1161687582
##########
extensions/spark/kyuubi-spark-authz/pom.xml:
##########
@@ -332,14 +332,7 @@
<profiles>
<profile>
- <id>genpolicy</id>
- <activation>
- <!-- activated when Ranger version is identical to required-->
- <property>
- <name>ranger.version</name>
- <value>2.4.0</value>
- </property>
Review Comment:
Yes, and the profile name changed to `gen-policy`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] yaooqinn commented on a diff in pull request #4677: [AUTHZ] Check generated policy file in test suite
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #4677:
URL: https://github.com/apache/kyuubi/pull/4677#discussion_r1163854480
##########
.github/workflows/style.yml:
##########
@@ -34,7 +34,7 @@ jobs:
strategy:
matrix:
profiles:
- - '-Pflink-provided,hive-provided,spark-provided,spark-block-cleaner,spark-3.3,spark-3.2,spark-3.1,tpcds,kubernetes-it'
+ - '-Pflink-provided,hive-provided,spark-provided,spark-block-cleaner,spark-3.3,spark-3.2,spark-3.1,tpcds,kubernetes-it,gen-policy'
Review Comment:
I don't understand why
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] Yikf commented on a diff in pull request #4677: [AUTHZ] Check generated policy file in test suite
Posted by "Yikf (via GitHub)" <gi...@apache.org>.
Yikf commented on code in PR #4677:
URL: https://github.com/apache/kyuubi/pull/4677#discussion_r1161624466
##########
extensions/spark/kyuubi-spark-authz/pom.xml:
##########
@@ -332,14 +332,7 @@
<profiles>
<profile>
- <id>genpolicy</id>
- <activation>
- <!-- activated when Ranger version is identical to required-->
- <property>
- <name>ranger.version</name>
- <value>2.4.0</value>
- </property>
Review Comment:
Thanks for ping me, So do we have to specify the profile manually now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] codecov-commenter commented on pull request #4677: [AUTHZ] Check generated policy file in test suite
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4677:
URL: https://github.com/apache/kyuubi/pull/4677#issuecomment-1501413999
## [Codecov](https://codecov.io/gh/apache/kyuubi/pull/4677?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4677](https://codecov.io/gh/apache/kyuubi/pull/4677?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (892faf5) into [master](https://codecov.io/gh/apache/kyuubi/commit/5faebb1e75b57491ca655e0ba6fceacde5ef9459?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5faebb1) will **decrease** coverage by `0.04%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 892faf5 differs from pull request most recent head 6366c50. Consider uploading reports for the commit 6366c50 to get more accurate results
```diff
@@ Coverage Diff @@
## master #4677 +/- ##
============================================
- Coverage 57.68% 57.64% -0.04%
Complexity 13 13
============================================
Files 579 579
Lines 32012 32012
Branches 4275 4275
============================================
- Hits 18465 18453 -12
- Misses 11784 11789 +5
- Partials 1763 1770 +7
```
[see 9 files with indirect coverage changes](https://codecov.io/gh/apache/kyuubi/pull/4677/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] yaooqinn commented on a diff in pull request #4677: [AUTHZ] Check generated policy file in test suite
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #4677:
URL: https://github.com/apache/kyuubi/pull/4677#discussion_r1163847296
##########
.github/workflows/style.yml:
##########
@@ -34,7 +34,7 @@ jobs:
strategy:
matrix:
profiles:
- - '-Pflink-provided,hive-provided,spark-provided,spark-block-cleaner,spark-3.3,spark-3.2,spark-3.1,tpcds,kubernetes-it'
+ - '-Pflink-provided,hive-provided,spark-provided,spark-block-cleaner,spark-3.3,spark-3.2,spark-3.1,tpcds,kubernetes-it,gen-policy'
Review Comment:
This is not necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org