You are viewing a plain text version of this content. The canonical link for it is here.
Posted to qa@openoffice.apache.org by Rob Weir <ro...@apache.org> on 2013/02/13 22:08:23 UTC

Verifying fixes -- another easy task

Hello everyone,  I received this question via an email, how to verify
fixes.   This is a good question.

Most of us have been running AOO 3.4.1 and confirming defect reports.
So we were running a stable version of OpenOffice (most recent
release) and deciding which user-submitted bug reports were real bugs
and which were not.  This is an important task since it helps
developers know what things they should fix.   The flow works like
this:

1) User submits bug report and it is in the UNCONFIRMED state,

2) QA tests the bug and if they can reproduce it they set it to CONFIRMED state.

3) When a developer start to work on it they set the defect report to
the ACCEPTED state.

4) When a fix is checked in they set the report to the FIXED state.

It comes back to QA now, to verify that the bug is actually fixed.
Why?  Errare humanum est -- to err is human.  We do this extra check
to make sure the developer did not make a mistake.  What kind of
mistake?

a) Maybe they misunderstood the bug and didn't really fix it

b) Maybe they fixed it but did not check in the fix right

c) Maybe the fixed part of the bug but missed part of it

d) maybe the fixed the bug but broke some related functionality

In any case, we try to verify all bug fixes.

You can get a list of fixed defects with a query like this:

https://issues.apache.org/ooo/buglist.cgi?f1=cf_bug_type&list_id=45896&o1=equals&resolution=FIXED&query_format=advanced&bug_status=RESOLVED&v1=DEFECT&target_milestone=AOO%203.4.0&target_milestone=AOO%203.4.1&target_milestone=AOO%203.5.0&target_milestone=AOO%204.0&target_milestone=AOO%204.0.0

And you can get "snapshot" builds of AOO 4.0 here:
http://ci.apache.org/projects/openoffice/index.html

Note: Since these builds are not already tested they may have bugs,
crashes, data loss, etc.  I would not recommend using them for your
daily work.  But they should be stable enough to test with,

So you then re-test the steps from the bug report.  If you can verify
that the fix works correctly then you mark the issue closed.  Enter
the build number you tested with as a comment.   If the bug still
exists, then change the issue status to REOPEN.  And if, in your
testing, you find a new, unrelated bug, then enter a new defect report
for that.

Regards,

-Rob

Re: Verifying fixes -- another easy task

Posted by Ji Yan <ya...@gmail.com>.
This is really a good proposal, it will help developer knows if the problem
is fixed indeed. One reminder to all of us, when verifying fixed bug we
should use correct build. If the problem fixed in trunk stream, we should
use nightly build to verify, otherwise we need to use branch stream build
e.g. ia2 branch or l10n branch


On Thu, Feb 14, 2013 at 5:08 AM, Rob Weir <ro...@apache.org> wrote:

> Hello everyone,  I received this question via an email, how to verify
> fixes.   This is a good question.
>
> Most of us have been running AOO 3.4.1 and confirming defect reports.
> So we were running a stable version of OpenOffice (most recent
> release) and deciding which user-submitted bug reports were real bugs
> and which were not.  This is an important task since it helps
> developers know what things they should fix.   The flow works like
> this:
>
> 1) User submits bug report and it is in the UNCONFIRMED state,
>
> 2) QA tests the bug and if they can reproduce it they set it to CONFIRMED
> state.
>
> 3) When a developer start to work on it they set the defect report to
> the ACCEPTED state.
>
> 4) When a fix is checked in they set the report to the FIXED state.
>
> It comes back to QA now, to verify that the bug is actually fixed.
> Why?  Errare humanum est -- to err is human.  We do this extra check
> to make sure the developer did not make a mistake.  What kind of
> mistake?
>
> a) Maybe they misunderstood the bug and didn't really fix it
>
> b) Maybe they fixed it but did not check in the fix right
>
> c) Maybe the fixed part of the bug but missed part of it
>
> d) maybe the fixed the bug but broke some related functionality
>
> In any case, we try to verify all bug fixes.
>
> You can get a list of fixed defects with a query like this:
>
>
> https://issues.apache.org/ooo/buglist.cgi?f1=cf_bug_type&list_id=45896&o1=equals&resolution=FIXED&query_format=advanced&bug_status=RESOLVED&v1=DEFECT&target_milestone=AOO%203.4.0&target_milestone=AOO%203.4.1&target_milestone=AOO%203.5.0&target_milestone=AOO%204.0&target_milestone=AOO%204.0.0
>
> And you can get "snapshot" builds of AOO 4.0 here:
> http://ci.apache.org/projects/openoffice/index.html
>
> Note: Since these builds are not already tested they may have bugs,
> crashes, data loss, etc.  I would not recommend using them for your
> daily work.  But they should be stable enough to test with,
>
> So you then re-test the steps from the bug report.  If you can verify
> that the fix works correctly then you mark the issue closed.  Enter
> the build number you tested with as a comment.   If the bug still
> exists, then change the issue status to REOPEN.  And if, in your
> testing, you find a new, unrelated bug, then enter a new defect report
> for that.
>
> Regards,
>
> -Rob
>



-- 


Thanks & Best Regards, Yan Ji

Re: Fwd: Verifying fixes -- another easy task

Posted by Andrea Pescetti <pe...@apache.org>.
Diego Valle Rosado wrote:
> https://issues.apache.org/ooo/show_bug.cgi?id=118751 ...
> revision number>= 1445663 ...
> Can I use another revision number to verify if it was fixed, for exemple
> the revision number: 1446443 or 1446427.

Sure! Revision number >= 1445663 means just that. Anything later (i.e., 
with an higher revision number) than revision 1445663 will work too.

Regards,
   Andrea.

Fwd: Verifying fixes -- another easy task

Posted by Diego Valle Rosado <di...@gmail.com>.
hello


One of the bugs that I confirmed,
https://issues.apache.org/ooo/show_bug.cgi?id=118751
I received an email of BZ which said that Ariel is assigned to check if the
bug is already fixed.
Ariel told me that now the bug has to be VERIFIED as FIXED, you can do this
by downloading a build
and I could do that by downloading a build from the build bots that has
revision number >= 1445663

I saw in the link http://ci.apache.org/projects/openoffice/index.html that
is not the revision number: 1445663.

Can I use another revision number to verify if it was fixed, for exemple
the revision number: 1446443 or 1446427.


Regards